Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2712552rdb; Mon, 12 Feb 2024 14:07:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUB5WjE6tXJEGBQDCrfPcRXh/SfbrLYZieYMLUyp8Gz0myiO9b21QofJykSk9etRT+wk8k01hsE6XXi221aeaJl5sQZdJT5Vv2LWE2r1Q== X-Google-Smtp-Source: AGHT+IEmoA0BF7wkrQSngyLAx2BKVdjdkaSH2p6xX08JD0Eg5ixbwv/Rp6xjFJsnWVI2oE7ePoyn X-Received: by 2002:a25:2688:0:b0:dcc:275e:7323 with SMTP id m130-20020a252688000000b00dcc275e7323mr917622ybm.18.1707775670271; Mon, 12 Feb 2024 14:07:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707775670; cv=pass; d=google.com; s=arc-20160816; b=rXMsbtWLE9cHMrFLOu7hr8nC9wZOvuY+/7OqN8x9YqaJzJZH/DfVdOXX4sUo/hhFvr 2/HJcUU0AmwGHlxaUEsxqGTM7NMRjLhlSH0WeW8mahzohLxWUfSHgMi1Tu8yA30G1JmQ agUAyjOrlUdzmej/2EicAikwmVWODqH0wQUG9e5O/OJECV3tVgeWRs+snMq/GAadIgsX c7vRX3Yu2SuSWm6PlwshU52A9JxqWoH55pVQBA6QcgtEzTH9Khdpsm2QVfxxMhNeL7uY /amXbW8DzXsgzn4z2WxggLKqh6szGO0ruf4p9qUHl7TEAzND3QviwWifJ6XId+LfO2Mo JvgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8TgitNbd1mPIu/vo61kw5GTuium5jPqAU8tOs86SzdA=; fh=1Sc8Fyb56hcNxBjCfM7S595E5rzZSG7s2MokQd9g9Mk=; b=NxfwdoQ+aLnsK19WRLWKi93R9x8dB0e+1Oe6/GzWOtdFeKEnSqWxmju0IdGFQjcKEP 9ewhKRtfWN71uI1MJoQMICDMHDj5j1lN77YIABOw3UdHouvnjAuE7768vXorCcnvT9Ov TxExvqbcnFC2TjFtt0wAtebPpHI3tEjQ0pW5CAawBnbzuVPuSFeHkJM40Ite2zkTrPka p3NY5IYHh/pVXNmyQfEv4opeYGVaDBseS+80V7Dw13SQty+HSLQPpOt87eCIRag3IQ+l Azb+DOvmqTjov7RQp1n1Njqt2P/RO5clto1Gk756S5BSlYjo3bURlyAr2FLW5b+7l25/ 6Pjg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XdtMu9WI; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-62453-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62453-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=2; AJvYcCXdRHABe45smTjhnf8H952y8bMPFOl7l4sMiES5BTMakG/J0bnEgPq3CNC2AdNUKCzXzCEFf28kFWwduqJe9xxS2tG2KGgwdiCH8xVIAw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g20-20020a05620a109400b0078591341b79si6898228qkk.734.2024.02.12.14.07.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 14:07:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62453-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XdtMu9WI; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-62453-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62453-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EB4581C21F6C for ; Mon, 12 Feb 2024 22:07:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B90F4D9EA; Mon, 12 Feb 2024 22:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XdtMu9WI" Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B404CE1B for ; Mon, 12 Feb 2024 22:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707775655; cv=none; b=Y0OPYV5z5A3CB3rMBghs6QjTJMIfUjgqIdWn+pJvvFJ+qEsTCKBiusgB93CTEm8Pn50wSEMB9aMXXa/5fgo8FtLlOzughaLsfhOI4eKrkIqYBOwkr6kp4IYuHgGsdrDknXTUuDFFGyuZDA6cj1l7kh1OJjI3cMOV05/j9MzBKBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707775655; c=relaxed/simple; bh=o3J+H6QK+ft/jI/HQ/DmCribE5VO5VgEVrwjTsOd3+s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e0xsyQkHghuurRu8fFU2mEdJvjkqbgqZ4GPnJEYWfK5DqK9DFavLXRhorPtjwfRRPRLDPwG5IoyTtCbLX1eQWB/pI3VbfkJLMBKF7C2a1/dNFgMOLb3z8cHF1a26Lmo6R1mUyEe/fO4VBUo6jshqAw203f7AnU3Ube/lfhvJC0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=XdtMu9WI; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-59a31c14100so1505546eaf.0 for ; Mon, 12 Feb 2024 14:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707775652; x=1708380452; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8TgitNbd1mPIu/vo61kw5GTuium5jPqAU8tOs86SzdA=; b=XdtMu9WIFB9uc4U8zSKaU7+In/8Xo4bXeWei2q9/eXsCtsC9kPrJ140XpB915ij5CC WDYU5SG//GaarAXX6bV/HN1JAUy2rPoEDCzCeVwGRL8evFCYUezqzcft/JPRGyvYjtSj Mvkn98lqNGW+hsbHMDsXH9mejpzKBqIQH+/ZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707775652; x=1708380452; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8TgitNbd1mPIu/vo61kw5GTuium5jPqAU8tOs86SzdA=; b=bmly59ja0zIGgyuNbULqLnnBYYOvjvcErP02yEgPROeunMWzkOKjYijysKNR3jLKBk GAZS9fHqeqzX/lPLYqpq6buQeYVeM0PUoLLZ2eNmi4cUr49NAfyrRCcKjWntFk76Ql3S Y5DKcG4FEEuzkH8LwP0NpKIwm5+X62nAIkGkdvM+6a9ctH2y1koefWKSIcs+JU5xW0y+ aRy2ez2G3efZZB9yWLy8X7pD3oeRLOH7VX/DuamuP1Zv5le8IP0qqfCMxma5/UYTKw3U /oIypzorRUxANd91hBEdd9D/iSocklrlai0uBQUo0r8IlJHOzMaZoWgFsSV2p5/Hus/q U0fQ== X-Forwarded-Encrypted: i=1; AJvYcCXCum7HwYzlhTn/BXF42nwk2fO6rFQdZD3zlzJhkSYm+ZQU5vaTKs95HJwIqLAh4mNj5TUI6rBykKk34BwIbmvfHc184OIOX9Xp3/bm X-Gm-Message-State: AOJu0YwYm2hsW1lvHC9RYw+TSiDAfC0AUePPqepqCDnhlTKyg+SVrmzc Jsr8zMEUGBhEGAaQvLiAo7PZ73+dAfVJRywTV85w/WBRJZBHYOgyChLvCAfUlg== X-Received: by 2002:a05:6358:5620:b0:176:b16a:f392 with SMTP id b32-20020a056358562000b00176b16af392mr12132731rwf.10.1707775652109; Mon, 12 Feb 2024 14:07:32 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV8Gn2OxEuKk3FWjwu68UFaXsDD8RjGlM9njWSjabpecNhnMIF1qXxYsfC+/txWlVHC0uNpzndoDwf4ESht85jrpR/r/ZEAKPrZUfbCo36fTMhd5H7f89i82wLKok+ONkyckgWyvxvKZtguOZF19Lc8xEaaVmAhtDm4F98Jh5EiEU3bzhs2RJR7RX0b9EomlrTIMl2Vxf2JdkvMNlJ0310atgxvP0jRcjEz3LHTvUEeurXD9TVukzAeS1b+rDlDTNf71RARiXOdJMocjBhVxo0y425GBYWZy8HcJ3+Ewgj4Xbb5EiVCQj1rNNHF2o6HLhHP4A5G2EKni1Zp8kjTIQjZ7s2fZJ1D72MCwgSyHivTpm6mOTQtfxtt+idhBUM0KbKxWyCg7Fv1qyqxIRjf1NF3si4y72XuPquRerzGB+jFwtjZvokCokPWHXZe7fe9UFmeZqPwFzwdNYmKgzWkpfwmCqyBJbExowRztIrXkyAP1VdjX4X5Qc7dYEOmYc2WTGh3xtGJQr2Xo9EofKKCkp3mJ75b52BYwQbiQKEcmvC9ksvZybPWUZsRvCHQn+/hCuu/sVnHaFqQ2wTv1z7S/eBVKDqADDYHWqcS27arhMV3Qjz5uTY6EdWZHoxUwWBMH6jThkfIXMpBBFqDYg4U/KSoQpNzl38XKZW5h7gL6/YWlncNExg8DDgYF1aMOe7inz7E4L4FD63Iu9G9AHU8reaLM/OMt3uQXOlbrIrQE+z6JttijOLciccsYCwdIBgLeFq6N7Cw2y5pw8g/+8JUMVk= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id p2-20020aa78602000000b006e0eece1ca4sm974755pfn.4.2024.02.12.14.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 14:07:31 -0800 (PST) Date: Mon, 12 Feb 2024 14:07:31 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Subject: Re: [PATCH v3 03/35] fs: Convert alloc_inode_sb() to a macro Message-ID: <202402121407.A6C61F37AE@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-4-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-4-surenb@google.com> On Mon, Feb 12, 2024 at 01:38:49PM -0800, Suren Baghdasaryan wrote: > From: Kent Overstreet > > We're introducing alloc tagging, which tracks memory allocations by > callsite. Converting alloc_inode_sb() to a macro means allocations will > be tracked by its caller, which is a bit more useful. > > Signed-off-by: Kent Overstreet Yup, getting these all doing direct calls will be nice. Reviewed-by: Kees Cook -- Kees Cook