Received-SPF: pass (google.com: domain of linux-kernel+bounces-62454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <dfa253e01ba9164abdd47da489c2a3da5da5cc93.camel@linux.intel.com>
Subject: Re: [PATCH] tracing: Fix wasted memory in saved_cmdlines logic
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>, LKML
 <linux-kernel@vger.kernel.org>,  Linux trace kernel
 <linux-trace-kernel@vger.kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@efficios.com>, Vincent Donnefort
 <vdonnefort@google.com>,  Sven Schnelle <svens@linux.ibm.com>, Mete Durlu
 <meted@linux.ibm.com>, stable <stable@vger.kernel.org>
Date: Mon, 12 Feb 2024 14:08:29 -0800
In-Reply-To: <20240208105328.7e73f71d@rorschach.local.home>
References: <20240208105328.7e73f71d@rorschach.local.home>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-02-08 at 10:53 -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>=20
> While looking at improving the saved_cmdlines cache I found a huge amount
> of wasted memory that should be used for the cmdlines.
>=20
> The tracing data saves pids during the trace. At sched switch, if a trace
> occurred, it will save the comm of the task that did the trace. This is
> saved in a "cache" that maps pids to comms and exposed to user space via
> the /sys/kernel/tracing/saved_cmdlines file. Currently it only caches by
> default 128 comms.
>=20
> The structure that uses this creates an array to store the pids using
> PID_MAX_DEFAULT (which is usually set to 32768). This causes the structur=
e
> to be of the size of 131104 bytes on 64 bit machines.
>=20
> In hex: 131104 =3D 0x20020, and since the kernel allocates generic memory=
 in
> powers of two, the kernel would allocate 0x40000 or 262144 bytes to store
> this structure. That leaves 131040 bytes of wasted space.
>=20
> Worse, the structure points to an allocated array to store the comm names=
,
> which is 16 bytes times the amount of names to save (currently 128), whic=
h
> is 2048 bytes. Instead of allocating a separate array, make the structure
> end with a variable length string and use the extra space for that.
>=20
> This is similar to a recommendation that Linus had made about eventfs_ino=
de names:
>=20
>   https://lore.kernel.org/all/20240130190355.11486-5-torvalds@linux-found=
ation.org/
>=20
> Instead of allocating a separate string array to hold the saved comms,
> have the structure end with: char saved_cmdlines[]; and round up to the
> next power of two over sizeof(struct saved_cmdline_buffers) + num_cmdline=
s * TASK_COMM_LEN
> It will use this extra space for the saved_cmdline portion.
>=20
> Now, instead of saving only 128 comms by default, by using this wasted
> space at the end of the structure it can save over 8000 comms and even
> saves space by removing the need for allocating the other array.

The change looks good to me code wise.  But it seems like we are still
overallocating as we can now accommodate 8000 comms when 128
was asked for.

Wonder if we can reduce the default ask to 127 comm so we don't have to
go to the next page order?

Tim