Received-SPF: pass (google.com: domain of linux-kernel+bounces-62236-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <4f3fa9e4-3000-4a96-a7f6-e32e69b57a84@infradead.org>
Date: Mon, 12 Feb 2024 10:56:40 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RESEND] iosys-map: fix typos
Content-Language: en-US
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
References: <20240212042837.21071-1-rdunlap@infradead.org>
 <bf0d02d4-2c90-40a4-8018-bd96a01f2751@suse.de>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <bf0d02d4-2c90-40a4-8018-bd96a01f2751@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 2/11/24 23:13, Thomas Zimmermann wrote:
> Hi
> 
> Am 12.02.24 um 05:28 schrieb Randy Dunlap:
>> Correct spellos/typos in comments.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>>   include/linux/iosys-map.h |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff -- a/include/linux/iosys-map.h b/include/linux/iosys-map.h
>> --- a/include/linux/iosys-map.h
>> +++ b/include/linux/iosys-map.h
>> @@ -34,7 +34,7 @@
>>    * the same driver for allocation, read and write operations.
>>    *
>>    * Open-coding access to :c:type:`struct iosys_map <iosys_map>` is considered
>> - * bad style. Rather then accessing its fields directly, use one of the provided
>> + * bad style. Rather than accessing its fields directly, use one of the provided
> Ok.
>>    * helper functions, or implement your own. For example, instances of
>>    * :c:type:`struct iosys_map <iosys_map>` can be initialized statically with
>>    * IOSYS_MAP_INIT_VADDR(), or at runtime with iosys_map_set_vaddr(). These
>> @@ -85,7 +85,7 @@
>>    *    if (iosys_map_is_equal(&sys_map, &io_map))
>>    *        // always false
>>    *
>> - * A set up instance of struct iosys_map can be used to access or manipulate the
>> + * A setup instance of struct iosys_map can be used to access or manipulate the
> That's not a typo. This refers to "an instance that has been set up".
> 

Thanks. I'll drop that part and resend the other.

> 
>>    * buffer memory. Depending on the location of the memory, the provided helpers
>>    * will pick the correct operations. Data can be copied into the memory with
>>    * iosys_map_memcpy_to(). The address can be manipulated with iosys_map_incr().
> 

-- 
#Randy