Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2746486rdb; Mon, 12 Feb 2024 15:38:01 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXAziJaMSCI8FgLYHEE5XeEk67/vozpFn9oDXrZF4w0Y28hLwrc0fojQ0CrKIYOOt2Fz8rUiKW869kI670YW7XpJbtxNbmfYe4z6D1Qog== X-Google-Smtp-Source: AGHT+IHPIS5NnuEZLV7K75j2m+7CYeOwFZpxR9N++2lgdyrBpGHvUee9aULKGmFzaXJkY1szfyic X-Received: by 2002:a17:90a:bd8b:b0:298:9d25:aa9f with SMTP id z11-20020a17090abd8b00b002989d25aa9fmr666220pjr.45.1707781081240; Mon, 12 Feb 2024 15:38:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707781081; cv=pass; d=google.com; s=arc-20160816; b=gG3TaBnztRKbJgDFn6H2HQiRk6izon2rt79d0LyV1XqfMovsYueoudRoB8EFGdFcf1 E9X01aUQ3KbAZRtRBiG1RfqlES7Vp/lCXHUy4lF0aGblZ6tRoofP8OKl5iopUwaKFQq5 OXgkQca2zoad0PRRchhAzAXDwFjBPEAhLNuM72h9yUTaLVJFyEeCDcyOlGgoELIQrlYS L+gLiKP2Pa/cnqtBD/mLBZCO6l2cxuNgM2Tn7jdv/+u7kntqOLJ/FXwDd8cIAF+23R1B JP9/DITdyaCSVhEXfQeYMoQU90UUW9WHXaX1RYW1RU/DjUc4HzJMzY559QzA684NxrjW gSOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=LsU9obm5HHB5cRDNYhcAMJDw33NccTuhuO4lL/MGV3w=; fh=VEHYMoMAjYK4djYRoWNULNwX8hvzPpZSJQgv4Fakipo=; b=Us7BxLy4X9XRdBQSuLLaTT2yl2W/ezGDsQCzNlTqW41DFqeDGqEgoGKUtxIYrx2Xk1 z8Xp6v++OQSFE13OezBDH/ei3jowBDnx7lgrEZbrHfe6mi9zaJJhCrHFMRAof71DO7Xm sqIwCnVbnhI06lYlflWEh+GcGlJix1KTpanXucvJXtUnwusZzgDm/6rE76LYJLKALFsF S84832M4iE/UEMaoSWwcY6pttbH6NuPdJTRtk6dt7Iq9wUcH+jQbqz1zc4iGrIu/DF6R knZ1Yt/VWRf8kiBeCEtHCuauXC+mvbNYD4VbCExhrZj8AJymAVo3PQKB8GS66D+3246b ktWg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KC6g57XH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62548-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62548-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCW4SJYAPblAI7Xof+E8DjQEAmovUGDErVxrqY+63kSPB4PRn9edEP3BDV694WssjMVVWEaPtwTK9qIxhTzS3YKf+/r0Pt2BSpXYsl3TPQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id fw24-20020a17090b129800b002933854dea6si981469pjb.11.2024.02.12.15.38.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 15:38:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62548-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KC6g57XH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62548-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62548-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DE480284587 for ; Mon, 12 Feb 2024 23:38:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E45850257; Mon, 12 Feb 2024 23:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KC6g57XH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADD764F894; Mon, 12 Feb 2024 23:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707781030; cv=none; b=g34Hc+xR/DFIUQwi8Ic/oPLleoY+PZjl8bzGvjVba97gBk1FS9ZCcLHrFlFtVjNGBMf4JJbfVTT7ZSPHRYnTh+DPSgMPtrtdYRe2/DehHYBz+JNfkN3NhSY41rJJhUD7uKxlqIhw2GtVuHJBtd2RaV3HEvokaHxrMoE+NYp/F7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707781030; c=relaxed/simple; bh=m7SE+hlCtBtb3IlhPvvEXPX6CE31ZA44ZY0MoUwNa78=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=D1+Gl20tP9eRf4ClfnZ8EAmT5iT5y4wibMZfHLeWn+WRS9g6iT+9nnGEOz3EHanoDyabSxH6mpvi9o/Gy+zi/UFrz6vnexwGI/ZrALtm8k6EPEL4sVWiyUTa20YsmuH9Yli7+pL4jyyAIXdLQdt89eGlWL4ozxcyZC8dDHGWTfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KC6g57XH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C790C43390; Mon, 12 Feb 2024 23:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707781030; bh=m7SE+hlCtBtb3IlhPvvEXPX6CE31ZA44ZY0MoUwNa78=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KC6g57XHdGbJo73oXcNvpOjej08py6XiO+tc2vsK4lOiYHFm7n5d+rxU9PETChsAP RGmwRJxeVv+vaU5BwgzuGdjQnDwZ8TjD/4t7DznkkdFUlq8eZw53h1sipgJMsgtZ4R 6TCeUTvdo15Zwbz/iDca6ZltoICEuPPU62gGKDkc1Wl7H7mHax9bqST9HuPpRyza1N 5LH2M1FEuZURLiB8xnYHk5Cs9vxM71OXJQtNS7+dKKI3vfI0eB2f/6UwOSTsV9LewK F9gnNNw5r8ULkjbljxtoA9Tku/h4Ng+6BlMzKV0/SVyRXTmYJLVMVdfm1qCPMh0CPX uqlWN2+8Mj9LA== Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-51197ca63f5so287708e87.1; Mon, 12 Feb 2024 15:37:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU7l5TTxRI7xE4Bi2Z6wwzFG3knQrHyEgpzdSIfjjaN04gkIkFGurRXjC3RbiuKh4xVFTttIETey8n98xEBvT4JUj3beBfAd/vUVg+p0NSyZzXaipfZFjejY0vuBhyQmi6HZU1vUTxGhg== X-Gm-Message-State: AOJu0Yx72WzWC1iqDKoe9ZtmoRUDQWL1VzXNX+DPMeAUdVJ5Ied+lyaP 0O2McriJoiOi4I/GR6itlonzSjqDOpwhI8DfrO6uYW7mlMkpYfnwycIpJponrsxzNsFrlIuekug BdreI2pMvZJb4P4nkq8KNg1LYV54= X-Received: by 2002:a05:6512:214e:b0:511:82ab:9c88 with SMTP id s14-20020a056512214e00b0051182ab9c88mr3668851lfr.68.1707781028513; Mon, 12 Feb 2024 15:37:08 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240206085511.2841555-1-linan666@huaweicloud.com> In-Reply-To: <20240206085511.2841555-1-linan666@huaweicloud.com> From: Song Liu Date: Mon, 12 Feb 2024 15:36:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/9] bugfix of MD_CLOSING and clean up md_ioctl() To: linan666@huaweicloud.com Cc: mariusz.tkaczyk@linux.intel.com, shli@fb.com, neilb@suse.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Li Nan, On Tue, Feb 6, 2024 at 1:00=E2=80=AFAM wrote: > > From: Li Nan > > Changes in v6: > - in patch 2, return directly. > - in patch 4, return directly in case GET_DISK_INFO and GET_ARRAY_INFO. > - in patch 7, rewrite commit message. > - add patch 8, clean up openers check. > > Changes in v5: > - add patches 1-4 to clean up md_ioct(), pathc 4 can help us clean up > local variable 'clear_md_closing'. > - in patches 5 and 7, clean up local variable 'clear_md_closing'. > > By the way, md_ioctl() is not readable now, I wanna to re-write it later > to make it only have one 'switch' like other drivers. Thanks for the patchset, and sorry for the delay. The patchset looks good to me. However, it doesn't apply to md-6.9 branch. Could you please resend or let me know the base branch/commit of the set? Thanks, Song