Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2783331rdb; Mon, 12 Feb 2024 17:17:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFPmy6E7u9yxXIuoKSUIHnti/ooB0Zm6Fpe5htkmRvipkVUdtYas3Gmdtphs9v3GGXQJ+w X-Received: by 2002:aa7:d893:0:b0:561:4238:e6e2 with SMTP id u19-20020aa7d893000000b005614238e6e2mr6106466edq.29.1707787058403; Mon, 12 Feb 2024 17:17:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707787058; cv=pass; d=google.com; s=arc-20160816; b=n6wS/ACXbYtJNzpXoSRxz0Nx6u1cC6wH1cLp2y8zl2/bg/dddJzduL6cnrZVgpbes1 gPvmXy/m/J2xYu7AbEI5gqyx1Rg4r6H8DYgdJ136g3XsejESc98a0eMOfGwHU0bdcgxs 3kZ3qdYoPyGxCDAPEovVPu23Zlv/0ygig/pf0RBt+MOQAYmg6aKBBVdr1K1627z7LPE4 tqb6thdjKOBeXyNfB7syJVSRyiHwoPCTLDgoK+gP4tp0D8w3NaFVAcmANMAPuO3OSzXV IT9UTBQdZmE0ova/Hyo7/3IW3keNUJHFEbx9MLU85ksYEh2yZ4jeCqWLedIGyhSGPrWo 0kDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=TQ8k71mrIU9mKXcdDpwRUTbKmYqn8QvFqjk7KvY4NFk=; fh=1Tzk/LQUEw7StwnEdh+C/ScmopJ2K/a+t70PO6UefdM=; b=oYz72xyCj1I+YKIz5uAxRZjWdnukRHtWmAkKvRiwbPyZtZFfr8XWrKmgxrSGhCo4K9 05dpwlPcH3wkXLCfgs2+bvhEJ8Nk5+nKR9LrgQKo+n3FPXQMpYU2Ebjd5LJe2NEJXk1V s1DgXv4EbIlF237QkD1l94nE3yMi1UDkD78bblbFBIQGCF+irG8T9ig2h3CIxunGs34P l3UCN2Ej2LEXDhQweuYh8W9G+A4K9VDmNNs6BJhixWvkTUkF8YvehBR3vP31otTurUVb Q7ph40UtnoKvdXo2uKORT1lW0hwOfyVvG/eXGaoBmRRuEqHTstqnCn3GFb5rBkkRMJdn B+pQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HkzA0QKa; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62773-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVUTm0HhVfw3tvtQyNdTYMkQgr1wUCew1zbpEYl02LNh8AdymdvZJvaEEW2Htu5AnyxwdDAkWSfMgZSi5wsx/D/iCMtQD+XDBFO5+ZK+Q== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cw8-20020a056402228800b0055f85eb4c15si3136193edb.337.2024.02.12.17.17.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 17:17:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HkzA0QKa; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62773-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62773-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2C1861F24A0C for ; Tue, 13 Feb 2024 01:17:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5873F1CD00; Tue, 13 Feb 2024 00:50:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HkzA0QKa" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 823131AAD0; Tue, 13 Feb 2024 00:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707785426; cv=none; b=Qy2nuu1xd/4O3TomoJvYi3eSYTGOGwRTMmbsNBz7Ka6p5tqNEYOfHNdUVcyY77mQNru89hQVzneYWV1wj77zqn7sd2Cjrlu0yzNr1FD57whr0EjqHRrdVxNdgwRObVgg3TDNe+gbRfNkRrufadHeMs0XSCenufRy1Ef170n1PAY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707785426; c=relaxed/simple; bh=K/bAxyR0fYoT2pJ02PB4C42YcI+MyTEOXFP3goPA3ek=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LdCleCLSFEL9KVzPATBzxngbxsZ6u/0gQBVH9CPcUYLTi/Xc9/KbEIfH8q6YgrHuW9aKSzAcysVk0/58JkaLtZyssTLjr2p8teJnXwydAy3cCqKsqUqimGQutDOh0R6izrUgkgITcHper1WWmEDlH6Ka2ZyxzUYFYAYBFmSfOt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HkzA0QKa; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90370C433F1; Tue, 13 Feb 2024 00:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707785426; bh=K/bAxyR0fYoT2pJ02PB4C42YcI+MyTEOXFP3goPA3ek=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HkzA0QKaeZ+EdYpb3HzsPRpu5qFBSHjUvz84lNmSLDFA9CwD3px0efE75i3Si2thD OkjbFTN6af8Yr274yssMIw5zcNBH4P7w2qIWJazxvEi2QlZCqtCPF1sAou+LM5wYpm erxDEJtQVQB0/rT3VGnPhE5FNdsQrbeTIOzT+tRdFeuCERe7PKvPGcd8q/EI5C1bEN TrOFuS+BJkiqFog6aq1XdAFxXo9mlzpsntJD7/AjQ7C5iR3H/lMRvsiMFk0VZ0pI4e Qvx6ZD7yfk94HdNiYBjlW5VG+ywBb9nCVqMt/pTocEmobzI9/j7V0gPctD7I/SdhNo mHw7skiVCDnJw== Date: Mon, 12 Feb 2024 16:50:24 -0800 From: Jakub Kicinski To: Daniil Dulov Cc: Woojung Huh , , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Alexandre Belloni , Helmut Grohne , , , Subject: Re: [PATCH 18/18] net: dsa: microchip: Check return value of of_get_phy_mode() Message-ID: <20240212165024.664ac4fe@kernel.org> In-Reply-To: <20240211150804.3893-1-d.dulov@aladdin.ru> References: <20240211150804.3893-1-d.dulov@aladdin.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 11 Feb 2024 07:08:04 -0800 Daniil Dulov wrote: > + ret = of_get_phy_mode(port, > &dev->ports[port_num].interface); 1) run checkpatch please. 2) we only got patch 18 on netdev, and we don't process partial series. -- pw-bot: cr