Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2784068rdb; Mon, 12 Feb 2024 17:20:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWFnyVHTGQNELgvsiMjx61sf9l8uB1E8sSbqqBjbY7u2VrJeqeRoU8QYj0snP6kmKMQElkLT/XcBkhkQ8F9tEiuMSPY68s/7uwFUUMQew== X-Google-Smtp-Source: AGHT+IGf1Hvild11+3YqQhmzScelP6W+KHWkRl7l3fV9IhPidMDHFE96oc5QrX7UMA3O8kccWapu X-Received: by 2002:a05:6a20:e68f:b0:19e:4a98:ba84 with SMTP id mz15-20020a056a20e68f00b0019e4a98ba84mr12278122pzb.22.1707787202581; Mon, 12 Feb 2024 17:20:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707787202; cv=pass; d=google.com; s=arc-20160816; b=ct8ubkcI0lCMql7Uua4auaUVpRGUtzwx2kom146SyDO6EN6B7SvzTcb9wgPFuOuPi3 KBTEysZ6nEGNJkokZXcBewBvEMnN2KS43aGFakcRvN1EDT/4M6PBCCXjfQZt8mbrQu7+ o3vSF+zME4WeNkP2JcBN6zUbyp5GaUqC95lWNQL+x775nyCqBwmXb/WyI0/1lD9QwV0i kK+9qfYZMhzQWWLWHIYp/ehuCj8L/ZcH7QH5goaop9CPAdgYEazpOf04Hs5mrE9r5JqQ 7u9HKyIsemBd9WbDGnyUh833w+L2TGYdpEqZ86xT3RL7JtsrsGKWj8gbxsIg/2yYeQYC v/IA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=flZnqd6/OOEmgqviJI0+73E/bOCz1vKp47Qn2/+ubUU=; fh=4oi/QocATTn1AgGOxF7YqJgNPa2YPVA5pUXPRPHYSWY=; b=Lzc9Iy9Es9zysIfG1sLQN/r4yNPBj+Njbjv5XqMibDY3/CLIF930OdDsniFRi5CKS5 MEfiBmWWWwTESI2obsPUkiAfWhTDCjqOqO45jUzfKTHzlAA6dOkp+bU1NR92PPa+3J7+ WI7tmVI7pNQIcfi+c2+XvxzouydvXgvPFr7NutxuioxzWoyFdHzDbrdtvM+qeb5aFh4V yGWjvqjXaRlGSvC1jf5b10ZJnyw3Euocef/rQ+LZr+Y3578ew0+sf2POCKFRzNyee0Tp gSzKzf4g2RdTiVbThdn+Tv1jSld0SduUCYUe/Rd/Mm95Xpthlkdn19IkCDyINXzxYZvz cing==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IjXhgRtM; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-62763-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=2; AJvYcCX8ZznysQSm3BJG3Tx1t2aF8hnAOMzWyEaNcHjgji7WtK6aKwrgR7RVco0OgFgJYTZ+7S7A7LC3DVHhmEye8dZncVZTMH7JpN0C0qV8iw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 5-20020a170902c10500b001d9c37d7173si1033022pli.249.2024.02.12.17.20.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 17:20:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62763-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IjXhgRtM; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-62763-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 99D3E28850D for ; Tue, 13 Feb 2024 01:14:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D3DB510A26; Tue, 13 Feb 2024 00:31:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IjXhgRtM" Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E7D79EF for ; Tue, 13 Feb 2024 00:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707784279; cv=none; b=GsfR44rHc7LUE6dlv/i02Ecg55PJaJ+YSiPqLd6ixG8CUIaTsUTk3EDmrhEKno/1WMNGQ/f/y2pk2AWgfi5dI03pXj59nIAMFyG7sN4XzODMnU7B68kuXZYw0JS3JabEF6NNVxEE3xg6hK/MzH/NR/yWEaGKbzBoacdeWSmrncE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707784279; c=relaxed/simple; bh=mNvkRhiyjJq1dsRwNB7SCDE/0DcmbqdFX7FIWlgw6qo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rQxXIWscj5W2Hg7uKUNb/zA63OoGgyRZpn5H2ISyKXfpw8aELrj3vScKgubB4wvmdwoZWPPsiQd/7VrkPzNO8w0Zpx7rzJkFwNSzu4bUjC7PnvMJdcfwB3WdI7nCY4q9GnUAvYqsF49xiVIZC6qjF0zoJTbUFMOhjLORhABMvrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=IjXhgRtM; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6e06d2180b0so3089399b3a.0 for ; Mon, 12 Feb 2024 16:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707784275; x=1708389075; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=flZnqd6/OOEmgqviJI0+73E/bOCz1vKp47Qn2/+ubUU=; b=IjXhgRtMIyUa1NFnp+Vp8P0i7g6V44gTGf6f9691xvdCR0dPBM2YGTq0ybNhVsEzpc vhBDTK8bjhYwZmff/R8zsp7hVx5Wv02lzlOT0WauPFcM6UBzr/m3F5uE4uZbQdFHmG6c BjMhYLlBgaqfSGw9AqTYS4SU1KGIDXVz4HARc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707784275; x=1708389075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=flZnqd6/OOEmgqviJI0+73E/bOCz1vKp47Qn2/+ubUU=; b=EGZ5USCwPFw//ni32WLHNP5J8con5s7OXODvlZ0+/WFtXHWE3lN+WtNwiXmJSmULC5 3/5wdpaGEhyaEK4oeIlkY76ByyMiaG6H50ZJefBGcmIR9KF0tZBrD8rzMpTbf1lblXTf xoUJp5QLKAcnHbihABVahnyX6tWsd+To80FQ37A8O2WmhysT/QS9/5UmSAdIHF+4qYx8 fFSAX9dNBN1SuRONYShZDJ4cmIgUUhMIFnBZJQnXHXOd3tQXMBNaS+JY9Tqo28rSjuEs SOXbBMi6Nf7/Y4JNRhQhBdWdjntPuO86zFAgY3JwQrfMIkZmJDkOK103FglntDZUZQiX DB1g== X-Forwarded-Encrypted: i=1; AJvYcCXWoPig0X8maTsCl4yHChcKHH/5x5S4Cthuw8ZlMmuoddk0R/2hlcr2cYA6/lwA1hiw9jT/ka31BQo/KNf6Qpyq4E02hQkWyFPPehlT X-Gm-Message-State: AOJu0Yy04QlSurt7xSipcEgXkx0Jp84qn10DOl+LYz91b+CSw4NGzM0E bHW/nNsWPDtsQn23cYvVf9ZP/UqurSt/f4KrON+JCobittqyH9AtsQ+q+gdJ7w== X-Received: by 2002:aa7:82cf:0:b0:6e0:532a:d5f4 with SMTP id f15-20020aa782cf000000b006e0532ad5f4mr8655990pfn.27.1707784275520; Mon, 12 Feb 2024 16:31:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVin3ur0Lo35hIyXtrtSV/cxI4vE5dmFtYD7ma+HtymCNeVZ2kkanG/e5r7jRI36pyWBjot8aUQYx6+p6LxLQnTNSm6weM6lZK91Z+2GZNgFWSN1ZeGPUdII18cHDDsVeHwP11mF9V5Cx7kzsoj1L4MeBLF1x4j/5G3iuwVW/cTP1lf4+jBzT6BusTtY+yb9OGjtgQsofJ3OkNeTsayYI6YnYoZKrbYP+SHJhtSllHfModJO/AP/ecndTCmiLycnsruuY+Z40gfK+ULp/KuzCJadwMupixtnYmRy1qpaieFOXGBmUxKVebYBQ0gaBO4gCxV5LZFueIZuKXFN1hKsPJNUcqwQAcizpIU/tBevp8sdiOcfLOYzHw+qiVJ5y0NJXKlMkVOcYTz8gNCo2Trtk3ICusgR7eUFM9ClFTEXbX5b6LW+RJ/ig/7J0FeSsOgfn3w7cYxkYi1mdkcSJqxdN9sljTmLw1cIEQpfmCmqGt7ZJwcUfz23XgPMMkH71ZPnZetjfaB08ugB7risf0yWGIFil3W8xnDYSDsWINLekmP/5pikpXr/SqTlI/kZtFx+R/Y7TJBg8XH8Khjudt2EkinnfvJOM9iaWgaRsupKFap50ol2vCniI0xkB+mMpzAvI1TnOxHZV03YgDwM1rGiJW/RCt7Rwyl0PU01O+eYaViHIiyZq9bR2CK5gDad7BWj2SfRdv7IqqyEtq4V00x9ZYyIPD3WstNoZqvyyTnQ8AXIH01cMXd3g== Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id r16-20020aa78b90000000b006e0dd50b0d0sm2678139pfd.8.2024.02.12.16.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 16:31:15 -0800 (PST) Date: Mon, 12 Feb 2024 16:31:14 -0800 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline Message-ID: <202402121631.5954CFB@keescook> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-24-surenb@google.com> On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote: > From: Kent Overstreet > > It seems we need to be more forceful with the compiler on this one. Sure, but why? > > Signed-off-by: Kent Overstreet Reviewed-by: Kees Cook -- Kees Cook