Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2788873rdb; Mon, 12 Feb 2024 17:34:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUSMiWOp9995CrJ5WLe2okMTOuH46mN3KB+cP6B44bqSLPVCHztMQ7eDGg+e8IxI+Kkv9dvMxUlN7vz3SWzb+fusNsUMzFeECqdZsbzWQ== X-Google-Smtp-Source: AGHT+IGKDT3pm2goTJildo3FRoVnUdKCE9TJnd8KYltfQFASr+HKh4K6pUGaROTWc5rscMKKgTp6 X-Received: by 2002:a05:6870:b251:b0:21a:3256:f630 with SMTP id b17-20020a056870b25100b0021a3256f630mr7279767oam.13.1707788074842; Mon, 12 Feb 2024 17:34:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707788074; cv=pass; d=google.com; s=arc-20160816; b=D+NCBsA2f8s8uLz1keGh/rWTEwBlKd1b7u4dzcjdHA6RA99lhezb1s4bd6BdAfCqox jrSggTKb+H75DFF4WgpzwuB2x8FwjcA0r4/8NgfO2iyGpzhbSqdbhLStl8rHrxc7e3r3 fcP4AhwIZUwXwq/e1HXyUAcRBiER1PKXf/uia9tofyKOk9w3wz6qzruDLLFueXDA39fG 1V42G74zNTlh9gZoF+1b0i8dxztIuoqjm0EXx6R5IGIbOSboF0ph4Z1V7qzkvOZET0r4 5nGlGvnNO1k4g0ewmdPegpHIEMUCandP2STFsmWNQH/Iidw+5zrcy01BLYlNu1o3UJnD y3Bg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=UHD/3jMRU1ccG3YkQIqWf6JR5thVdXFBz5XlT+Q0DtQ=; fh=m5DFyYjJ1PhJEcIwD6dCjuNTvuwhbXh3+6N0+24aW/Q=; b=qRxo5i0zhwaCBUPC9B67onOCISQrs1lSsukyUenofFnPr+8KwN+T9SDwseQTFLQ7Oh Kh4tCGpzjHvx/hKWBYgg8mbtKIAmbxTlSO9uGnoAI3NsgKb6Aw6p6G+q88QLJAqhpk75 tDX3/bL6dVm0ZZ545bttC4ijhkwpQu1Kdae4Fy94hqiwIkrW1eyASn1Qnu/xWzRfCmGV mW2vt4BdA7ITUcf1IaC47GSYokCHGl7KrcdDn1uabhHkaDeA4q79VGo+akGGoW4NLh4Q g8wD+HGMCqqpYBtBI5ZfYsuH3MdoKkvMJ2aWpXPbUrXiqeR98BijS78Fw8gTT/umA/Fy DIbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="ms1aUX/u"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-62766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62766-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com X-Forwarded-Encrypted: i=2; AJvYcCXKTt0W6jEZvuEIt8cYaqIR/1tS4FvLrUguDOX3lgIgMHYBgsXaIjgoqJEWIsMpOMS4w8w3IRiqGbIF8F8Dm9onRjx00qMrJLY2WsJNzg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j62-20020a638b41000000b005d8ad5a4d2csi1049754pge.677.2024.02.12.17.34.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 17:34:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="ms1aUX/u"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-62766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62766-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7AB1C2891D4 for ; Tue, 13 Feb 2024 01:15:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E7D41755B; Tue, 13 Feb 2024 00:35:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ms1aUX/u" Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB73EAD5C for ; Tue, 13 Feb 2024 00:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707784499; cv=none; b=q4cBbqelARShjXYW+N7tbisR5uEz2PiY71e7X7OinvvUVOxMe2739MRvWAUpAd51IGt+XZ5QB1Y6zC1UeTAmFLYoNn9RBfThYz+T9nTQgHfc6L1qkfHrGsLm5l+nj2xfKcA0RiFZJG/gPLU2yoiOFmHOPvhg0bWWytJtpzqPQDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707784499; c=relaxed/simple; bh=UHD/3jMRU1ccG3YkQIqWf6JR5thVdXFBz5XlT+Q0DtQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=VRyU5OfegVYEnw9ZOr2wyMKZLsz0q6+9dzSc13DfqAOKoLoCWeQ27iPS8rL3fp1aUUBuIARllk/TUcVj1SY0vqW71NcXebR6V0mZzqoekpnQUiAP2oGkw/XVL2k8Nl8Aqlx26Cfg5uuZg34/T2vQime0uMDATPt3rwTAiyHL+jU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ms1aUX/u; arc=none smtp.client-ip=209.85.219.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-dcc5aa17c34so266482276.2 for ; Mon, 12 Feb 2024 16:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707784495; x=1708389295; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UHD/3jMRU1ccG3YkQIqWf6JR5thVdXFBz5XlT+Q0DtQ=; b=ms1aUX/uHe/bOSB9ADzyvPOqoUS4sMi2M2opxDzAExtTMUaUMBsxUXU/+IDeAq8TOQ Zt+d4vX/Dy5rWvlo0PlLR++slAyxGVX/rNBlzI3cZWAvKs+Lp5gpnQg+8aPril7OL4JV +NzvDsLHi18Cxttijh6lIjaaebgaVxApRPWlvQPYHSCySBsKr8vuZbu6a8SnOLouxLU1 YpaTl5yaxwwZK3KJuNQ1b7tjQK2g6a/dFcginWYe2p2O9hnQegD50C3rQiFSINKGGQpJ +NubCjjAZ/d6/gCzMTdoEvG0hATxHtssDQIlpCEoqa++J5nowadTkZGotpE6uokNO1q9 zRSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707784495; x=1708389295; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UHD/3jMRU1ccG3YkQIqWf6JR5thVdXFBz5XlT+Q0DtQ=; b=X+qBKzU+F5p/vAAACx0aswWWpAVhAIiYvagP8MLMGYios3V9jHzrQLerysywcW64Py q7sCXMRvHRsP6IKqmRnsVkbnC+C48rucH93O1N6AMVnZuDkIlKbSxI6/b79RcYS+H+TY 1bZSI3FptFeTPpw5dYtIYmcYhzkcMFlxnBfqxDZt9fe/FHY4HOW9Jq0biSpThcLV5ObP IYgB0HCw8Y1rWef3kgyNmBf1zC/dQL0TjjWopI7KZ1H9yNmMgixRAxRkvDYADlP7RlsK u4fE/sKId/JgjTJGqsH8KR0hnI7PLTwxfNokmyoYu0rMM48qSzggyjligC9ZUNgNpp+6 HTQA== X-Forwarded-Encrypted: i=1; AJvYcCXVFUz4+YNNcr4iV0n/KVb9YPWxIfM+P46jIgiIDo+spqQLxyH5RXKbw/4qchD749A9QObeAvOHkQV40jkDLC1U+lJWJibsGyGERyMp X-Gm-Message-State: AOJu0YzK822FIz8iMCrutHDraNlZ1+YLzhjyiMsX4RgQNAdzJIqwHrDR 58TaLMAPFoJbacrO3NonQLhoNLM4hF1Opj2UcPChYnnsQnxkSp4m+sbuDkJrzyS1xgTvDtp3+6q 6m/znLmyuqQsRLJLpH+UvicMNkCJHMr2kbmOg X-Received: by 2002:a25:b389:0:b0:dcb:ca7e:7e6f with SMTP id m9-20020a25b389000000b00dcbca7e7e6fmr1832315ybj.55.1707784495521; Mon, 12 Feb 2024 16:34:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> <202402121631.5954CFB@keescook> In-Reply-To: <202402121631.5954CFB@keescook> From: Suren Baghdasaryan Date: Mon, 12 Feb 2024 16:34:44 -0800 Message-ID: Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Kees Cook Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 12, 2024 at 4:31=E2=80=AFPM Kees Cook w= rote: > > On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > It seems we need to be more forceful with the compiler on this one. > > Sure, but why? IIRC Kent saw a case when it was not inlined for some reason... Kent, do you recall this? > > > > > Signed-off-by: Kent Overstreet > > Reviewed-by: Kees Cook > > -- > Kees Cook