Received-SPF: pass (google.com: domain of linux-kernel+bounces-62861-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 12 Feb 2024 17:27:47 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Kees Cook <keescook@chromium.org>, "Matthieu Baerts (NGI0)"
 <matttbe@kernel.org>, linux-kernel@vger.kernel.org, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Qian Cai <quic_qiancai@quicinc.com>,
 mptcp@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [PATCH] configs/debug: add NET debug config
Message-Id: <20240212172747.53b4c744759073a32db8be70@linux-foundation.org>
In-Reply-To: <20240212170253.77a7be7c@kernel.org>
References: <20240212-kconfig-debug-enable-net-v1-1-fb026de8174c@kernel.org>
	<202402121039.E14DF37@keescook>
	<20240212170253.77a7be7c@kernel.org>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 12 Feb 2024 17:02:53 -0800 Jakub Kicinski <kuba@kernel.org> wrote:

> On Mon, 12 Feb 2024 10:39:55 -0800 Kees Cook wrote:
> > > Notes:
> > >   - It looks like this debug.config doesn't have a specific maintainer.
> > >     If this patch is not rejected, I don't know if this modification can
> > >     go through the net tree, or if it should be handled by Andrew.
> > >     Probably the latter? I didn't add [net-next] in the subject for this
> > >     reason.  
> > 
> > Adding these seem reasonable. I touched debug.config last, so I can take
> > it via the kernel hardening tree if netdev doesn't want to take it.
> 
> I'd prefer to have it in net-next sooner rather than later, because
> when our CI hits an issue we can tell people:
> 
> 	make defconfig debug.config
> 	make
> 
> otherwise I have to explain what options to twiddle with. And the
> refcount options do catch bugs, I had to do this exact the explaining
> last Friday :(
> 
> So I'd offer these three options:
>  - we put it on a shared branch and both pull in
>  - you send to Linus within a week and we'll get it soon that way
>  - we take it to net-next directly
> 
> What's your preference?

It's a net patch.  Put it in the net tree.