Received-SPF: pass (google.com: domain of linux-kernel+bounces-62872-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 12 Feb 2024 17:52:28 -0800
From: Kees Cook <kees@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>, Kees Cook <keescook@chromium.org>
CC: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>, linux-kernel@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Paolo Abeni <pabeni@redhat.com>, Qian Cai <quic_qiancai@quicinc.com>,
 mptcp@lists.linux.dev, netdev@vger.kernel.org,
 Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] configs/debug: add NET debug config
User-Agent: K-9 Mail for Android
In-Reply-To: <20240212170253.77a7be7c@kernel.org>
References: <20240212-kconfig-debug-enable-net-v1-1-fb026de8174c@kernel.org> <202402121039.E14DF37@keescook> <20240212170253.77a7be7c@kernel.org>
Message-ID: <952DDEA7-E788-4705-B85F-6B28AD6A707A@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable


On February 12, 2024 5:02:53 PM PST, Jakub Kicinski <kuba@kernel=2Eorg> wr=
ote:
>On Mon, 12 Feb 2024 10:39:55 -0800 Kees Cook wrote:
>> > Notes:
>> >   - It looks like this debug=2Econfig doesn't have a specific maintai=
ner=2E
>> >     If this patch is not rejected, I don't know if this modification =
can
>> >     go through the net tree, or if it should be handled by Andrew=2E
>> >     Probably the latter? I didn't add [net-next] in the subject for t=
his
>> >     reason=2E =20
>>=20
>> Adding these seem reasonable=2E I touched debug=2Econfig last, so I can=
 take
>> it via the kernel hardening tree if netdev doesn't want to take it=2E
>
>I'd prefer to have it in net-next sooner rather than later, because
>when our CI hits an issue we can tell people:
>
>	make defconfig debug=2Econfig
>	make
>
>otherwise I have to explain what options to twiddle with=2E And the
>refcount options do catch bugs, I had to do this exact the explaining
>last Friday :(
>
>So I'd offer these three options:
> - we put it on a shared branch and both pull in
> - you send to Linus within a week and we'll get it soon that way
> - we take it to net-next directly
>
>What's your preference?

Totally fine in net-next! Go for it=2E :)

-Kees


--=20
Kees Cook