Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2798980rdb; Mon, 12 Feb 2024 18:06:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW9F7m+IO4UJJRdPAwUtQJ2YYOIvZRrOvnhvLFkOUtEHMxlE+E+dp1ELvDabTiPnR2qlx4zljQkkVplHNKy033cWFQ6YIPdTDit5GYhFA== X-Google-Smtp-Source: AGHT+IGmB4Oi8y1nlM9iL7u+erElv/eV6sfJwAmhra4TcL9Z4gMQpLkp/k62HI5co8bG+vHg5z7o X-Received: by 2002:a05:651c:1545:b0:2d0:e35a:3ba6 with SMTP id y5-20020a05651c154500b002d0e35a3ba6mr6684691ljp.7.1707789994366; Mon, 12 Feb 2024 18:06:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707789994; cv=pass; d=google.com; s=arc-20160816; b=0rzejjJf/VE4bUB+JZJatHekffkoWw0ZukYGdlfmA92xNjk8xejvipch6xgr7xdNcX OnIXj61sphlm06UNVwA56WC8geL2AtAUqoHLITX1MUrVM3/QyPrR6BHgu3wf9koyOJrZ oNm0yzkh0zF3d3E5b/pkWA4Q5KPIkZd7MBfBcizXWhY/gNeQfenujRQhZiOuxwVz4ACw oPl3vRErnvTL/0VlDDbVXUPl2jPDjwkD/KZ682Y5Fc7PYrDLatqqAraQSWp0a8Y9eALz m1OGKCvgc6ISrkHa3ikaaIX5jMgWx9pfOj2lCs/mGiALmVXrNp276RzjWC6kMRDWwnDX UrvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Lh/hBdrarHRzchKDuPiZYbMlC0+vPxFkfo5CWMLulbo=; fh=JsEx1qvAHPFUTcDWiR1GDB7nRPJlrhoMDG/opXe9uiY=; b=qnEjUca21xbkV8Vtw4/ylPFDx5uaJ1Epllb7Nh2Zzc4qB1asWeREfpRsuljLeSfsya BTI2EAxgYmAREOTE0yCGfMlTQYkRg4GTHpDaFOImAsoxMjREDvNhnT1efbVZdJf/zrfa tGBk7KP96EBlaIY/OKMQq8lrGyYwQi31cwbRxeUWjT4wJk23jJ2ZP2OaQU86XHudUxrQ TnDxXKa4LcS5WJADXgd0ohjvqlq24yA88fBqB4nkneN6ge2UXFj8KT0FAOFY0rB5xnGx dEgzswqcLLqMFZdT1yj1CNxxyqcmdfCT3fswFww0H3tfvYEjGf9OAYH8SOoAyA/BjOuy MvcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=m9Fx9zwu; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-62875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com X-Forwarded-Encrypted: i=2; AJvYcCUGnxwaZi4/Xc28Mm3lKRi3A3tds+efPtd1PHddwyMzyNoZ7ti91WgwxaY11BXRAkCF5MWFr7EYGA07URlqg57MKVeffrLD8/QtTE4T8w== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id z17-20020a05640235d100b0055f49c246f1si3341956edc.624.2024.02.12.18.06.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 18:06:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=m9Fx9zwu; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-62875-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7817F1F261B9 for ; Tue, 13 Feb 2024 01:57:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6C794439; Tue, 13 Feb 2024 01:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="m9Fx9zwu" Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DF74138C; Tue, 13 Feb 2024 01:57:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707789448; cv=none; b=tRMmG9ixWZPL2/wH51iQwtjPILoCe4G+I+wn8FNRkP4yV4v7OcEirRgOcrmOZSZC2NtAED1Kd7Ihv2j0UZljIIQ4rL6CrFAHh3KMBnbNonbMZOndk0ysAPiA3FqYWkAe7pOivI0pfxhgtnT0ANcH2hrHEHaUBAQg9qpg/Ngds2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707789448; c=relaxed/simple; bh=xmj4o0CdVgE5lED5Le9y7LxCJNif/wR0CRonl+9y/yc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dpdPqXIS2zEX3Fg5SNa7Xjq7472X+UJcZ63u5daW44tiULbubH/TYtLtlv5456ldqbNFZoLcgCRZCeQ6YHX6IPYqfu+XnnEUUb1E6e49GFwW0C0MuBE+rlpMNATcV8oq46cb1qcD69eaTom6Kp1PgUzSr5byaSpeENQxbQ8MK1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=m9Fx9zwu; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41D1hm9F006438; Tue, 13 Feb 2024 01:57:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=Lh/hBdrarHRzchKDuPiZYbMlC0+vPxFkfo5CWMLulbo=; b=m9Fx9zwu7K1e0HDDtbJ1cyhdm8YRb1L1KHnaWyvbphj/JDcLmSBzrLBPDalqI76SgpXJ JxhbHap0eXFAS/QkPj4XWyxaOQ6uUjUD43PjHg718jeNFwW/uz+8UNdlyICI1p35Ehjo YkOIcHWazbk4aNIrpECNjHelWclpN3b8UHzaoAUGyGD3cwTqtQCp/vNnQTvSM+cGX8+c vzsPUr1rzN7pwBFRJHmAahrtH/hO4gOrrgIJpdi9epKxvIyOj9T/+wsZCQ4Pa9x6lNbF pHyxJku4zmvohHgH3/bWkmhd0kxA11DjPDtXsryxExPl0NfR4NawWG5TEF+MHbAVE0yW ow== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w7xt500wv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2024 01:57:20 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41D01ha4000873; Tue, 13 Feb 2024 01:57:20 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3w5yk6ms09-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2024 01:57:20 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41D1vJGC016701; Tue, 13 Feb 2024 01:57:19 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3w5yk6ms05-1; Tue, 13 Feb 2024 01:57:19 +0000 From: "Martin K. Petersen" To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Duncan Cc: "Martin K . Petersen" , Chengfeng Ye , hare@suse.de, Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , Lee Duncan Subject: Re: [PATCH v4 0/2] Ensure FCoE target interrupts work correctly Date: Mon, 12 Feb 2024 20:57:09 -0500 Message-ID: <170778915962.2192303.5279236168147495494.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-12_20,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=519 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402130011 X-Proofpoint-GUID: uRwiecKIAtwbp20g8xz2UBt5E5nowwiB X-Proofpoint-ORIG-GUID: uRwiecKIAtwbp20g8xz2UBt5E5nowwiB On Fri, 09 Feb 2024 10:07:33 -0800, Lee Duncan wrote: > Commit 1a1975551943 "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock" > changed locking for fnic/FCoE, but it did so by disabling interrupts > where they weren't disabled before, and this caused FCoE targets > to go offline. Reverting that patch fixed the issue. > > But to handle the problem originally addressed by the commit, > instead of modifying the locking, move the work to be done > into a work queue. > > [...] Applied to 6.8/scsi-fixes, thanks! [1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock" https://git.kernel.org/mkp/scsi/c/977fe773dcc7 [2/2] fnic: move fnic_fnic_flush_tx() to a work queue https://git.kernel.org/mkp/scsi/c/379a58caa199 -- Martin K. Petersen Oracle Linux Engineering