Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2799802rdb; Mon, 12 Feb 2024 18:09:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXO+wpXwJL3xgoJDwdxXZjwSOpcaS0XCZACcFbLx4XbTsnBO4qp6AW2uOav1ZoXqujLIZWshL25RWVU0H+KAzkzDyzq4gVweVWPgeW8xw== X-Google-Smtp-Source: AGHT+IFXHkxZ8L2cKLQ35/my8Z4rcbcB3QQ1s7AMX7D+w+isarSbPPv/X2Clgo7XlA7H2aNPhx7P X-Received: by 2002:a05:622a:180f:b0:42c:761b:38f7 with SMTP id t15-20020a05622a180f00b0042c761b38f7mr5709478qtc.5.1707790154218; Mon, 12 Feb 2024 18:09:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707790154; cv=pass; d=google.com; s=arc-20160816; b=x12gq/Zm6cHIf+BMfKzxlYsZP24Lhiobs9e9pDeaM50PtuJTUVRTIQDrLsrFyKH/Oh cad7zFdvrScHkQxnA1Y2zDRISICBnJ7LfFJAo4SFqCQ0uIRaDIzzWU/u2aOnkLB14oTI D3lxDw9EzSopmLKlw+K9yU9Pqb0M6s5p9N+n81SJvu49m16UujTfjS0TkPpVrCjGtIDh pNCMm0zO8H80Hfa935pfXN/d20WzS/BeW3NM9e7FLIL87/neEP/PuV2tVEszX5NJ2TrB Fp4oFeWLTaNdc1jVdBJmOGO1HfqCJ8iLwXqNvhflo1Uh8U49cT0rnORHaih9c2EWfH2h pnPQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=lKnD7PD7vHFoDrdYFBy0aSAjzzsTiox2zmAp9jUaeUo=; fh=ZMM2ifbdFbvvkZrsIpSU1fE8IhO1y9nTqf35i1W5yzc=; b=EYRZvKnPHnBPpqtVv9fpWLAYB7xH7AqhA1Mwgi8nFs4kfvl78CgenpzrmavG/RBCEJ mqneXgzSnzID7rsX1ISetdamBivM4g5+DzZH0o8ktKkVt5MAvJuqkKvaUCquaZMXHWzP HOlOIwSlrm3TfYiakx5ycTFjY24bIUH64nCOJVqzZYOQ7/3D6Ei86ejhGw5YYFm3jK44 GU4b9aF/KP904P/tHvv/VHQ8xTXOUE+CS64o8NK6+4SSNYNKbiIxv4tCVoqG9P/jkjwI HAUbJH2KZxrtnh7GpDMueQ99AkliPPxbb0jr3+lzPm6XWARuxfE0iRGd1Dd5fl/l/X7c Jb0Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=jB3cf+to; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-62881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev X-Forwarded-Encrypted: i=2; AJvYcCW7xHFIt+ABU+csC5v/OoRu+E6eRkhY/vXXaqJ3ulRsoCjfaormSNfPkaeZgYnUzzxqQgJ9jfCs/wB2WgNRQfuYUmIGKiYMJdnSqTHwLw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ay7-20020a05622a228700b0042c7c094b44si1998109qtb.655.2024.02.12.18.09.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 18:09:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=jB3cf+to; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-62881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62881-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F35F61C236EE for ; Tue, 13 Feb 2024 02:09:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20597522D; Tue, 13 Feb 2024 02:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jB3cf+to" Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D5B4430 for ; Tue, 13 Feb 2024 02:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707790142; cv=none; b=e+Wh6Fuz/h6EqxaUHhKuKNSM386ZBykGrn4YFweW4QNJn1oy8TxBIBa/PFurJKX4Wy5J67WsqN4d/xTgPa64yi02szUnIaQBTde6UJFonD8Str0RFxCMr/czFgVyObv19rEbSszzfTMea26t4vfCgU1L5WKyFNViot/sgRXdhiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707790142; c=relaxed/simple; bh=bSH6niJkb/nxz60hjIplohE5t2I54cG+Yi9YAJ0nIWs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fqla0cC2baOOIEDaNc9toMKF3yo04wHysPzLOCXsJiCrfGUbRtthAkxHfdm/eUjHk0P1lKzct3ydHMf5XLUtVt7r8Qt/QXsxIe/IDTfSeRsGei2Ih+AqXY7AW1d1iQeKP2A3f48BQamGoEqqeM1RGsFJcz3TPN4iUuF2fGy5X+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jB3cf+to; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Mon, 12 Feb 2024 21:08:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707790138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lKnD7PD7vHFoDrdYFBy0aSAjzzsTiox2zmAp9jUaeUo=; b=jB3cf+toUIgh4WRnofpxNLsUtSjV8FWhNPjGE3TxFN2aHuUKMaKW/k/FKCrg95huIAE8vg 1DptOGDgE4p5+0wKKAn7cUzEeup1I6Bd7OUmai5FE8zZTqtIOX58n58fV16NjN6wT+pgxg zhmNnkLjJoV7XN2H1w2Kx2/R/EABNYg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Kees Cook Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 23/35] mm/slub: Mark slab_free_freelist_hook() __always_inline Message-ID: <3xhfgmrlktq55aggiy2beupy6hby33voxl65hqqxz55tivdbbi@j66oaehpauhz> References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-24-surenb@google.com> <202402121631.5954CFB@keescook> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202402121631.5954CFB@keescook> X-Migadu-Flow: FLOW_OUT On Mon, Feb 12, 2024 at 04:31:14PM -0800, Kees Cook wrote: > On Mon, Feb 12, 2024 at 01:39:09PM -0800, Suren Baghdasaryan wrote: > > From: Kent Overstreet > > > > It seems we need to be more forceful with the compiler on this one. > > Sure, but why? Wasn't getting inlined without it, and that's one we do want inlined - it's only called in one place.