Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2801218rdb; Mon, 12 Feb 2024 18:13:47 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXWk3yWulA5YkM+9ye9BHNNVoXMFeZxdvOJBG9dzYOlK5TOT4sPeL91NYutZwQrrBuGLnLLYrwxqRx2Dtxb0WMO7CP1AUbfxNmPtgCxRw== X-Google-Smtp-Source: AGHT+IHVJlRXAF1abi3ZNIhjWdKPmcu/Q+hfOO4j0rL5sw0676jruaP3d2FZXKSbZEocV078Aixe X-Received: by 2002:a05:6a21:1798:b0:19e:a85d:166 with SMTP id nx24-20020a056a21179800b0019ea85d0166mr13430256pzb.9.1707790427448; Mon, 12 Feb 2024 18:13:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707790427; cv=pass; d=google.com; s=arc-20160816; b=PscD9CL+0WY/qJz9j7oxWiGKKceaMLPQTI+C21Q+SqeN/JSnTXe0aGBhJYWcL+4E7f 5hK8y4Y3T+o5qrZ8mnOGVaVlczrAknf32UV1IjqvZ3d29IbEeWC6qW2IyBUskh+I7F6T QbEAX+ovhjEAZ24hCIuKXbkySjjiY7c+FvyErnBtE4CmE7cOK4CtgpA/IiLe762R9s00 2kOQqmc+4tE4qNIrlGwrT6Fd8BqBuI9aUdOC+CLiFX0zp6KljFFgo41ImMudh1bDXOCY T5cqDZIA44rgGaHDG0GWLdiy+b+gN78/5Vsl0gNpBFFEucZXaPzA1m4QfWtwyttFGKAF DUJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=UCCMf+zrvG2LLglWpP6ld4HO/mIS3ZdslSWOKjii4mo=; fh=Iz5hG06qaGAkwBNmPmDK9DfhbsdlpRPQX5ebY4fzwFM=; b=GpI8KvsQxhUAsc6QUa+dia5kE+bt7+6+wEPutGCAf2F/dn/c4ZRq3JjrgTOiAi8zyw 2xLfs4nBsMRvf6Ro3t4NuCCe8FYCWMiiM8rp3HVi1Yxgcf6JqMgFl/U1MSO2kihugQqi Aeynfz0QbBI4ZMq+lMLipeO9sxbxvR7jlabJTt5+fCDE8b0ABK726u6MyQQNPLgbSmt3 m7iuETqR9NHzgAyH8kAm6IOpWZnVmemNvHi0C5ll+xB/94WFLaP0fVfoMO2QbghBDYVU J/bTtTwq4ZVo2GXz8HxcWbEy++AbBUo+LqA37Qt/25uDOvp9vHTNLvtclc/sEFQc9Chu hwuA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMdQrm3A; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62860-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62860-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUpY1c4Q9ZA/6WfAQWIptcqrgL/mSjV2KMhqqLjCDR8gEfKjwRzwIHCX0h+vq0ExBV0NgUWr9kCdbHuWITfuiWJshiHyV4B20PSJtBrrA== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id kb14-20020a17090ae7ce00b00296fa2e3b26si1228668pjb.3.2024.02.12.18.13.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 18:13:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62860-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMdQrm3A; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62860-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62860-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B49F2B2A2A9 for ; Tue, 13 Feb 2024 01:48:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 05A501119F; Tue, 13 Feb 2024 01:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IMdQrm3A" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F8A8BE3; Tue, 13 Feb 2024 01:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707787513; cv=none; b=H2ZiJuI/Fs7agSpRiUZYSEQOlW/BYyjZRTjLZKlqfs03xvspkprXTIuKnaRFdFlWBiu1XKCxehh0bdNMxRMdquTrx0z550MhBxOafxI4pwbHIFhNAQY4oy77AE8/+HJzU2B2/4zcE1PxCu5NaX18wJwIdYEUDj8RKI/UCwoX2Ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707787513; c=relaxed/simple; bh=5LKrz3nxxHWru0zmySaGtmxb2865EnGn98Cu4JRkuNQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WgE5DXRF30/341p5Dh3F5sSwmIP3NHuiCbWZCXE0EQDnOuJLJOYR2F5gTS1Gx/WiSKMcPdcF70z/eb1JXRSHYEmSG9SiwZw0UyvdMrDO5HjWxK7hUh7Vs0fwocAJzM2UFnGf46+ggj4sMz/Q8E866SrIN5uzX+rd68qMPyKbSAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IMdQrm3A; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A336C433C7; Tue, 13 Feb 2024 01:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707787512; bh=5LKrz3nxxHWru0zmySaGtmxb2865EnGn98Cu4JRkuNQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IMdQrm3AnEP8ovLWnZKyiNFZG8ubQmVRKAyZv/TrsOsHMj2cWM2kjbTtn24JtWoxx 7SspmNQH13CiRKj4Nnw+MdpVA6FOV/tgvjDvFKQ1uv2XS4sC5UrFeyoKDFdWjMpS/b e/SPQKytVhbwpD3K9JOaNyoC68KM6Boh5tzyzMjF5Ik9S0H7Fs7DdGhP7xnneYk4Co EDsTsYFGK9vpFBr3ZUkLSZiDKRQuqpLzt0x0I8c4bFPAxRgI47iRL+4HfoFmERPxbZ C5wGw7VuR/LiLZwfkQlYUPq/1AZ4YaYz0CRIEWHkGNH6RrAMz4IiRoFr1PgxTEtpiD MU9AXLsQP36/g== Date: Mon, 12 Feb 2024 17:25:11 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: Andrew Lunn , Heiner Kallweit , Russell King , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Jonathan Corbet , Horatiu Vultur , Richard Cochran , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, =?UTF-8?B?S8O2cnk=?= Maincent Subject: Re: [PATCH net-next 1/3] net: phy: Add support for inband extensions Message-ID: <20240212172511.42cd058d@kernel.org> In-Reply-To: <20240212173307.1124120-2-maxime.chevallier@bootlin.com> References: <20240212173307.1124120-1-maxime.chevallier@bootlin.com> <20240212173307.1124120-2-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 12 Feb 2024 18:33:04 +0100 Maxime Chevallier wrote: > +/** > + * PHY modes in the USXGMII family can have extensions, with data transmitted > + * in the frame preamble. > + * For now, only QUSGMII is supported, but other variants like USGMII and > + * OUSGMII can be added in the future. > + */ > +static inline bool phy_interface_has_inband_ext(phy_interface_t interface) Spurious use of /**, it seems. You either need to use full kdoc format, or the normal /* comment start. -- pw-bot: cr