Received-SPF: pass (google.com: domain of linux-kernel+bounces-62904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240208221802.131087-1-jmaxwell37@gmail.com> <135d4123-29f5-46dd-b06e-d5a66bd7f598@lunn.ch>
In-Reply-To: <135d4123-29f5-46dd-b06e-d5a66bd7f598@lunn.ch>
From: Jonathan Maxwell <jmaxwell37@gmail.com>
Date: Tue, 13 Feb 2024 14:17:31 +1100
Message-ID: <CAGHK07BT5z+iEGMG+vdBAi24B5UwE7nTh1ZfrbM5u092jEPAJg@mail.gmail.com>
Subject: Re: [net-next v2] intel: make module parameters readable in sys filesystem
To: Andrew Lunn <andrew@lunn.ch>
Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, 
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, 
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 10, 2024 at 4:19=E2=80=AFAM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Fri, Feb 09, 2024 at 09:18:02AM +1100, Jon Maxwell wrote:
> > v2: Remove the "debug" module parameter as per Andrew Lunns suggestion.
> >     It's not really needed as ethtool msglvl can control that.
>
> It is normal to places comments like the above under the ---. In its
> current place, it will be part of the commit message. Under the --- it
> gets dropped when the patch is applied.
>

Thanks Andrew I will resubmit tomorrow with that change.

>     Andrew
>
> ---
> pw-bot: cr