Received-SPF: pass (google.com: domain of linux-kernel+bounces-62966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Ankur Arora <ankur.a.arora@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org,
        paulmck@kernel.org, akpm@linux-foundation.org, luto@kernel.org,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org,
        willy@infradead.org, mgorman@suse.de, jpoimboe@kernel.org,
        mark.rutland@arm.com, jgross@suse.com, andrew.cooper3@citrix.com,
        bristot@kernel.org, mathieu.desnoyers@efficios.com,
        geert@linux-m68k.org, glaubitz@physik.fu-berlin.de,
        anton.ivanov@cambridgegreys.com, mattst88@gmail.com,
        krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Ankur Arora <ankur.a.arora@oracle.com>
Subject: [PATCH 08/30] entry: irqentry_exit only preempts for TIF_NEED_RESCHED
Date: Mon, 12 Feb 2024 21:55:32 -0800
Message-Id: <20240213055554.1802415-9-ankur.a.arora@oracle.com>
In-Reply-To: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?1T+Ntj9g8AxJA4LQcVE8f4qbCyp/cTgETX0tpaben0XtfqqCl4Cv2NA7K2PS?=
 =?us-ascii?Q?GYOTp5jYFVJnbCQVfBDO2c1FUYRV6Er9Ae9yF897h1rB/6X3hKLpORBlL/cc?=
 =?us-ascii?Q?ekd/C4K9jzGW9ByBaoi6Sx580VVKO0vNTE4Oe0TueM79ijv+WNZ5ir9l9MT8?=
 =?us-ascii?Q?/SBYjm07RwBbHQug6M78KY2xrwIiTTkI6w1vwDrVrKU1xylgScCCJqkiHaxf?=
 =?us-ascii?Q?Do1glACWus8Xcen0W93zMpehSK9XUAiAX2BgjyVUXf+GE9rgqErgabzNAh/l?=
 =?us-ascii?Q?Ap/raHUawe6VRQfbxmzL+KV+wVfuXTXK18s2L94ZWgP4aRhciHc8mENsFnv4?=
 =?us-ascii?Q?dOi4jHc2BRHDIKvHKB9NLcZK/KjM+kX94lohJEcFkVlmkk8lReoTl7fj6yCE?=
 =?us-ascii?Q?anY5DiAgCIzmsP36Y/25vOqjTG7zvrVLL3fb1aBv2eCRSUYFYJumzhWhFAIY?=
 =?us-ascii?Q?oic5An2wIWKJJRUZdOXM8KKJaVmtkz1VSFftCZ+hXFLP0lJJd0YNpj5BkJxZ?=
 =?us-ascii?Q?w2d4sLW3WnptsvML0iv7HfOuy8YlCjV8/kUe/oKv6WAroErJ9IftJlTYVt9Z?=
 =?us-ascii?Q?uYbRO6LmUIWK64vsf3Fr35vUabR1Bg/3i5UwR831pwr4J7/cDpDQvV6djH5a?=
 =?us-ascii?Q?xuOfIQE7pq+h41Rs+oVqx7XIqhMLJVi/4OBRIv1BiQCUECW1UnNrpjjZbASz?=
 =?us-ascii?Q?mmW407eqEnrMcIlJcVVmnkSijBneOOJJ6CSBdF74FMeGHXJ4qNhuzEiBY30l?=
 =?us-ascii?Q?bQ1aqPH5SS6R0qT4cjHUOoE95RDSRZee4l1FeoAa5BWH0p1ymrlf9btuVLsG?=
 =?us-ascii?Q?tsG0HiAZoMHUvc2jc9+9JYu7cQc2vNsSpyUjNYeAn7lDq4MgOre7eYUdcFdn?=
 =?us-ascii?Q?Nlro0dUw0mpmo0r2iikf2J8eskn3fBLO/Pud2xE8kmhcPYMzzIcJHv2tV7O2?=
 =?us-ascii?Q?unHozhZrHFwDgFnmbjjBDw3eKn0nQG4hL5GMUO4taumo0Bt8AHwl6vGJe+jY?=
 =?us-ascii?Q?Abg1FQl2OHrvMib/E0KWgBBL4jWodqlQn6F3ESyZik+QI1tDfX2FPvNTt1Nj?=
 =?us-ascii?Q?vCodyrnfAPr2K0mDPHInjBUKZJpA58tTervN2NjMYGa5pkMtdfsYEYIxQnfh?=
 =?us-ascii?Q?2GXbnee5OD4qYDmrLSyTCz1WHTa8iwfc8irJ7bj2taEX29S7DQ6dKM1w2Y/u?=
 =?us-ascii?Q?zT+5xU0plN2wltTVzOuuywY578rPL2lxhe6O8WbMvvjtwcixweyQRDNsS4u8?=
 =?us-ascii?Q?xoMCkaA0ze7IlhSMt5QdO+M2N3rs41xA/BUs8RRthCxFNgfIHi/Z1sNLytmb?=
 =?us-ascii?Q?vFog9RGexh7+IvFzdB8KjNeOuVnPeSsGvONOTSveS2mjyinbJzj5TIFy1Sfu?=
 =?us-ascii?Q?I0mW6D5gcxBaB7x2kVq7GHzNc9I/nQ0l+blzdXovztfZ9mfqCeR/z8MzplOO?=
 =?us-ascii?Q?eSeebDguBJmEsL4XLgtRddgiMbUm3Gc1OhHlBKc2JA7onj2xMRgLT0h6dAc1?=
 =?us-ascii?Q?yUvHA13dugup/b67w6gdgsiokn5/kau6HNCVzbrsIB/HOjVUBwMRMSmIPdYX?=
 =?us-ascii?Q?smjGsLbQHO3vGM4DVp4RQXz75uQo/2f6w4MlHlNNuW7oD63kMfYwxEXprWz8?=
 =?us-ascii?Q?YA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	NQ2xxY43zMYpT9zs8ZG+BEkrmvGuEkmPEvr0eKS53DdL7QkM/QF8VT1AeTOgMiicJTJHF0PIZrzfRYMuEBZDFAPp6xnEohBzA+cvW4XD63MdN+Tgoih5j5ZcAurNhYszWHjK7DgHHydpcm94LKSKjk5+0uF+ot38DfusY1JLN+bNWQYSeyElromFseiUcl/ghklquXhbuitDtI4rP3COJPMSYrhJVuWRX/FZV3GGzJyl/CwZy+r0KVNx8cg5vb2c6T2nvEEIl59a3rnoX5smdCRGgSYUGDL2d4kLK2KSURZ3TJ1/4xAzlkmM5kaqrzLJZOpSLI1MT2KufEoVqgLMmT8DHxq4OSd09Z3ZT+NK8NW4cFUMVegjUPl7DRGlxs0rW9eZHu5ioxu5o/FbX+SL3MM/7Sd9Cd/3KevZ5Sboa/VQH6/srirDllVU+xzQm6dksKsONWIHH0zsdGTVP0b6yT61m32LLcET+SoiqPZWaT2RUQh3ctbdXWp8jj2sKyvbvNnYpklhLEB+zLfY3kqucdgIS7bwyIgCwAMPgTaVpuloYeOsREfpbFpQNfvYPEIRluIlhE10W00EiQnut0kTO+lp1u+4Qze1+RGJGuxdlcU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05749a48-769a-4857-1aee-08dc2c5872b7
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 05:55:57.4443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oZ2n5w8iRshsoccNMHjPT6AyMKULH04074s2jCRd0ihFZk/9dB1dA7v+hUqHkeCau3jXVAGp7/6Is8PFswd4juIGYazsLJgQ+vQRVSVgtUM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4642
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_02,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402130043
X-Proofpoint-GUID: 4mymwDjJQ9DjY87fN3ZM0kNxtkQgaRBP
X-Proofpoint-ORIG-GUID: 4mymwDjJQ9DjY87fN3ZM0kNxtkQgaRBP

Use tif_need_resched(NR_now) instead of need_resched() to be explicit
that this path only reschedules if it is needed imminently.

Also, add a comment about why we need a need-resched check here at
all, given that the top level conditional already has checked the
preempt_count().

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>
Originally-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
---
 kernel/entry/common.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/kernel/entry/common.c b/kernel/entry/common.c
index 5c5befb05410..e1e6d7c92ca2 100644
--- a/kernel/entry/common.c
+++ b/kernel/entry/common.c
@@ -301,7 +301,15 @@ void raw_irqentry_exit_cond_resched(void)
 		rcu_irq_exit_check_preempt();
 		if (IS_ENABLED(CONFIG_DEBUG_ENTRY))
 			WARN_ON_ONCE(!on_thread_stack());
-		if (need_resched())
+
+		/*
+		 * Check if we need to preempt eagerly.
+		 *
+		 * Note we need an explicit check here because some archs don't
+		 * fold TIF_NEED_RESCHED in the preempt_count. For archs that
+		 * do, this is already covered in the conditinal above.
+		 */
+		if (tif_need_resched(NR_now))
 			preempt_schedule_irq();
 	}
 }
-- 
2.31.1