Received-SPF: pass (google.com: domain of linux-kernel+bounces-62985-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Ankur Arora <ankur.a.arora@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org,
        paulmck@kernel.org, akpm@linux-foundation.org, luto@kernel.org,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org,
        willy@infradead.org, mgorman@suse.de, jpoimboe@kernel.org,
        mark.rutland@arm.com, jgross@suse.com, andrew.cooper3@citrix.com,
        bristot@kernel.org, mathieu.desnoyers@efficios.com,
        geert@linux-m68k.org, glaubitz@physik.fu-berlin.de,
        anton.ivanov@cambridgegreys.com, mattst88@gmail.com,
        krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Ankur Arora <ankur.a.arora@oracle.com>
Subject: [PATCH 27/30] sched: latency warn for TIF_NEED_RESCHED_LAZY
Date: Mon, 12 Feb 2024 21:55:51 -0800
Message-Id: <20240213055554.1802415-28-ankur.a.arora@oracle.com>
In-Reply-To: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?bPyW1ev6xKZmLdJ3AzbSmFKjh+/Rv4P1ED6E0oRPh56fREIa0uu+9tZ1Hms2?=
 =?us-ascii?Q?2d5zodxgI0WydA6sTBVDHEl3FljVVSIE2VMrfoJHAmFHSPMHD5zKP0yj9HTs?=
 =?us-ascii?Q?1A5lpLi+iJotSxwkSQNhNYA+wG6/tRw1LSrKhap3ZhUKEZ9i+RqOWXiOKRiB?=
 =?us-ascii?Q?Z73MRoBjobP7WYNKW7IfZIRodhtkz1Pe4a5zVR4fELWWxoQQOrsR90aNn3km?=
 =?us-ascii?Q?rjZ5bA9memuxrk9FbH1Cbd/xjj55PZgmXWVOrl5uOSK07tHyEZrW+zk6Gus6?=
 =?us-ascii?Q?IhBEJosOJ0doDhTawqNbQA1NmRHOcS2WkBif/vwJo/6Yu+ExBk5T0Zh7SC3A?=
 =?us-ascii?Q?mycGlkdCSuJIvXjh/fcI6NMfk+3we1qCPGOvM153N0qBMuTm0RSz9ozgBU14?=
 =?us-ascii?Q?lpE8TTK5c/7hXjO/UUdQhmEQOulOLuORShMxcA3vKgAgXx1wkHtQ2j906K8c?=
 =?us-ascii?Q?ojliSixthc4qOJmIw5CKG8joNWfBd4j8kh7E9PrIO8dkxxTbv47XNafVy6YV?=
 =?us-ascii?Q?eGBzcNQVuNOEzDWy8KEQ3ktLaNAAD8Cue5EL0RMm7nk3+13xqVXi0bctE7v6?=
 =?us-ascii?Q?AEzy428X28DY71LpkE5LGxlLcXNZ5UlHzO/KL6SGIWjkJ402C7D/STuWVaeJ?=
 =?us-ascii?Q?XhNwL0x5dW8Ej5aXHsbeTjEguAbhfzYCBMRaeKAXwJpmMLaNjQtYBG3Bje+Z?=
 =?us-ascii?Q?ggAMtV8pokhe4niRQ3zmN2N3tq/Yw0y/j+d6tm3kIS0Dp8GF2CxH7Yk+ZTJt?=
 =?us-ascii?Q?012dWyVkA6OnnxzS2fnXyINijTWRD9UVJ95GAP3RmAVIwE+piQRZ4LQZ9YFV?=
 =?us-ascii?Q?KbfYakrqcR7xuhk1AOv0g2nEJGTaRhVoBGwLVCJd/xSCGUirepliq6nx2K/8?=
 =?us-ascii?Q?J2rqp51UgIJ/AzlrrLrrrAGOT80o9OkG3EFljpLDlfsc6bIdBE3e1QSunMdN?=
 =?us-ascii?Q?/1gVmg3nO+/27AdmgWqOOL+nexJ2c0DY8VhB50Ab/RAb15mFeF0ldFsMoMaU?=
 =?us-ascii?Q?MQ6SYHe0q8es/tD2YQO5WiO0lMdNpOWpHPsU1MuVnX9L4wFuiqMF4uBSYxnc?=
 =?us-ascii?Q?H/udCCvn3fpFXtwDZ7xPc9p4g5lXishOBLFJBlRa4mH9/HpneXCFD9/doHo5?=
 =?us-ascii?Q?Hgti5ZtO+XQk7Lj02EdhovZreaB+vHgFraMcHii2ndmylQ1/+igc39Ts55Iz?=
 =?us-ascii?Q?DL7M8Xunoy+cUegCBtJjemyOix9cnTJ3kk5aH3NXaasgsg1Di4iLQ1oBwS6Z?=
 =?us-ascii?Q?DiwFRytrd1e/B9Dn+gUsduyJccPVbJFFKKX7ikDLp2c/E0O7f0cXT5WXXj39?=
 =?us-ascii?Q?d9rGY8AM4VelilyI50KT8v6pIV/suyCo8Rml17nO2M3JAjJnvSV+pmktp6VK?=
 =?us-ascii?Q?yNcvSbLROIiw+gq61XOLV6M7LRQwxj5EAFKku6satGKJe+Dlk2oolJtU5VcU?=
 =?us-ascii?Q?9Q7t51aoUy8g9VDW1NgHtZYLfdnAvu6TVgYQLfoCIvWzVEQj3cQMRkeeHnQR?=
 =?us-ascii?Q?8B+liRcsNc2GpR9UnASTdc/+s5MGDr+tHfB/JIbHJ/UbluGyoEtAKnawqJ9m?=
 =?us-ascii?Q?B167kpjFPccBx3SS7S2aEJUQfhyzklGuZscBh1cKNG4++yjX/cd+DCnyJKpv?=
 =?us-ascii?Q?nQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	CyAPiJElFVgU4zVTdiiOIxqzXvSHzsuVrYHFear/520Zjv3Lchx6bcrRBp5fody0hkqgfgw3sVCcP1g7F4aSv1SjIpVRu3jrn7FJsiu1oB7wrbi5RdrvVdYy7s6ab0QQfELMHtUfyEHtWfH0n1pk7b8gyPwTn2Zmk4BLjzDmikqHkW9baanfBkkrygpAO2WagRYxWIND1m9BkwHanYt5CSub1xdxVYpETZ8excNbqwM0HsKUZxsUkUryyXmamZMCKYTgy7+M4zW1iV/RnjkzYarv7nCU8CwQ4OqARSZQ/aSxIg6mfYXVEIYtl1/VmWG1cHJe+/f3JRitUtJsuQLA14fdt96CjtM1fSSfdGQJRIgw4Ayh6+ccNthN6x3Zq1tfWp7PaskB5dWySYdwxJ/QtJ2bJHfzGpZKmJc4smyxO8rXJDdq0aM98cEg9dk3Bc0OubhF3oy5m5lPE2bSy1XPegtSseI4WSxg3vMMCnKdhsLVwmIvpwFAjHgWv60e9Typ6vrlkOxQ+N1R876NP9Il6UOnBHiaW0vnHJUwqxVvpz1aATi4ZV4qp5TgX9PmvTaweM48cFKL6LHuFVsQSETsUrTKUpIr+Rx+Fb/q0FHAjOI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a6d2261-1dde-4e92-cee4-08dc2c5897d2
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 05:56:59.6990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ItYNgoKl+mfjsCVE796iDedzpAUTuTh7XvPpTZ0r3KmTEMKszNHOcxDTcrtX1dxuRIhLls+8uBeRyLvrJx+mtNBp2CTOV3xYr8u0/qDFPVI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6906
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_02,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 suspectscore=0 mlxscore=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402130043
X-Proofpoint-GUID: UB6fNBix8VZudmMcdR9WmDz0v3Tti47a
X-Proofpoint-ORIG-GUID: UB6fNBix8VZudmMcdR9WmDz0v3Tti47a

resched_latency_warn() now also warns if TIF_NEED_RESCHED_LAZY
is set without rescheduling for more than the latency_warn_ms period.

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Ziljstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
---
 kernel/sched/core.c  | 2 +-
 kernel/sched/debug.c | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index aa31f23f43f4..cce84ba0417f 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5670,7 +5670,7 @@ static u64 cpu_resched_latency(struct rq *rq)
 	if (sysctl_resched_latency_warn_once && warned_once)
 		return 0;
 
-	if (!need_resched() || !latency_warn_ms)
+	if ((!need_resched() && !need_resched_lazy()) || !latency_warn_ms)
 		return 0;
 
 	if (system_state == SYSTEM_BOOTING)
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index e53f1b73bf4a..869a09781f2e 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -1114,9 +1114,12 @@ void proc_sched_set_task(struct task_struct *p)
 void resched_latency_warn(int cpu, u64 latency)
 {
 	static DEFINE_RATELIMIT_STATE(latency_check_ratelimit, 60 * 60 * HZ, 1);
+	char *nr;
+
+	nr = tif_need_resched(NR_now) ? "need_resched" : "need_resched_lazy";
 
 	WARN(__ratelimit(&latency_check_ratelimit),
-	     "sched: CPU %d need_resched set for > %llu ns (%d ticks) "
+	     "sched: CPU %d %s set for > %llu ns (%d ticks) "
 	     "without schedule\n",
-	     cpu, latency, cpu_rq(cpu)->ticks_without_resched);
+	     cpu, nr, latency, cpu_rq(cpu)->ticks_without_resched);
 }
-- 
2.31.1