Received-SPF: pass (google.com: domain of linux-kernel+bounces-62978-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Ankur Arora <ankur.a.arora@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org,
        paulmck@kernel.org, akpm@linux-foundation.org, luto@kernel.org,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org,
        willy@infradead.org, mgorman@suse.de, jpoimboe@kernel.org,
        mark.rutland@arm.com, jgross@suse.com, andrew.cooper3@citrix.com,
        bristot@kernel.org, mathieu.desnoyers@efficios.com,
        geert@linux-m68k.org, glaubitz@physik.fu-berlin.de,
        anton.ivanov@cambridgegreys.com, mattst88@gmail.com,
        krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@ACULAB.COM, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        Ankur Arora <ankur.a.arora@oracle.com>
Subject: [PATCH 20/30] sched: handle idle preemption for PREEMPT_AUTO
Date: Mon, 12 Feb 2024 21:55:44 -0800
Message-Id: <20240213055554.1802415-21-ankur.a.arora@oracle.com>
In-Reply-To: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?T7Za8WfefmA+6MzSSIJAnhLsROl8Ikb+5lNNN05lNjo75gTZsgcFP4L4csbJ?=
 =?us-ascii?Q?40Gd6XzwApAU+O9IvUk48etYwRqLONSKaz9SIjPCVSOtPVnIqTZcR6b9FCKt?=
 =?us-ascii?Q?KI4ZMWruoYIrD8B5y9paIZajpDdZ9Em8N4+xNoAv/EbORa6+YvRCjNlXeAIP?=
 =?us-ascii?Q?pbDuMM5TqJCJZFGyelz6p4U7Yq2wLn8rn9L4qBer8x1Wv9TNbNPYhxl1EWVc?=
 =?us-ascii?Q?e7nIbqMF6lY9s4lK9XCpW5BEIn823BxGaKyDd4vbi3pgwP1kyDEjM8AG+NUE?=
 =?us-ascii?Q?iVYc6PD6JbLJ0Hz0KP8OiZhfwG85wWeMz8jMsXBiU3BhEYS4OfxT/mvFT6Fu?=
 =?us-ascii?Q?jMQEykOjy048DmvPlg79Ej8Q3okNbW6Ny0F77AvvGQdPh4OEh2JtlYEHUujo?=
 =?us-ascii?Q?JKS0H99TGo9sBewEqVruzXdHajxUlYG5rdOygC+VORyTvaZCaTFeohyVjvDd?=
 =?us-ascii?Q?p9Z85ES/X/WPDIxCuM0DnigsUDdJiM1FsxlFF4UNDdxryfFDCUQ7ifgPRE8X?=
 =?us-ascii?Q?gj9GN/twEoT0vq+vROpf9zRXq3OlzrNkeD93SufLDKJxggHkLNwhMR+Inuha?=
 =?us-ascii?Q?zivHV168tyDX0VHHB/yGMwd8zjtCl44hJ99kqd4xooyjH8Z2JnyRbfjnbRin?=
 =?us-ascii?Q?yLGPqax8AkN1cpwC5Bt3aLJIhJBRx50irbEG/IElUu34Z96h6JrRoA3RpbD8?=
 =?us-ascii?Q?9hQ8PU6QjL1crUcyfjwNO5udeCCbH9ikOQm23zJSD27kmii3tXM5M+Ucc5pa?=
 =?us-ascii?Q?xxv0ySV/R6tGiaVZMRcqOwLIwniVEuaXPPWveH1Ihv6CLql+7i8VIUqF6KkC?=
 =?us-ascii?Q?7lOcW17N6q0KMra61GzW/Odjmv0bi/4cxbGH5cSxU9wvA8Myn8wc5skMgoST?=
 =?us-ascii?Q?YOXP+cK27F3zNL/x0xosynERUub++XjzIla9G8R8JKBi80lRESFcgq4+j4xf?=
 =?us-ascii?Q?Wu4xm9fT+pidviBQHDaL6NgcY8MaSvQxFhjMTV5QK07erU2jEXovEMbqwSmk?=
 =?us-ascii?Q?Z6Q/5fz8ALL7oG5YUli+cyKB0fk5Dj80bCD7jKkK8frjv4uvNbmSISxhDLeE?=
 =?us-ascii?Q?Htcw54TZJTmuUgWCyx2a32HLtFj0CjiTW6VJdCfGWpfMUEODDSWdWAgSD4v5?=
 =?us-ascii?Q?IWbJPoeXM3LZMSuTZbbiN03uobD24IqoVd3HFnzoJDVyU8igVEuL3cIPm1c2?=
 =?us-ascii?Q?tU29gb3Vd4/MDu8LWYtoat7OTOZ1XqtEOu0652A8ALeIUH3rH9gKAWUWG40h?=
 =?us-ascii?Q?JIwGc8B12+ziub1Rv6hNGOWQpGCQ5CoFjiKvhrkHdQeaqWGoPS3Ep4EUIhuL?=
 =?us-ascii?Q?8Fa3a949b5LeJCMq7j/D9hSDvavZATb3ZSMJemPIv++Dlw6jtx0xk8u5xvsD?=
 =?us-ascii?Q?fsqse6hp84Hp+Q0d66s/WeWvFlO7JS1U5PpCMYQUHgY+w2cP01kuOxpYL2LR?=
 =?us-ascii?Q?53Hgvaq4jE0bglJ0ApW0oeyGrHKYcNMGkt1VoEPflG/WeULNMZtYZsTFvywV?=
 =?us-ascii?Q?M9GLd+34qSKAb2Q1QKeOUlMi1rYV5SJauOJeIKARmDw7BwS3Q7AXTmV/hnbU?=
 =?us-ascii?Q?RFs/4vstR8PegcF8HGM4QgbTFOzQkzKkwLjn97W1MRy2p/gL3BGP+9VSyk9M?=
 =?us-ascii?Q?GA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	XBXYo81hww6PCJCGn+O/lL5W0k+P9JVV1evr66s8N5Z3vk4ux8SfpJxNNASf1xQQYoOfKHzMu9axMIGYHL8a75j3kuBJE4dyu3VYaLSfr+VFGc463T4Sa3hhmNbx31OII5HiDgeZ7lmY+6ZhTz23c/Q27fDuMIVDA8mOFB1pqXbXO/ZKmWuB9EfbeVcRHFfOqipdgcu09LmrtVbWoZBpD7TKmBPUgZbcJS9KBSMGZy9TOLXCKQ9DIDV1APQzS52lVrUs5Jbc4kvzdWKVgbOF7JwoAAlhv05ycREeNG5K/rz70iVG/M5AfrU2RU90+qzozEoK0SLsAOCOaV0Gq6kcVctu2ul9Es7NhwdQGYkwNUDReVaEe5x1jpDz1jzUwm8P96dDtqXJrpAx6AZ/DypryZcMX08gRMHsby+1BHf/MQ1B0E886oQoso+ON2L2PKJcHqZvwTjo8vHKDge41ELPX2sns8+Wn88FPnQOLeJlsQg41bnon0MYgCjy8+dEXhwWYuYOI+S7oaBgExU0so2qRVppAArD0DiFkOp03JkmZ1l5TO9lwYVIBJfJGWOb979JF87DX+cJfAXUooWCtxAepGhgZl1xb8VjyiB0zt87TRM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4ef8248-25fe-47ab-bec8-08dc2c588754
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 05:56:32.0170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A6gJdwz4w1k+fV7RTgAchFtWEOCPdkExNbyRp+fW1xUsYQexi8gCxUZ0y/dd79FnypNLV6KMEVeS6IcTB5pqlJdpLAU7eOnmym4X0Ur99zg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6906
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_02,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=984 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402130043
X-Proofpoint-GUID: z7dvOnMISgqXLOoahKatk7ADvv36kQdz
X-Proofpoint-ORIG-GUID: z7dvOnMISgqXLOoahKatk7ADvv36kQdz

When running the idle task, we always want to schedule out immediately.
Use tif_resched(NR_now) to do that.

This path should be identical across preemption models which is borne
out by comparing latency via perf bench sched pipe (5 runs):

PREEMPT_AUTO:	  4.430 usecs/op +-    0.080  ( +- 1.800% )
PREEMPT_DYNAMIC:  4.400 usecs/op +-    0.100  ( +- 2.270% )

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Originally-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
---
 kernel/sched/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 6596b5e0b6c8..5e3dd95efb73 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1045,6 +1045,9 @@ static resched_t resched_opt_translate(struct task_struct *curr,
 	if (!IS_ENABLED(CONFIG_PREEMPT_AUTO))
 		return NR_now;
 
+	if (is_idle_task(curr))
+		return NR_now;
+
 	return NR_lazy;
 }
 
-- 
2.31.1