Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2869893rdb; Mon, 12 Feb 2024 22:24:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXONjF3bGjj2OgvwR6UsSjF4JpWxXoMmH8cLp5ZBvr2BD9dPIW9u07Xx3RKQ7HFybaHbpdZhnXHC7Q4twt7Xxr+8VeFCTZoYn6Eviacbg== X-Google-Smtp-Source: AGHT+IHaUjYyrB21bfQtuQUp9Ft8i5dAXHfgR4/09rKn6IK6qqM1YsLC67GUtLG8Lz1hvOOl+N5Y X-Received: by 2002:a0c:e0c3:0:b0:68c:cdbe:b995 with SMTP id x3-20020a0ce0c3000000b0068ccdbeb995mr2683970qvk.22.1707805489010; Mon, 12 Feb 2024 22:24:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707805488; cv=pass; d=google.com; s=arc-20160816; b=YvO8nZZBHmWDOyHDgVTMklRsGtD4VzHwbhnZcw6CBe/ui0UkXPa+xNT8cGPw0uCo84 KqFb3Sj1CtJ6uM5TWnmEmpya0tledSUTn9XQb4+5mcbckY97f9D5YdhM1HSa2ksEOegq 4ogPgLHvSPPNd9//UZ8tYFqXvXgHuA7LALh6Rw32PJY010rFG6wRIAkwPb4TeM2XK/3k p74o2vTgaL1S6QEwgcIM+c3kFdIfNev20NQoh8quGlTqVoieOTcbCoH5Av/uce2uNudi 0GY3sbgWlrzJg0jC06HRKtn/E2G3CppZU37Pqs9/oYIAe5HHjNO7orCMy9XsTdA6D8u5 klBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=cedSgtbdqq5cttJArVzEW8A88f/xREi5ZtTzOS/wyZ4=; fh=NfgKOJNl6lsx4zbRAJhI/NoJo9695qZU3ZQfR4j4KVM=; b=vpls3FbbIECY5ejH3XLtHlWNXcdr0V7LRZMwkfR9zEJu8KRM3DwDPqglmQkt2hNXO6 CA4iwgyJhngmIBHy1ot9YU++PVHnTUlTH1rTTncm8XXdhk2fX90qwmAotSqQ2SWm5Qvc OWXlKmoWJjEWPHN3jQS2jPixTMFwvhExBe6A8qq60eieiyz23qsWR8Tk3hfjLFArOjqr oXrB9rWycRlfxzsJot590NsU7cN/e5L3xGBvgIhfC0N8dT0/tFjFcHauZWp/HCJ++Zm9 3bksA3riJxooKDyZ5IJjeSdxC82ObyDu5jXJ/8Z+/Uy//tf8uX2MjZf+K0k0WM66hbrU 7lrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-63010-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63010-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCXNaspFc9+u0MXl4DDkKNuPA6sDwjl1hoUlY9SJ8Mght+dL19FqcUrwNO7jvWrlWjxHmwvBwqmNAoLS3Pn0DvtHrqxOR55cz96Xs6R6uQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id gm13-20020a056214268d00b0068cb15e86a9si2185809qvb.123.2024.02.12.22.24.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 22:24:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63010-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-63010-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63010-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C25B51C2117F for ; Tue, 13 Feb 2024 06:24:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD9851799E; Tue, 13 Feb 2024 06:24:33 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 690DC1772F; Tue, 13 Feb 2024 06:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707805473; cv=none; b=DJS4tVn0jBu1/QxtNImV1CymybBd80mfARX9L+jP+0+KmU7ExTwgHUgm/XWO6tLhfz52adE/dGBEjEtQjym+CGV3qj+krdNIBavsDRNtyyTGRgbLEg2B+EI5PiLbC/P4mMA+W5L/DZlq3peen3d+F+ACOz72CYDulB06lD6o83s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707805473; c=relaxed/simple; bh=3ihRSTn4GBO+EIOLZpr+K4VXJGFPRHT8OsRuZDz1slY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i27FjbCkMHZkeJZqdHTvvevM94V3EuuoST49cO1+6sYL1mvc9pWlZ5FlHkjPvPtkRD+N4aR44K3/KQNpq2J2CGNycZN9OUIjMGJLb5yCP8dhVNhTTtX6hUK9I7wd8rLwcImCIzJ8xjb1cyqUcabqHXgiK0vKyBLZwAv8Ky76fQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id A182F227A87; Tue, 13 Feb 2024 07:24:27 +0100 (CET) Date: Tue, 13 Feb 2024 07:24:27 +0100 From: Christoph Hellwig To: John Garry Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com, jack@suse.cz, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org, ming.lei@redhat.com, ojaswin@linux.ibm.com, bvanassche@acm.org, Himanshu Madhani Subject: Re: [PATCH v3 05/15] block: Add REQ_ATOMIC flag Message-ID: <20240213062427.GC23128@lst.de> References: <20240124113841.31824-1-john.g.garry@oracle.com> <20240124113841.31824-6-john.g.garry@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240124113841.31824-6-john.g.garry@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Jan 24, 2024 at 11:38:31AM +0000, John Garry wrote: > From: Himanshu Madhani > > Add flag REQ_ATOMIC, meaning an atomic operation. This should only be > used in conjunction with REQ_OP_WRITE. > > We will not add a special "request atomic write" operation, as to try to > avoid maintenance effort for an operation which is almost the same as > REQ_OP_WRITE. I'd also merge this into the main atomic writes block layer patch..