Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2878644rdb; Mon, 12 Feb 2024 22:55:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrQEGZTkRbc9sgFkbtqEFOxWeOxPMEtfuPcwlxL5lW2CTaePwBGg9FDJCCpibJsJTECddU X-Received: by 2002:a05:622a:1207:b0:42c:44ae:42c5 with SMTP id y7-20020a05622a120700b0042c44ae42c5mr12807518qtx.35.1707807336304; Mon, 12 Feb 2024 22:55:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707807336; cv=pass; d=google.com; s=arc-20160816; b=ZnZg7VZnHgqzxevDKuQgL249A6FKi10EAz9pyTmeQgyvpLiCes1ZSgyFUD/3rVU/bV 3AfZuxg2lATHerG8mM9Y4pwGR3dcilXsw2eqL5MRen+Hz12uKCejJMYZKSMqpf3j4O7t y9RNGkj1h3jHzlF7F9jVJVaMCtULuJp9P4jr1u95gyua228PfxqgdeeNc0BUUfeflcm8 wEn77Z9gWOmlDWR7f2L62iZPtNcc01ZDCTQmxNNn5Qi0yS8k8UdAyoCL83zitJzqkYKz vo0RQfQ0dNAXq3I4+CdrUtz08Xoxp0AMKosuZjZPFHz9dlDv343a8ZRddg60aSBvbqA8 oH0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=E7FsCnjsgn2hNY6+bTJutxFbKEDav5tJnz2j3QzNvGU=; fh=MKNGWgXCORnDSrN/pw0p+kyReBo1cE20OtQ3Kk9aTL8=; b=LCPXAY2azAZhsMIxw2kPujignfW3NHyNOdd054hinlX2LjmUMwLkwywfi5fId7UoYd 6sv5xAyL0255fYxtwXDJ/XhQ2fqCm4YGbiLamcOA9BK133YHh4TOocKfrflOF3RPlOrP QICyNfa8NwenNejWRCWtTO/XGcHZCysuJXq1FGqkXwdQ0yimD1k0VadtTfQWbintZWtn JPvOIwoK0QmUKS+kT95BpDayR9m4D0cDvfih++DQLon0hRFEp0e6LR0rjwTJLvVEJuhw O8+cGxeiXD5keuEzDWrI1+XHBHMG+O6GBlO1zactcnxQNzrMbniiEFy2vjNPIGRKgzk7 JQdw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-63025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63025-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCV1hyhGl+Qs2H117BO3AkRAAiHLEnv49i+sUYyWYy1psD2YYW2i4EvhB/ioAj99Us54DBup7tK6QGJmL3VVyPwKGMVTqJrWfGGW3kq/JQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e6-20020ac86706000000b0042c7d02bf1esi2114455qtp.161.2024.02.12.22.55.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 22:55:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-63025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63025-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 173FE1C2230E for ; Tue, 13 Feb 2024 06:55:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 51E891798F; Tue, 13 Feb 2024 06:55:26 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C6CD17738; Tue, 13 Feb 2024 06:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707807325; cv=none; b=s33hCAGYB1UVA4N+SZkoRAp5pK9DhYCubsY4wzT5Kn4/UdX++dvex43xmTYT3qOLWq1vJNIEOhdmoZz0mMUT11MrcCi6LMliKWzUjZZbLBxGBdw1K1CBQSIuH2/OPahB54ysAX+C41+dW8h3v0koDJN5OkNB0ShBP7VZLRasbYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707807325; c=relaxed/simple; bh=sJndHr+QR3Sb0xFn88/CCsJXnbajrdSNA3G1r0JM6JE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=daPIBOkTGZHXGEI5rfWRaDoP9IpgviX3tlvJ8PvX5+2p3nhr5MM1mv70aZKn8jHFYPNGwnCGiZK1nnYocGParP+8o3Ye7MvuoCjUHrZiluJCP35ZMeOBO0JiNE0BxzOdg+1fI/kUUtWwrODcpperLLCG0PgiSuLjPov7ouWVBuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 498E9227A87; Tue, 13 Feb 2024 07:55:19 +0100 (CET) Date: Tue, 13 Feb 2024 07:55:18 +0100 From: Christoph Hellwig To: John Garry Cc: "Darrick J. Wong" , hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com Subject: Re: [PATCH 1/6] fs: iomap: Atomic write support Message-ID: <20240213065518.GA23539@lst.de> References: <20240124142645.9334-1-john.g.garry@oracle.com> <20240124142645.9334-2-john.g.garry@oracle.com> <20240202172513.GZ6226@frogsfrogsfrogs> <2f91a71e-413b-47b6-8bc9-a60c86ed6f6b@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f91a71e-413b-47b6-8bc9-a60c86ed6f6b@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Feb 05, 2024 at 11:29:57AM +0000, John Garry wrote: >> >> Also, what's the meaning of REQ_OP_READ | REQ_ATOMIC? > > REQ_ATOMIC will be ignored for REQ_OP_READ. I'm following the same policy > as something like RWF_SYNC for a read. We've been rather sloppy with these flags in the past, which isn't a good thing. Let's add proper checking for new interfaces.