Received-SPF: pass (google.com: domain of linux-kernel+bounces-63044-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 12 Feb 2024 23:28:31 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Theodore Ts'o <tytso@mit.edu>, "Reshetova, Elena"
	<elena.reshetova@intel.com>
CC: "Jason A. Donenfeld" <Jason@zx2c4.com>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>, "Dave
 Hansen" <dave.hansen@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"x86@kernel.org" <x86@kernel.org>, Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>, "Nakajima, Jun"
	<jun.nakajima@intel.com>, Tom Lendacky <thomas.lendacky@amd.com>, "Kalra,
 Ashish" <ashish.kalra@amd.com>, Sean Christopherson <seanjc@google.com>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/random: Retry on RDSEED failure
Message-ID: <65cb1a1fe2dda_29b1294e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <DM8PR11MB5750C7D16DC566CD1329D5A5E77C2@DM8PR11MB5750.namprd11.prod.outlook.com>
 <CAHmME9q-eUXnXnpaDu0VOQemOYysst7SaJ-=b8-vCFP9h50Szg@mail.gmail.com>
 <20240201045710.GD2356784@mit.edu>
 <CAHmME9oqM2a766dBK22-yKr8=2-icg=UkQzmBOF8G5Zh_Y9E9w@mail.gmail.com>
 <DM8PR11MB57505F657A8F08E15DC34673E7422@DM8PR11MB5750.namprd11.prod.outlook.com>
 <20240202153927.GA119530@mit.edu>
 <Zb4RlTzq_LV7AzsH@zx2c4.com>
 <CAHmME9owdbHzfb66xisoWmvWeT_-hkxCu7tR2=Rbye_ik1JgQQ@mail.gmail.com>
 <DM8PR11MB5750C1A848A9F1EF6BE66241E7482@DM8PR11MB5750.namprd11.prod.outlook.com>
 <20240212163236.GA444708@mit.edu>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240212163236.GA444708@mit.edu>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVlydXdqUFNnV1o0WUYyQUxReXNyTStwWkRoSkdUcEtXc1ZsVi9XMzBJQ04w?=
 =?utf-8?B?MW1xUGdBbkYyM0N3aG1EanI2alFTeWlBdnY1ckJwTHBEeGtQRVZDbm1MNndD?=
 =?utf-8?B?WDhCb2hiVDhnb1FLOHZjUW4wWHhFS25jTFFMaW1hUGpKQ0JmUlNIM3VqTnVQ?=
 =?utf-8?B?U3poMlhKOGtMb3ZKMXNBZjR5SlY3NGJIOUhtNGpkbVlQVmtOb0dDOFVrdExV?=
 =?utf-8?B?MFZLTWp6S2R6aEsrejdCV0pucnhncm1mdllCYjIrZGQ5T2Z1cFhFM0YxdkRr?=
 =?utf-8?B?emNFeXBaTG5KRkk5SFNNVWhHMGI2ODdaSXdTckVZWm5xS1NwQXZROWgzRXM2?=
 =?utf-8?B?RVhZWkJDUHpVaDU2b3pQaVpoUmpVMHdBeXNxRFBRV1czQnFFdjhzOVVSbkxV?=
 =?utf-8?B?OEJOKzVJOTJTdXdFb3lKVDZtMUFlTFhMV3R2SFdKU1NXL055NWl0MGpTczM2?=
 =?utf-8?B?eGwyK0FYb3l6OFhUUnRQTHJibEFDNHVETFVRY0tJbjBZalNKYytSZlN5S3c3?=
 =?utf-8?B?c0hZbzFkZzNNS3pKWHZteWMvdkNmalV4RmNtSGd2MW16cVZkaEUrK1E1MjFI?=
 =?utf-8?B?ZDBmV3VOa1FEc1pNYjNWZHZhRXNKeU4wNi93WVBUSExsalBPS2JoSXQ5dHFT?=
 =?utf-8?B?MmpSMVFjT1JIcDExeUhYYnpHT2NaVXN5a21XMnpYdTQyQVBvTDdiOHVxSEZ6?=
 =?utf-8?B?azFWVlFDSG9oa3I4SkJPTlBaY3p2SkJuUW82bUlIVzAwcTd2SGg3WXIzc2p3?=
 =?utf-8?B?R0ZVWnBGb1NvQjdnb1h4cjJodXNONXgwTmE2aFA2L1Z1c0dDTG9lM1VvOGJW?=
 =?utf-8?B?N25mb1BQZlJnQ0FhQ2RiNFUxd0JHcXNPa2VwMEdlUUpqVGF3SE03ajdaYVNJ?=
 =?utf-8?B?ZFVtMGVoY3BlNjk0dFF3clRvYm9XN0dvUmpxRklEMHhBMDgwOFJIbzV1MzRF?=
 =?utf-8?B?K050SXRlOHFZemlEV0I0RzJvWjN1OVY0aDVoVUVCOGl5b3VDcjRJUVRyM2hy?=
 =?utf-8?B?UUZ1emdNMlhUR3p1cXptTUtaaEVKZzhyVkVJMTN1UU9nZUNSbDViUlEyWUh5?=
 =?utf-8?B?RWJTaXJSZjdMcVlIYjlqYS9GNWh6K2dnSFpjdS9JaWRRZTU1NTUwVzVpVEpS?=
 =?utf-8?B?WVYvNFhZV3oyOVcyOFZrTkdPZDljOEhCbldibThjVFdiQnM0VitzaVIwZ3gy?=
 =?utf-8?B?OEUzOERWVDFkNmg1eWxnLzJnWWdiK0ZldkQyRVFzWmIyOEQ0L1BXL3dSd3Ax?=
 =?utf-8?B?NC85VVEyTjdGUUt4c1hZSjlQWEwzSkM4eVRIeDY3L1lMQmUzRzNiVmpOYmd6?=
 =?utf-8?B?Ri9MQXMwbHA3TGp6Qis2cFlxTHN0Z09ld3hJMXovc2Z3S2Y0ckF3RVFFc0di?=
 =?utf-8?B?Z0J3OU5sL3FxcktXeTQyZTJhVm5QRTNMMkNJL0J4NDM4VGZ3dCtncFIvYVNt?=
 =?utf-8?B?c2lDUDVXZUtteElubGMzQlRid25BVGc2aFY1NjR1T0xjbWVLY0NBVjJ2Wkgr?=
 =?utf-8?B?aU53VjhPZmIrZDdmTy83ZzlmWlFIeWd0OE9wUU50RVEyVlNoWVhOM3pPdTFF?=
 =?utf-8?B?MWduMHJlRUZPek9KdUpLV2s3MlpHb2NlTGowc1lMQm5iUERiQ1Z0d05PdnRT?=
 =?utf-8?B?alFjWFBOMlhSWUh3b2pWak1qZDZFRVVwUzZRVTdZblQwZ2JxSkEwdC9VOXF4?=
 =?utf-8?B?dlBSTTcxdUxSNEpFekY2MkJxbFUzc2hneWlhcTRXRFhOWTNLYmdZdUFpcG9T?=
 =?utf-8?B?OFRBODZHQkVOd0pmZ284ZTd0c3NpcXZScjd5NnJGeENpT1A4V0pLK21PakNF?=
 =?utf-8?B?ZUxWZytYNWFPbzRTY0RTWTJvdms2VEVHUW5MSVozbDhkNG1XbTA4VURuUFZR?=
 =?utf-8?B?OTR3T00vVkdKUTV3QVZSNm1XbWE5NTc1N1RELzVtM2gxcjh5S0JNdXlVc1JH?=
 =?utf-8?B?R1I2bEJGcXFuZy9zd01uRGZHa0JINUx2TlNkYmh0dzl2YS9oZ2lKZzJ6SnV5?=
 =?utf-8?B?dlFLQUtwSmVFRE10UjA1VlR6VHZFOWg0N3VxcFhtVE9OTXg2dURLQytFNlB1?=
 =?utf-8?B?MU9ZeWlwUFVCV0hCUytVYmFydWIvVktoR2JVeUlXVm5IUUpsL1RTcDVpY2xJ?=
 =?utf-8?B?aXgvVjFGUW0zM0xJZ01mWkhrbnRKRGNYMUw2MEd2NnBCL0NYbXowUkM0em5R?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: abc801a7-b70a-4b64-435f-08dc2c656344
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 07:28:35.0611
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fKuUCqfu8x11diYzCgCjdlXgY2tiW3bAdnvgWhcaKFqH4Og846Ni+xmsjXL5IlvSs9EcJiPiIsfnJF0Taq63JdifID5w8wWioAeoRme5gLw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5239
X-OriginatorOrg: intel.com

Theodore Ts'o wrote:
> On Mon, Feb 12, 2024 at 08:25:33AM +0000, Reshetova, Elena wrote:
> > What if we instead of doing some special treatment on rdrand/seed, we
> > try to fix the underneath problem of Linux RNG not supporting CoCo threat
> > model. Linux RNG has almost set in stone definition of what sources contribute
> > entropy and what don’t (with some additional flexibility with flags like trust_cpu).
> > This works well for the current fixed threat model, but doesn’t work for
> > CoCo because some sources are suddenly not trusted anymore to contribute
> > entropy. However, some are still trusted and that is not just rdrand/rdseed,
> > but we would also trust add_hwgenerator_randomness (given that we use
> > TEE IO device here or have a way to get this input securely). So, even in
> > theoretical scenario that both rdrand/rdseed is broken (let's say HW failure),
> > a Linux RNG can actually boot securely in the guest if we have enough
> > entropy from add_hwgenerator_randomness.
> 
> So the problem with this is that there is now way we can authenticate
> the hardware RNG.

Sure there is, that is what, for example, PCI TDISP (TEE Device
Interface Security Protocol) is about. Set aside the difficulty of doing
the PCI TDISP flow early in boot, and validating the device certficate
and measurements based on golden values without talking to a remote
verifier etc..., but if such a device has been accepted and its driver
calls hwrng_register() it should be added as an entropy source.

Now maybe there is something fatal in that "etc", and RDRAND needs to
work for early entropy, but if a PCI device passes guest acceptance
there should be no additional concerns for it to be considered a CC
approved RNG.