Received-SPF: pass (google.com: domain of linux-kernel+bounces-63079-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <749e8de5-8bbb-4fb5-a0c0-82937a9dfa38@oracle.com>
Date: Tue, 13 Feb 2024 08:15:08 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 07/15] block: Limit atomic write IO size according to
 atomic_write_max_sectors
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ming.lei@redhat.com, ojaswin@linux.ibm.com,
        bvanassche@acm.org
References: <20240124113841.31824-1-john.g.garry@oracle.com>
 <20240124113841.31824-8-john.g.garry@oracle.com>
 <20240213062620.GD23128@lst.de>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240213062620.GD23128@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SUJRNHVRdlBueWFZU1ZjM3l0all5WjZEMEcrTXc5WEZnTWhwVjRtNWV6ZXVx?=
 =?utf-8?B?eE41TFoxaThDSmt0RjhiUW9VekRJWFJQMEU0RWdYMERkeXZocDU3TzdOWXJM?=
 =?utf-8?B?NUFSNnRVTk5Obi83d0JEUWdYRjZrbCt5M0ZndWtMLzlydXVVRlREbTF4QlNF?=
 =?utf-8?B?cVdYckgzbEc5akZlakthTGt5cU5VV0N0ekdHRHRJcGl6a3VKTUZIU3lPNnlB?=
 =?utf-8?B?MC8vU0dmNFhNOEQvUkwrOEhtZmhvYkU2SFdRZW9XMWlXZVZzZUp6YnNSYTJx?=
 =?utf-8?B?S1NpVXpNL21PNGJVQTNIc0U0cXM5Z3lEMFZLOE9Cck9Sc0ljSnRCZUdXWkRw?=
 =?utf-8?B?YnNJNythTi9lUFIwbTJCVmpQSTllT3NaUUZmcmRtRUxKTThtb1pJM0tPOGo5?=
 =?utf-8?B?TjllcTcwdGFVcHJnQTJDTlZsU1QvWGlRdlc0eUhFQ2tMNVh2M29RY2k0WEZU?=
 =?utf-8?B?WStCQUJiYlprdnB6ZE9rSU16andBUnhSeWJwWUVkV1J3d25EZjRnNFNMNGJ5?=
 =?utf-8?B?Q0g1QmtLeHJOb0R5WVQvbXpBWXdjY0c3dldJL0U0OEZlaStOWnZ0QWFnZ041?=
 =?utf-8?B?bDJOTzBQL29WcXgrS29TaHQ2elFDUHR3MUJKcVBZeG90R0ZBSlFaYVF0WXdy?=
 =?utf-8?B?aHdaRTRrUXVBYWtmampjSHNWYzQ3TDMwaXRNVlBXOTVtWW9Kd3pvTlEyWUFG?=
 =?utf-8?B?SncxZWN2RE15RGRNRnJ6SFRzOE1xRVBHM3NHNWhqT3h5SjZVcHRRbDhwZkc5?=
 =?utf-8?B?aEZSSnhuU0cwSHZuTmhLRkJLamNkNEMrRERvM3NZcU1ZTEgvOUoyWkl2UVB2?=
 =?utf-8?B?R0hqK1BlWmZIcUg2SVQ5eWFRSVVPSWNuMDNxT0ZwV3l0YlZtcUxEdjE2OEZK?=
 =?utf-8?B?enVOQndSVkVKeC9YSFJUL1FZdzZNU3YzOWl5b0RZUDNzY1pBSTVlZHl1dXBH?=
 =?utf-8?B?SVVJbDFITTFUL1d0Q3NrUlE1OE5vZnpDcEtKZ0I1WHNIaWZWYlBMUmx6cUE3?=
 =?utf-8?B?TCtlSFJjd1lLOC9vY25tYzMzOVRUTW1TMjVlakhHWm42eUVCQWhpY3pGUmRE?=
 =?utf-8?B?N1ZmN1Q4WCtYSTU0T1N3b2VYcnhTTkZMRjdaWGVINzY4Q1gxMHJXcnl3d3Ey?=
 =?utf-8?B?d1JFRjI5MTBSeHdPYXNFNlpkTllhalduZ29tK3k5SC9FZVdFaVZXU0dKWWda?=
 =?utf-8?B?R3dmcW9zaHl2M3FUODBBL1RiYU9BWEJqNXBqUHlsaGZuaWdUWVNlRjFSTWdo?=
 =?utf-8?B?dm1jeEtqcml5VDMvd1JMOC9EcVRqUkRwbTRiZFZhaG1lblVGMTFwY1I4QVN2?=
 =?utf-8?B?azB5aHhjcnpMcGxRQ3dYSFY5WTZlRjEzSmtNY1NTSFB0aXQ0YUJqOVkvUjdF?=
 =?utf-8?B?VXlGVU40R0RqQzZMWXdDcUN0bzNCYm1nanI4ZHVDZFp5TllwNGkweG9vcEhB?=
 =?utf-8?B?WTNOUyszbHZFTm10K1pvdFdiTlpTc2cwL2JZNCsvWWo4cUJuL1VqSWhENGV1?=
 =?utf-8?B?ak5ITU90dzJZUGtkQjVMTVViQU1xUnp4NDQ1RHJ1Sm9Nandqd0h5ZkV1bXBF?=
 =?utf-8?B?TFdWVHZ3VnV6SkdveXFtR3BSdG9ZVkxiNXZLVW5pcm5KZ2lkS0JOVXZPWEFs?=
 =?utf-8?B?S2YxK05LTHRjSFFydEd1cFh6ajBmeXhrdWozc2dReWQ5L0w5Qy9VZElMYkln?=
 =?utf-8?B?ZUhTNVRIdllqdTFlUzM3Y29NMjIrbHBNemNjcWNlMlRWT0g0eUNBV0xCUlpx?=
 =?utf-8?B?R3Q5MkdhSjJhYzRYUHBlQzc4em9PSWNMaHV5UHoyVUJKQUprQVYwQnJtbmlr?=
 =?utf-8?B?b2x0MDc0UmNZcVFadTBsMkUraURsNEVHYi9sSGo1ZzBwUE9wcTQ4ZStUdm5a?=
 =?utf-8?B?dldPcUJCWldVNzFVZnloU09ady9CL1NuRE05ZlcyVkx0TnBnSTZUWXYwVUV3?=
 =?utf-8?B?amdZa0hIT1l3bnVzNjlDSXZRTEFBV0NlZm5mQUVIbkRkMEFIa2UwTjlWRW95?=
 =?utf-8?B?LzVOT0V1YnV3TTlIQnZsSFJ6THFnRmVuR1luTjV4TjcybjVvcDhrc2NxK2hG?=
 =?utf-8?B?ai9MNFFQY0NjMW1GU3VmM1JHTjBITGlxay9oUU9wUENQd2JDWDlENjZha1ho?=
 =?utf-8?B?K3Y5cFBhR2pjbWV4MUJwQTh4d3lxOTc0WkhVdFBZRFFlSDhacW9wOVdkL2JM?=
 =?utf-8?B?Q2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	JAPdlaXQ25unKX3CM1Go4hgULVvwEeeRo4WKFkVwvL+VtkKoMV8bsg/N9g/CaPpDkijsS2eUw+FxTgBAhUegCNTlnrmoNsH0TWx2T5R0X7NE7Ev/sPySTpYZYcVzb8ggWe+/6RP+La2x2khyFrgJd7pmWte8tWs5319gkL2ELeLwWVa6NvfC85YXogD4Xr1w5q5NHKYPy/kdwgzQUQR7IeHafye6fzIEWqv9VBrede14jUDBCCNEaB6lkXpMMpBMmieyZjE87gOLbBX0sdMDiNH/OGOKvgUZihXkX0Xf3kcPT07T277ZrwwcTH5EV1aPDk59grnqrkmcHmaEVjXd1cGC4xev0XoKl8OAg2XCBP+XLjd5KT5og8kVqSKF07Lj1+6MWqbe2bJTqSW1VmmMltK8KaV4V4MUONNYOuUqxjIAIaCyBgZ6hVew2fKuu8LeUFMs9ULY5ZM2JKMukdAAFdrEOPCLZvifdcmp1yvqjCDYJnYHTg69wm9jypXtkj3zMucd9s1+9Ys0+3ggxUeoZ496Gx1GQGIRBuix/4AhZe/Vkfa8SjCkZJUk0Wgg1upIIuuoMRLDLBqP6jAgMDidc/9XtDVrNIUL5EFXOM1qkzk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d560572-76a9-4797-871e-08dc2c6be78d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 08:15:13.9498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JdVAPgc/MSu9AVFWuzACQq0sn3KDOPLnhw/P3eAAfMuTigkjUFN96Oqg9aNC9YSPMH0+pZVe7II3mgkg6KUdOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7163
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_04,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402130063
X-Proofpoint-ORIG-GUID: wHpBI4DeqhRvOWmtRgMYqxOFqxNaOpxv
X-Proofpoint-GUID: wHpBI4DeqhRvOWmtRgMYqxOFqxNaOpxv

On 13/02/2024 06:26, Christoph Hellwig wrote:
> On Wed, Jan 24, 2024 at 11:38:33AM +0000, John Garry wrote:
>> Currently an IO size is limited to the request_queue limits max_sectors.
>> Limit the size for an atomic write to queue limit atomic_write_max_sectors
>> value.
> 
> Same here.  Please have one patch that actually adds useful atomic write
> support to the block layer.  That doesn't include fs stuff like
> IOCB_ATOMIC or the block file operation support, but to have a reviewable
> chunk I'd really like to see the full block-layer support for the limits,
> enforcing them, the merge prevention in a single commit with an extensive
> commit log explaining the semantics.  That allows a useful review without
> looking at the full tree, and also will help with people reading history
> in the future.

Fine, so essentially merge 1, 2, 5, 7, 8, 9

BTW, I was also going to add this function which ensures that partitions 
are properly aligned:

bool bdev_can_atomic_write(struct block_device *bdev)
{
	struct request_queue *bd_queue = bdev->bd_queue;
	struct queue_limits *limits = &bd_queue->limits;

	if(!limits->atomic_write_unit_min_sectors)
		return false;

	if (bdev_is_partition(bdev)) {
		unsigned int granularity = max(limits->atomic_write_unit_min_sectors,
limits->atomic_write_hw_boundary_sectors);
		if (bdev->bd_start_sect % granularity)
			return false;
	}
	return true;
}

I'm note sure if that would be better in the fops.c patch (or not added)

Thanks,
John