Received-SPF: pass (google.com: domain of linux-kernel+bounces-63096-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <cf2e7d4b-9ad0-4013-8e5a-48047c588411@oracle.com>
Date: Tue, 13 Feb 2024 08:20:02 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/6] fs: iomap: Atomic write support
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        chandan.babu@oracle.com, martin.petersen@oracle.com,
        linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        ojaswin@linux.ibm.com
References: <20240124142645.9334-1-john.g.garry@oracle.com>
 <20240124142645.9334-2-john.g.garry@oracle.com>
 <20240202172513.GZ6226@frogsfrogsfrogs>
 <2f91a71e-413b-47b6-8bc9-a60c86ed6f6b@oracle.com>
 <20240213065518.GA23539@lst.de>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240213065518.GA23539@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?L2NRRzBJdk1naFJhaE1uQjFDbE9MRHh5TGhSQ2JtYjNkZzBLOGw1cHFmSzRR?=
 =?utf-8?B?M0hvZWZSZ1ZwS0x2RFg4M2pucW03L21nRWE1ZkJYYmNQWmFRNXFPSGdZUDdD?=
 =?utf-8?B?aDRDZXJLZUdqekN5K09ia2hYT0FaOFVuMlFRbVFxeklpc3M0R3R5aTdscmJr?=
 =?utf-8?B?dVBtSlJ0Y1J5MEFKeE5jaE5xTWNCME0yTWJkZ2VoT0oxVW83NTNtMW5zTlpz?=
 =?utf-8?B?andqalI4cmpEN3NjVGZNUDYyQVRaLy9pcmxDWU9BdVlvUHo5ZXRkc2xEelBn?=
 =?utf-8?B?ZUhTa2FOTWdkZFhKV1hYV21Id1NCMFErb3p1TUtidjJ4QVROeTR6UVRaZXFj?=
 =?utf-8?B?YTJOWWMwbUREMnBRV21UNWZTcU11NlpqcnFvdmE2TG5yem1OUXZNTGNCbEJa?=
 =?utf-8?B?K054eW9HL05XV2VEYWhtY2tpUFBQc2lLT2NIcHQzVFdnbkJPZ2hHWWx5dGF3?=
 =?utf-8?B?N3hJR21BWG1KSVBNcFppSnpvajFFNytyOW1qR2JucmR0bEVjSEl1VXFSZGVt?=
 =?utf-8?B?NGsvSW5NSTlYc3FhTHh5cWo1dFJOS1MxdER6akZqWnUwTm9Na1pXRlhLU3E1?=
 =?utf-8?B?WlpnQTg3UzZmT01CVmI3ZVNGYWx4T2E2TkZ6b2gzUFZRYlpUejlsUmtWZklM?=
 =?utf-8?B?Zjh1OFdFb1FiM05FSnlJcDhIVnJ5dlRGTGM3clZQcmQwY1JMY3NuczZCZDlG?=
 =?utf-8?B?QkVTNEJTMlRjUndDMU9YVmFNNFd3d1E5bVZ6VjdMZU5wbkt6UGRLbnZwZjV2?=
 =?utf-8?B?djIwd0N1NWc3c3loQ3VVV05CMnphVFZaYk5qUVlGZ1o4d29kVWVpbDA2U2dq?=
 =?utf-8?B?bmtmSEdLdzZWeGlZekh6ZTFnTHJNTFlYM0R1MW9NVzJYNjFrNzdIZ2JHdE5m?=
 =?utf-8?B?Y2I5OVJVeUtsSFhubk9iUll2ajl4MXlqMDZKWW9XR3dxYmg4RnlMRGZpTURO?=
 =?utf-8?B?b2kzcnBGVVhiZ2p3WXNTaC9wenN4SFViVEFIMEFSUmVneHdjbnpaVXcvS1hM?=
 =?utf-8?B?TmxsVUxPL0xORnhkSkhKQVAvS21NWWNDNjF2N05lTUZOWEM1TTZJQ2UyUi8r?=
 =?utf-8?B?NkxiNzRxS1hENEs2MXMrR3BHNTg0RU0rYWpqWEpBeW9TWGFnRUhvQTZ1RGJl?=
 =?utf-8?B?TUVYQURVT2RMaUZIay9Icll1OU9uemJRWWlLK2FQb2hEcFRHTkRWTXorWXpj?=
 =?utf-8?B?NlNaOHh0ajFqVUpDSm5ubHhuK0NMNGhzMk9UdnVhVStGVURuWFBnN2QyTkhX?=
 =?utf-8?B?TzFmZXRRb0lNai95d2Z4bFIwL0w4c2dPM1RrUitIZWRzYW1ESzVJdkdlNXgx?=
 =?utf-8?B?TWdpaDhidTJxMGhmSXB1b1hIMVpCTzlXMHZjNjJ4eFlRWDdLbVk2K0xYS0hP?=
 =?utf-8?B?aXF0all5aTJ5S1dXd1ZGWkZycDZxUFlRaEo3MmFQc3MwVktnbCtObWczSFlI?=
 =?utf-8?B?bENMU1RwQmo1SnZoUUdndUE5ZWJuS1dJTHh6TDhDc0NQMzE2eFZrcjFvT2Rm?=
 =?utf-8?B?SzhTdURkSTcvdlc5cWRCTWtFdVRFK2syaUtiSG1CbTdtenA3Mk5jRDkxcnYy?=
 =?utf-8?B?U0tJWTBaTmhMcFlvVVdGMXowa0xaUk10VjFqUWxFU2NKS010RDRjS2ZNYmJP?=
 =?utf-8?B?QXpLT0JFaUlwbzdlcnFzRkx3MlNMc1pOeHE4UXZIUmxSLzNkQmF0cnA4Q0w1?=
 =?utf-8?B?ZzFIeTZ6dGRmbjJsRWlwOEcyMEdWUW9CbFV4SUptMkJ4eDVqNUlpVkJTSmFZ?=
 =?utf-8?B?UG0ySUdiK1R2bjJLZHhpbXV0T3pweldRVVlqUEovWVBMRytxRUpHUWZ1eEdT?=
 =?utf-8?B?dXZVM29XdXBiMG9NTGxxNml0NHpDQkp2YzhiTDdoY0ZJVitLSmc5dkIwdEZj?=
 =?utf-8?B?bGFlUUwvazVxVW9aL0YreHh4TXlxVDNVNUtHNWMrQzFCNmZDYStKUVh5TlV6?=
 =?utf-8?B?eXdES2xidnJxYUg4M20yRC83d0NKeE12R3hXVURiVktaS284SEx5MVFZQ2p4?=
 =?utf-8?B?bDVvZzdjdjZrcmxvZUJPbDI0Q0NRbmZuWm1UdmJMQ1dQTDhMYVdyNkNFQ3lx?=
 =?utf-8?B?Wi9GMktKalhhcXFMTk40aERLQ0FRT3ZQUFBZLzhUTFZ6bXpyc0hHQy9TRmds?=
 =?utf-8?Q?QWmUBqzrm5JdCV+GXNzMuV3Rz?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	q1yDDI9LuNmVo3MJoPL8kaqEuGyPxlnKMZNdVEuSVuBJuHsooOLOHhTvTEadFGcfBHUlesh1DCrzgpGVCGfhystb7YOsyoQhWEgDHwbt6eXnNhvN0gO/q/p48uusSy3ZGzVMhJWsFET0RQBJ3fKa3a1vpWLc1WgaAU7cFQJ+b8cVbLO8lX8i29aVwnvfc98lcqx5X4O/7ko7jX3eo0WSFFlTTmt0UNstzdS59cXq1M8cij4uh0SaFke8TtvFql/NW+aygvuysKNylQV4ZNtuPIz9QfWssASP+vE1roxT3WWKTC5sFxlRgwR43UfCF5BAVHgRy0CuyNc2Mho+WyFmWQrGUkwG98S8QXjIL9gQuI80uKRTkUNGSYCfa+v9pygQJfRqTUSG2ragPvKZ6GGiJ/vbc6EgwM4K8fECCBTCYmYl5m+4WqgcsFjIOJNO4lBB/RSGObz9Y3curVwRbX4FAKDkzm34Hs7D3DQOA0shcs1VZAyNaL30d921rDZtpQC87SKfaNbf9Zfjzxz/mkrhMDiA2O7TIXyqnXZUe93zL2Ums6cZLQ31y1c7TLf8R36b1+cQE2lHSlm7Ysl5NZkILKuCELOKEJdWv16hLYpU3iU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7c72f87-0f15-40fa-8ae9-08dc2c6c9681
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 08:20:07.4734
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hOQeVNBvq12I23bC9UPK0AEPMrfn33F/AWtdgtmxjdmH7J2scKtacxh8B7AaXz+99Ogdpxr4tDFNVBC9FA+Tuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7163
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_04,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=891 bulkscore=0 phishscore=0 mlxscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402130064
X-Proofpoint-GUID: aRM2pNSMhBWhQfz2T-8jJVYZfYay6ZOa
X-Proofpoint-ORIG-GUID: aRM2pNSMhBWhQfz2T-8jJVYZfYay6ZOa

On 13/02/2024 06:55, Christoph Hellwig wrote:
> On Mon, Feb 05, 2024 at 11:29:57AM +0000, John Garry wrote:
>>> Also, what's the meaning of REQ_OP_READ | REQ_ATOMIC?
>> REQ_ATOMIC will be ignored for REQ_OP_READ. I'm following the same policy
>> as something like RWF_SYNC for a read.
> We've been rather sloppy with these flags in the past, which isn't
> a good thing.  Let's add proper checking for new interfaces.

ok, fine.

Thanks,
John