Received-SPF: pass (google.com: domain of linux-kernel+bounces-63119-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Inochi Amaoto <inochiama@outlook.com>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Inochi Amaoto <inochiama@outlook.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen Wang <unicorn_wang@outlook.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jisheng Zhang <jszhang@kernel.org>,
	Liu Gui <kenneth.liu@sophgo.com>,
	Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
	dlan@gentoo.org,
	linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v7 3/8] clk: sophgo: implement clk_ops for CV1800 series clock controller driver
Date: Tue, 13 Feb 2024 16:27:40 +0800
Message-ID:
 <IA1PR20MB495356A648B06702B3BA9FF3BB4F2@IA1PR20MB4953.namprd20.prod.outlook.com>
In-Reply-To: <20240212-list-grumble-819f7988aaad@wendy>
References: <20240212-list-grumble-819f7988aaad@wendy>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|DS7PR20MB3776:EE_
X-MS-Office365-Filtering-Correlation-Id: aad7f232-fcd1-4140-ea99-08dc2c6da93f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6V5tr74vDc8g7Cv4y6A4piCIPRorKcI6uWyK2cuwAEm065tY3c0JkfEtDQyESbrRgGlpGATyp5Z9CITjmuq2R0qGrtigFhtSEOaJze2CtNKRW5n66aaWS+np92HfS5E11hwfyDD6WuLh5LOZFoShgXCDC8AXWxZ+i7/BJ+xkBvClCsvejk2UrkGbHD2Q4Whgxwa0AqANcYxjj9tn+1Ig+lI6Acf5I5MzZ85ftHUckOE+9V7coCoGWK60zsuzF4AEwvVlSE9Ky4BFttTaEW9+4bgujKx9b8NwBXMwJyEyAxGMZnSNy6Aq0uUJMYzNMJ+dBKRBmo4PSd69EnCgoM077Bk3Kaqf1xwe6bm+6gviix8NlAwZKUypFMafjdh8IukR2KBFnKUScMF7unwFjo4mAtTfZ3qg3A8BNCWZjMQdmQwmLvYJfPW3qvnxcP98AyQjj5Kmr4Nu7XYt5MBP5kUOKtI2vdKstxGswYzMbhF/kxlYY5O32BWpY5cveT+YsyDse5Sn+I/dgkcXb5v/JSQ9M5hmrj1+Xj18zj234QGRl55HzqqkqVEreWH4oakBePItV3RVexodhHG3w1iZ+da5WL6TcTMhHpWOb5LLIPy2vxhuf3vbnZwl/UotSAPfOWb5
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?139tMaxSgwNS1FUxVIKQ2//JSYAj/EIj17Dp/uci7kY/I56cm9gwl5JqxN0q?=
 =?us-ascii?Q?1vQuLHDrTdveRVY2kufuuirFRSUJlMzhxjx02F1klYSWukAlfozojvzYDmPk?=
 =?us-ascii?Q?CeAo0jRmayKL/8Ly2NvvYzwYQfhy2T+iyMfaoaihBNRzjR/oXn1fN79bbnoD?=
 =?us-ascii?Q?sjjV02RaAxMrnVynvzeNxpXUK5QXiz0klyfBXa8VjsVX77oUMC9yhdDa7fbc?=
 =?us-ascii?Q?9E8p3TFla6UDQwumuHoPWnC34cv5L+x6u70SLxInrdhEJ7YvQGxm7xh5B1+1?=
 =?us-ascii?Q?WvFQTEGQGL7gc5u0MXdfzmzOEjy7bJXCBoRpWdmfAYv/t6KrCtM8Fw7YGse3?=
 =?us-ascii?Q?X+N/L0AkABr9t4BeBSWTGsvWNRj1h6HCJzOr+izKo8aOTvtdAd2qCA5vd8D8?=
 =?us-ascii?Q?i9piau/dInbDGesgmyeFNB52jn0b9cgHPwHZC5bQsJu/EKWAY6xxa5Q7Y0TO?=
 =?us-ascii?Q?fXziNKYrZgvblPYfdh8tVrrK0kReXYAnqPe7onVlDkPfJ9mJ6WUIvrkubXDf?=
 =?us-ascii?Q?IHfqudcMGU7c6DQxZBlOxR0CrpK08goFqfAKbqVuHB0OCIf+doCuawiteYDv?=
 =?us-ascii?Q?TanFE2LQQV+skTjZSgkLhL1KpdNwadrpuYGtf1s0HQzwbx6zJGft8LDwUadb?=
 =?us-ascii?Q?P+PJyIkiyymnxnqOWgGBrE4JAKtDm7Xehp61MK9f4kKSzYuVlX0dGZahSfV5?=
 =?us-ascii?Q?+xXS4sbgq5rIYv8nYIEmKYlvyfRUKTjqh3UptNE2h8O/oBH1j//jW7BQO5NG?=
 =?us-ascii?Q?PMZ0zDsaJnu5LhW91Xy7qhaKbMeHGnTudnOAqEOKu9qAbrbuW0VR9FJBdMV3?=
 =?us-ascii?Q?kJxeGribI+k3OMbqrG9c7SP6mvbSI4hsCWt5hzjVcuNVP0H9ptlBPeTBjc7h?=
 =?us-ascii?Q?nV7XmZSucByE8I2UiWq4T7ZdS9KNrCgoDspQpCngUdaVAjEv6p1wM6+JF3pf?=
 =?us-ascii?Q?/ZDZ54MDQUBMJx1rLoEaFWtb85IQ8BWjBMYvrgqOY7HHx+c6oYaqt5gaSTNT?=
 =?us-ascii?Q?DcQybz3YjL8Os3qfeBfLxDQX/+Ob2kUz0mMMypL4iLpn4AFgn6y0y3RYcwmD?=
 =?us-ascii?Q?ZSazfaEHBigClZuB89ekpis4i+kLFBUBOOFJ8O9wplrKi5LcqDgugX22408z?=
 =?us-ascii?Q?PBj9ssgzL/Sdb0tlb/rJ+btY06tesl8ICHR5vdeVcJLKRwxar8bxId85iGAm?=
 =?us-ascii?Q?24kPPIsHCSSgWuOO6N/lo/e6ADKXZo3xTOjwPHRNk0rxNML2dnPu0PAvFLhz?=
 =?us-ascii?Q?bZcwLe9foWtsQ9VWpxVgF1J0DVWmsXMrdfDhGNkDz+ortiTy/zCINGbr1iE1?=
 =?us-ascii?Q?3Q8=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aad7f232-fcd1-4140-ea99-08dc2c6da93f
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 08:27:48.4191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR20MB3776

>On 64-bit with clang:
>drivers/clk/sophgo/clk-cv18xx-ip.c:745:6: warning: variable 'flags' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>drivers/clk/sophgo/clk-cv18xx-ip.c:745:6: warning: variable 'flags' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized]
>on 32-bit there's also:
>drivers/clk/sophgo/clk-cv18xx-pll.c:28:2: warning: comparison of distinct pointer types ('typeof ((rate)) *' (aka 'unsigned long *') and 'uint64_t *' (aka 'unsigned long long *')) [-Wcompare-distinct-pointer-types]
>drivers/clk/sophgo/clk-cv18xx-pll.c:28:2: error: incompatible pointer types passing 'unsigned long *' to parameter of type 'uint64_t *' (aka 'unsigned long long *') [-Werror,-Wincompatible-pointer-types]
>
>Cheers,
>Conor.
>

Thanks for your test report, It seems that I have made some mistake while
splitting this patch. I have fixed this in the new one.

Regards,
Inochi.