DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=m7ftNolUKtXL+knVphfXgfGlhfTyLPaZBBUFqJrDog73G228wah2wMfr97/nokLzXFx6nb7/ar80uItaHzVZ7iuXaIa+PEvAkFC4c6RseO6YJ5yIWGuyFnyeXW3jjDoSZDdDLn2c+aQuHV2cHcOdFY8jQjPAN6VfqeyYKobwb94=
Message-ID: <8b67d60712230856o73bc89d7u142b93fc47b7533b@mail.gmail.com>
Date: Sun, 23 Dec 2007 16:56:14 +0000
From: "Adrian McMenamin" <lkmladrian@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Correct use of __init and __devinit
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1026
Lines: 27

Could someone here help settle this argument?

I have written a driver (for the CD Rom on the Sega Dreamcast). I have
marked various initialisation functions - including probe() and the
functions that it, and only it, calls, as __init.

Other developers tell me I should mark them as __devinit.

However I think this is wrong as:

* The CD on the Dreamcast is not and will never be a hotpluggable device

* The Dreamcast is a limited memory device and if marking various
functions as __init helps save memory that is A Good Thing

It has been put to me that while the use case (not hotpluggable) is
correct, it is still better practice to use __devinit

I have built the code with both __init and __devinit and both work, so
there is no issue of practicality as such here.

Adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/