Received-SPF: pass (google.com: domain of linux-kernel+bounces-63174-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0d8d8b85-1208-4021-b1f8-1c1c593ddbfe@phytec.de>
Date: Tue, 13 Feb 2024 10:05:46 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 8/9] arm64: dts: ti: k3-am6*: Fix bus-width property in
 MMC nodes
Content-Language: en-US
To: Francesco Dolcini <francesco@dolcini.it>
CC: Judith Mendez <jm@ti.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>, Vignesh Raghavendra
	<vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Francesco Dolcini
	<francesco.dolcini@toradex.com>
References: <20240213002416.1560357-1-jm@ti.com>
 <20240213002416.1560357-9-jm@ti.com>
 <c6ad3a3e-330c-40cd-8e25-fd259fd1e398@phytec.de>
 <20240213081953.GB3810@francesco-nb>
From: Wadim Egorov <w.egorov@phytec.de>
In-Reply-To: <20240213081953.GB3810@francesco-nb>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


Am 13.02.24 um 09:19 schrieb Francesco Dolcini:
> On Tue, Feb 13, 2024 at 06:07:28AM +0100, Wadim Egorov wrote:
>> Hi Judith,
>>
>> Am 13.02.24 um 01:24 schrieb Judith Mendez:
>>> Move bus-width property to *main.dtsi, above the OTAP/ITAP
>>> delay values. While there is no error with where it is
>>> currently at, it is easier to read the MMC node if the
>>> bus-width property is located above the OTAP/ITAP delay
>>> values consistently across MMC nodes.
>>>
>>> Add missing bus-width for MMC2 in k3-am62-main.
>>>
>>> Signed-off-by: Judith Mendez <jm@ti.com>
>>> ---
>>>    arch/arm64/boot/dts/ti/k3-am62-main.dtsi       | 5 +++--
>>>    arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 1 -
>>>    arch/arm64/boot/dts/ti/k3-am62a-main.dtsi      | 2 +-
>>>    arch/arm64/boot/dts/ti/k3-am64-main.dtsi       | 2 ++
>>>    arch/arm64/boot/dts/ti/k3-am642-evm.dts        | 2 --
>>>    arch/arm64/boot/dts/ti/k3-am642-sk.dts         | 1 -
>> I think you missed to update all non TI boards.
> Not sure which boards are you referring to.
>
> I would not change the verdin-am62 boards, the bus-width there is
> consistent with the schematics, it's just correct and in the right place
> IMO.

Ah, yes. Agree.


>
> Francesco
>