Received-SPF: pass (google.com: domain of linux-kernel+bounces-63192-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 13 Feb 2024 10:18:39 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
	ChiYuan Huang <cy_huang@richtek.com>,
	=?iso-8859-1?Q?Andr=E9?= Apitzsch <git@apitzsch.eu>,
	Alice Chen <alice_chen@richtek.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	ChiaEn Wu <chiaen_wu@richtek.com>, linux-kernel@vger.kernel.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver
Message-ID: <Zcsz7x1rXgYP3e7b@duo.ucw.cz>
References: <20240203175910.301099-1-alkuor@gmail.com>
 <20240203175910.301099-2-alkuor@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="pIcXbQiXcgKFKqs/"
Content-Disposition: inline
In-Reply-To: <20240203175910.301099-2-alkuor@gmail.com>


--pIcXbQiXcgKFKqs/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

>  .../sysfs-class-led-multicolor-driver-ncp5623 |  46 +++
>  drivers/leds/rgb/Kconfig                      |  11 +
>  drivers/leds/rgb/Makefile                     |   1 +
>  drivers/leds/rgb/leds-ncp5623.c               | 320 ++++++++++++++++++
>  4 files changed, 378 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor-=
driver-ncp5623
>  create mode 100644 drivers/leds/rgb/leds-ncp5623.c
>=20
> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-=
ncp5623 b/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp56=
23
> new file mode 100644
> index 000000000000..6b9f4849852b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor-driver-ncp5623
> @@ -0,0 +1,46 @@
> +What:		/sys/class/leds/<led>/direction
> +Date:		Feb 2024
> +What:		/sys/class/leds/<led>/dim_step

You are reinventing hardware_pattern trigger. NAK.

I suggest you add basic support first, then look at hardware pattern
trigger and add that support in separate patch.

Thanks,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--pIcXbQiXcgKFKqs/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZcsz7wAKCRAw5/Bqldv6
8ojFAJ9xenpCaeaaI2rONzaxvf3vOwURYQCgmCO+rVjSS3JO30mgiLqi40kQ0gY=
=Ijkc
-----END PGP SIGNATURE-----

--pIcXbQiXcgKFKqs/--