Received-SPF: pass (google.com: domain of linux-kernel+bounces-63193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1be60db1-f292-1074-5898-801380e1fb22@axentia.se>
Date: Tue, 13 Feb 2024 10:19:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v5] arm64: dts: ti: k3-j784s4-main: Fix mux-reg-masks in
 serdes_ln_ctrl
Content-Language: sv-SE
To: Siddharth Vadapalli <s-vadapalli@ti.com>, nm@ti.com, vigneshr@ti.com,
 kristo@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, afd@ti.com, gregkh@linuxfoundation.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, c-vankar@ti.com, srk@ti.com
References: <20240213080348.248916-1-s-vadapalli@ti.com>
From: Peter Rosin <peda@axentia.se>
In-Reply-To: <20240213080348.248916-1-s-vadapalli@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?REVmdUlQbUR2QzBwSVdCaWM1MGphaE9mTkZORVZWMlRKV3hITStMMUV4VmdJ?=
 =?utf-8?B?RXNQMVRsUG5uSnBhMEcyT0lxQkV2QVdsL2QrektzSWswSmhyKzFLUzZzTE5t?=
 =?utf-8?B?KzZMMEdOdDFqQk9OZDRDdjJDdWNReEtzNE5Pa3dORE54V3d2UGJ3T1Rmd1pl?=
 =?utf-8?B?eXNUUW5SaVpYMGwvd2VvUnB2Rm5Ob252cHF4elJySFQremVmdnRIQW94Vm1k?=
 =?utf-8?B?SlRLdTZ1a0VTUGc2b0VWWCtvOTVaQ1hpVm1NeEhGTWozbUN1QlY1WTRVMTI4?=
 =?utf-8?B?QS9sUGVTNkJEZG1RUUxVWWVlbHZxcG8wUHEyemRFcFpodjdySG93WnNHaU5y?=
 =?utf-8?B?dVNlRjl0UkhmOGdRSlBZNkpBbGp1RWZnQlg4S1dtZGxWb1RhazMxU3hEU2py?=
 =?utf-8?B?THIyeDZHM1l1cCtiQUU3ZmRrR1VqTk9LOHBPS1E3Z1k4V1ZnbG9WZENLVDBL?=
 =?utf-8?B?ZFJLdzduZ0RNWitTVGFldklYQjBVb2V5Yk52bEdNcUdrM0laSVRtQVFuc3BU?=
 =?utf-8?B?aXVyTnVSYXdDZjhaZ2RvSGY3UWI1b3JPLzI1T2Jrand2bW8yV3l2MU83Skdh?=
 =?utf-8?B?bVpaZU9oR1dZM0ExbEFtV3hSM0tzem45bUtib1FoRnFjZUdldTRHRFJrdE9U?=
 =?utf-8?B?bHYzbHFTZHBrdktyRTNzTjUzQWJDdHJuRkZsK0F3dytCVFRSdktWNVUyZDdk?=
 =?utf-8?B?Wld3cDBmKzR0Qi8valR2cEZaaEhpTnlNR3grKzhiNHBYTzdDelVyMUNqZFRv?=
 =?utf-8?B?eUVVeGFOM2RZZU1JZXVGYVlRZFhicXZDaXZIM2pFTmdBVG9hcjdRRDJnbFJt?=
 =?utf-8?B?TlZFcTJkemFkbUlBdzlFTXRHYkR6b0VUWUV1ODhOT0hGYVJqdkVSVzV6Q2NE?=
 =?utf-8?B?SzlvS2I3RzBUazRKR0Y5ZGp6alFFUUljbFJxdTRseTA3R1Q1M2FkM3VnVk5p?=
 =?utf-8?B?bUdKK05WNEdJRlRVZ1MzMTFlcDVnWGZ4U0pwb2RwRFRBcktwSVZUbnpXdHdw?=
 =?utf-8?B?azRrWEc3aVhXS1c2V2Q5SUdzVktENTJ4d0ZHeENWTFd5K3F3ampNNUgyb08x?=
 =?utf-8?B?U2h2MGN6QmpwTlkzRWhDR1ZFdUM2aFFoaWZJRnczRktFaHZ6RjF2M3FlWTZR?=
 =?utf-8?B?dkNHYlhXRmhhRE5Ybk1ydWNlQ1ZqeS9icUJ3elJMNEdzT2VnZDdRS1JOVGZy?=
 =?utf-8?B?MEpiM0FXMkZLU1F1MWE0VnA5R2RsWmlQSjlFNDhwU3Axb21vSjFsYXl5N3Rx?=
 =?utf-8?B?enpCUUdqT1VGYzZSeVozYnV2QS9XUmlKYTdYSTFVaVBtMFhUdEFIUnpJeUVq?=
 =?utf-8?B?SFZsVndiSDh6RXkvUERqRi9aSGpOS1dqa09SV2F4Z3JyaHlqNVZSTlZNWTVl?=
 =?utf-8?B?S2tveW9aTjFaNTNBYTVZeFB2dU02NzAwaGhreXdYeHZZbnFGdkN2R3krNTg1?=
 =?utf-8?B?MDlkNkFCaWRCNGpEclVWc1ZEZDRmdXlEMFB4UnRHZEQ4Y2t6R2txOTdjNHFa?=
 =?utf-8?B?alQ1TVNZdlNPT1J6aUdTcWxkNkZDekltSXRIMTQzOVREMUlUNWo5dGtsMVNX?=
 =?utf-8?B?Mmg0VURRWmx2S2theHY2blJvS05nRi9VUy9PNzZiWEN4d21maE1MLzFLKy94?=
 =?utf-8?B?N1g5bWprVlREYmZ4ZWxDY1B6bWg3U0srR0V2VFg5UE9hR1lvell0WXhSU2gv?=
 =?utf-8?B?SktBRlVTVmcreUFKVlMxRktFVjdlTHpiVkZTZzkvdEVtbVYyRVBGdGdPRXBu?=
 =?utf-8?B?bkxnNS82djU0cHNJdjMwcGhwMWo1RkRhU1lIMGEzTDBDY3RaN3hYMGlzRmp5?=
 =?utf-8?B?SmNLRUhmRjNoZ0duMzV4a3d0c0t6MWllSjVRNmNFdWRxeHNTM2p3elFEYjZK?=
 =?utf-8?B?VmF3cldqWldxT3NFejNlRXoyMHVRVENKdnlpbnYyYm9iNFdXSW1YNjB3Z293?=
 =?utf-8?B?clk3NTRidy9GZER3QnJlQ1F6aUJpcitiRkRadC9PZVRiekt2SUlDVWI0bElJ?=
 =?utf-8?B?eHRzc0dKMVlqdGxwb0REK1NqYW1aNEZpbFEveEJ3YkhvSUJlUkZ6TWROM3RU?=
 =?utf-8?B?VmxjVTRBNHE0aXZxVmJ5MUZ5S3RVOEVxZG44bHJzQ0oraGVjbjNYd2NJQUtj?=
 =?utf-8?Q?ljnd/r6FkoGmsJTDrSF//ngjL?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d8541cc-571a-458c-6467-08dc2c74d6f9
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB8500.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 09:19:11.6030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VBSoLN+g4CTvBZJzUABk3hy0f5aVuGath229GnbEB0Y+Mh/vkjLs7H6udQoTz57q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR02MB10723

Hi!

2024-02-13 at 09:03, Siddharth Vadapalli wrote:
> From: Chintan Vankar <c-vankar@ti.com>
> 
> Change offset in mux-reg-masks property for serdes_ln_ctrl node
> since reg-mux property is used in compatible.
> 
> Fixes: 2765149273f4 ("mux: mmio: use reg property when parent device is not a syscon")
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>
> Acked-by: Andrew Davis <afd@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
> Hello,
> 
> This patch is based on linux-next tagged next-20240213.
> The v4 of this patch is a part of the series at:
> https://lore.kernel.org/r/20240131101441.1362409-1-c-vankar@ti.com/
> 
> Since the v4 series mentioned above has open comments on the other
> patches in the series, this patch is being posted separately to unblock
> other dependent series which rely on the fix implemented by this patch.
> 
> Changes since v4:
> - Rebased patch on linux-next tagged next-20240213.
> 
> Regards,
> Siddharth.
> 
>  arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index 3cb964982792..3b7f0eca977b 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -52,12 +52,12 @@ serdes_ln_ctrl: mux-controller@4080 {
>  			compatible = "reg-mux";
>  			reg = <0x00004080 0x30>;
>  			#mux-control-cells = <1>;
> -			mux-reg-masks = <0x4080 0x3>, <0x4084 0x3>, /* SERDES0 lane0/1 select */
> -					<0x4088 0x3>, <0x408c 0x3>, /* SERDES0 lane2/3 select */
> -					<0x4090 0x3>, <0x4094 0x3>, /* SERDES1 lane0/1 select */
> -					<0x4098 0x3>, <0x409c 0x3>, /* SERDES1 lane2/3 select */
> -					<0x40a0 0x3>, <0x40a4 0x3>, /* SERDES2 lane0/1 select */
> -					<0x40a8 0x3>, <0x40ac 0x3>; /* SERDES2 lane2/3 select */
> +			mux-reg-masks = <0x0 0x3>, <0x4 0x3>, /* SERDES0 lane0/1 select */
> +					<0x8 0x3>, <0xc 0x3>, /* SERDES0 lane2/3 select */
> +					<0x10 0x3>, <0x14 0x3>, /* SERDES1 lane0/1 select */
> +					<0x18 0x3>, <0x1c 0x3>, /* SERDES1 lane2/3 select */
> +					<0x20 0x3>, <0x24 0x3>, /* SERDES2 lane0/1 select */
> +					<0x28 0x3>, <0x2c 0x3>; /* SERDES2 lane2/3 select */
>  			idle-states = <J784S4_SERDES0_LANE0_PCIE1_LANE0>,
>  				      <J784S4_SERDES0_LANE1_PCIE1_LANE1>,
>  				      <J784S4_SERDES0_LANE2_IP3_UNUSED>,

Ouch. I suspect there is a similar problem in
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi:


	fss: bus@47000000 {
		compatible = "simple-bus";
		reg = <0x0 0x47000000 0x0 0x100>;
		#address-cells = <2>;
		#size-cells = <2>;
		ranges;

		hbmc_mux: mux-controller@47000004 {
			compatible = "reg-mux";
			reg = <0x00 0x47000004 0x00 0x2>;
			#mux-control-cells = <1>;
-			mux-reg-masks = <0x4 0x2>; /* HBMC select */
+			mux-reg-masks = <0x0 0x2>; /* HBMC select */
		};

Who knows what non-upstreamed devices and devicetrees are affected?
I guess we need to revert 2765149273f4 ("mux: mmio: use reg property
when parent device is not a syscon") unless someone sees a sane way
to fix this.

Cheers,
Peter