Received-SPF: pass (google.com: domain of linux-kernel+bounces-63194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 13 Feb 2024 10:21:50 +0100
From: Oscar Salvador <osalvador@suse.de>
To: Marco Elver <elver@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH v8 4/5] mm,page_owner: Filter out stacks by a threshold
Message-ID: <Zcs0ruHxL9YOsKN_@localhost.localdomain>
References: <20240212223029.30769-1-osalvador@suse.de>
 <20240212223029.30769-5-osalvador@suse.de>
 <CANpmjNNWv1eDL5MQXtdXnsV=sCp_8MC11xBAgsNt_1K-V30H8Q@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANpmjNNWv1eDL5MQXtdXnsV=sCp_8MC11xBAgsNt_1K-V30H8Q@mail.gmail.com>

On Tue, Feb 13, 2024 at 09:44:47AM +0100, Marco Elver wrote:
> On Mon, 12 Feb 2024 at 23:29, Oscar Salvador <osalvador@suse.de> wrote:
> > +       debugfs_create_file("set_threshold", 0600, dir, NULL,
> > +                           &proc_page_owner_threshold);
> 
> Can't you also read from "set_threshold", so the name "set_threshold"
> is misleading. Why not just "threshold"?

Yes, it can also be read.
I guess I was too focused on the set part.
I will rename that one, plus add the {READ,WRITE}_ONCE.

Thanks!

-- 
Oscar Salvador
SUSE Labs