Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2942498rdb; Tue, 13 Feb 2024 01:50:16 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUJJ/PFnVdbwrx/y1k5Up3jOAI6CIzaaYhUS2NXRLbjd/rCkNBT/O04C3OLzsb00Cvyzk7YZTpPjF6k6ExyILY9Vkr98WKUMTWQ1pdJRA== X-Google-Smtp-Source: AGHT+IFtWlQMft73WA9k2W3rww8qpAQhQEvdM5wMZEcl8E4X+JLWdDqdDpLubVvc5JbnpkqQiM35 X-Received: by 2002:a17:90b:4f8e:b0:296:4e2f:a680 with SMTP id qe14-20020a17090b4f8e00b002964e2fa680mr3081003pjb.10.1707817815707; Tue, 13 Feb 2024 01:50:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707817815; cv=pass; d=google.com; s=arc-20160816; b=KnnNmpce9auaq9dIrhVPEqbvQ0KBVfTkGUjRV86zQGZKLd7L344hmkbF157giRFcpJ +yJjFhh+Xx3YRPzYy/xg9mrdr4M4a70SGujQdy8GPe2z/5LO9Oi4QebBjy97HTuVfIOX KRY/dOLTW501YTRJD85gangf37OY5mZxtWd+jO6Q053/3pesp8YoyYwE+LDb6o0o6uae HzylXJg7sWGbkXgud9u99JI4oLtsV+YFMGCAR5UwbRPhf0er6/zwfr4I/eZoR0amMNsW SI1dxi7Uy1pkAmQe94fTuCzI6KBcuEuzYei1fveaGIHZPGtTae8muDxeMj9Mip1ZdRNK Bljw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=OvMkuTAmZ2Y4I5mIeurgoX7p1vggpBUJZeCNdIuhqjI=; fh=2fOiOdWf/O4MM4SsVNAiQpMxz88IqFprqui7hRQEf50=; b=xWHMBunBzMhR8Gp2rf33les7FhGg21NTxOacSrR6uRCIDyF5lkqDpBulzLJbakLGvK e4mPNvMEWSd87KKYPMTC3ClR1vVZoPXEUqw5HkoPy2JWkrEVRR6IPGiGvUdKS9qyUzcG v2GhTaOXIbwcNaCkOh8K4kGhLJJhqYJvL9Om1Xl7mmDk/ERCR2vuUmX/elgmXsTfp0PV o/6plOX6qMXb8lSNvVGpAb1UrbqXdJrgDave6hxmJ4lptrtwMtJ+2ZzoCj5uj+nJXbtu hbcgbsVKnTekrfI79an53+deLNoKCUn/k3mgZ7uoZHa5M1RmLoku73r/gXxsyr4d+7gn jOJA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="A9/0Pdap"; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-63240-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63240-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev X-Forwarded-Encrypted: i=2; AJvYcCXayS9UKqsOEXsw7Z94H+a6ZDIcaAhYYtl70/ZDeZJggu1eOJtxnT8/mKkQYqZIqoFytP7lc49gjkm52im88wl9xLflb0taxtHUQW60mA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id eu15-20020a17090af94f00b0029705e96d0esi1811080pjb.117.2024.02.13.01.50.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 01:50:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63240-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b="A9/0Pdap"; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-63240-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63240-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 19AF728AAF5 for ; Tue, 13 Feb 2024 09:45:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90E5E249FE; Tue, 13 Feb 2024 09:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="A9/0Pdap" Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 591361E4A2 for ; Tue, 13 Feb 2024 09:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707817224; cv=none; b=eXC8o1sKJp3j1+h3EHAzFi5vihfgD27Yg/5e3sRH8ahjPmeicWtRKUvpT2YuNePOx7s9QjwM26iUZ4GIhFr1fkrhsbR1Ym7/26qEM4i9VueezdPYOV3HCaKLRaq25gMkMsMegrD8ZWM16W6EWIdsH2ttmogYr9OATSfwVBHBBfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707817224; c=relaxed/simple; bh=Hw7vNI2Kb24vC0nkaK7/5I/kAuFRQ3NHTOq4CoOcbhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SRcsZD2IKNWwjzUeFb6So1dU5+RjAEsoqBvuz2Rzm12bITGpajaqHA7tlgMsNsb/ooBy+R2CaVkS/XhpJyGiHZ9vOqH9Tf6jEdTZI9HBmGiuACD60jQqf1djZ38IUA1RiUgO8nQGU7q/8/+zJlO+JgvEZQEHl1XIfqv6hrc9FFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=A9/0Pdap; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707817221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvMkuTAmZ2Y4I5mIeurgoX7p1vggpBUJZeCNdIuhqjI=; b=A9/0Pdapfde4UMXWBuOSYEnsYs3XzXeTFT8/HtvInZYMXQGfoyHtP9GTyIEbV2KV6N5ZJf 1GzoPWM9GzgXptD4kKnxk5qSHY2zanY52NPwmDaJzKgsZSISUa26dRM3mo7RTWUFOcRMKa pXPEbI09FCmKKPQNM2lUj+U/uXTIovE= From: Oliver Upton To: kvmarm@lists.linux.dev Cc: kvm@vger.kernel.org, Marc Zyngier , James Morse , Suzuki K Poulose , Zenghui Yu , linux-kernel@vger.kernel.org, Oliver Upton Subject: [PATCH v2 16/23] KVM: arm64: vgic-its: Rely on RCU to protect translation cache reads Date: Tue, 13 Feb 2024 09:40:12 +0000 Message-ID: <20240213094012.3961447-1-oliver.upton@linux.dev> In-Reply-To: <20240213093250.3960069-1-oliver.upton@linux.dev> References: <20240213093250.3960069-1-oliver.upton@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Stop taking the lpi_list_lock when reading the LPI translation cache. Signed-off-by: Oliver Upton --- arch/arm64/kvm/vgic/vgic-its.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c index 55463eb84763..0e449f8c1f01 100644 --- a/arch/arm64/kvm/vgic/vgic-its.c +++ b/arch/arm64/kvm/vgic/vgic-its.c @@ -593,15 +593,14 @@ static struct vgic_irq *vgic_its_check_cache(struct kvm *kvm, phys_addr_t db, { struct vgic_dist *dist = &kvm->arch.vgic; struct vgic_irq *irq; - unsigned long flags; - raw_spin_lock_irqsave(&dist->lpi_list_lock, flags); + rcu_read_lock(); irq = __vgic_its_check_cache(dist, db, devid, eventid); if (!vgic_try_get_irq_kref(irq)) irq = NULL; - raw_spin_unlock_irqrestore(&dist->lpi_list_lock, flags); + rcu_read_unlock(); return irq; } -- 2.43.0.687.g38aa6559b0-goog