Received-SPF: pass (google.com: domain of linux-kernel+bounces-63266-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?utf-8?B?7J207Iq57Z2s?= <sh043.lee@samsung.com>
To: "'Avri Altman'" <Avri.Altman@wdc.com>, <linux-mmc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <ulf.hansson@linaro.org>,
	<gregkh@linuxfoundation.org>
Cc: <grant.jung@samsung.com>, <jt77.jang@samsung.com>,
	<dh0421.hwang@samsung.com>, <junwoo80.lee@samsung.com>,
	<jangsub.yi@samsung.com>, <cw9316.lee@samsung.com>,
	<sh8267.baek@samsung.com>, <wkon.kim@samsung.com>
In-Reply-To: <BL0PR04MB65642D0389544F022A1D2222FC4F2@BL0PR04MB6564.namprd04.prod.outlook.com>
Subject: RE: [PATCH] mmc: sd: Add a variable to check a faulty device
Date: Tue, 13 Feb 2024 18:49:45 +0900
Message-ID: <000101da5e61$f97e8cf0$ec7ba6d0$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQI2QrZr/hQwBfLmGOt++EZEApv72gJjevE2AlTbwFmwKnu8oA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20240213051332epcas1p1f45d02dc34d1b95ea5608ab779d6b6cc@epcas1p1.samsung.com>
	<20240213051716.6596-1-sh043.lee@samsung.com>
	<BL0PR04MB65642D0389544F022A1D2222FC4F2@BL0PR04MB6564.namprd04.prod.outlook.com>


> -----Original Message-----
> From: Avri Altman <Avri.Altman=40wdc.com>
> Sent: Tuesday, February 13, 2024 5:42 PM
> To: Seunghui Lee <sh043.lee=40samsung.com>; linux-mmc=40vger.kernel.org;
> linux-kernel=40vger.kernel.org; ulf.hansson=40linaro.org;
> gregkh=40linuxfoundation.org
> Cc: grant.jung=40samsung.com; jt77.jang=40samsung.com;
> dh0421.hwang=40samsung.com; junwoo80.lee=40samsung.com; jangsub.yi=40sams=
ung.com;
> cw9316.lee=40samsung.com; sh8267.baek=40samsung.com; wkon.kim=40samsung.c=
om
> Subject: RE: =5BPATCH=5D mmc: sd: Add a variable to check a faulty device
>=20
> > In mobile devices, suspend/resume situations are frequent.
> > In the case of a defective SD card in which initialization fails,
> > unnecessary initialization time is consumed for each resume.
> > A field is needed to check that SD card initialization has failed on
> > the host. It could be used to remove unnecessary initialization.
> I don't see where you are using this new init_failed field?
> Maybe instead, elaborate the logic to free_card: to detect a broken sd.
> e.g. instead of just if (=21oldcard), if (=21oldcard =7C=7C =21 mmc_sd_al=
ive(host))
> or something.
>=20
> Thanks,
> Avri
>=20
Thank you for your suggestion.
I'm going to use it in mmc_rescan as below.

e.g.
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index a8c17b=
4cd737..461cd75dc7ab 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
=40=40 -2210,7 +2210,7 =40=40 void mmc_rescan(struct work_struct *work)
                container_of(work, struct mmc_host, detect.work);
        int i;
=20
-       if (host->rescan_disable)
+       if (host->rescan_disable =7C=7C host->init_failed)
                return;
> >
> > Signed-off-by: Seunghui Lee <sh043.lee=40samsung.com>
> > ---
> >  drivers/mmc/core/sd.c        =7C 12 +++++++++++-
> >  drivers/mmc/core/slot-gpio.c =7C  1 +
> >  include/linux/mmc/host.h     =7C  1 +
> >  3 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index
> > c3e554344c99..f0eb3864dc24 100644
> > --- a/drivers/mmc/core/sd.c
> > +++ b/drivers/mmc/core/sd.c
> > =40=40 -1410,6 +1410,7 =40=40 static int mmc_sd_init_card(struct mmc_ho=
st
> > *host,
> > u32 ocr,
> >         bool v18_fixup_failed =3D false;
> >
> >         WARN_ON(=21host->claimed);
> > +       host->init_failed =3D false;
> >  retry:
> >         err =3D mmc_sd_get_cid(host, ocr, cid, &rocr);
> >         if (err)
> > =40=40 -1752,6 +1753,8 =40=40 static int _mmc_sd_resume(struct mmc_host=
 *host)
> >
> >         mmc_power_up(host, host->card->ocr);
> >         err =3D mmc_sd_init_card(host, host->card->ocr, host->card);
> > +       if (err)
> > +               host->init_failed =3D true;
> >         mmc_card_clr_suspended(host->card);
> >
> >  out:
> > =40=40 -1803,8 +1806,12 =40=40 static int mmc_sd_runtime_resume(struct
> > mmc_host *host)
> >
> >  static int mmc_sd_hw_reset(struct mmc_host *host)  =7B
> > +       int err;
> >         mmc_power_cycle(host, host->card->ocr);
> > -       return mmc_sd_init_card(host, host->card->ocr, host->card);
> > +       err =3D mmc_sd_init_card(host, host->card->ocr, host->card);
> > +       if (err)
> > +               host->init_failed =3D true;
> > +       return err;
> >  =7D
> >
> >  static const struct mmc_bus_ops mmc_sd_ops =3D =7B =40=40 -1891,5 +189=
8,8 =40=40
> > int mmc_attach_sd(struct mmc_host *host)
> >         pr_err(=22%s: error %d whilst initialising SD card=5Cn=22,
> >                 mmc_hostname(host), err);
> >
> > +       if (err)
> > +               host->init_failed =3D true;
> > +
> >         return err;
> >  =7D
> > diff --git a/drivers/mmc/core/slot-gpio.c
> > b/drivers/mmc/core/slot-gpio.c index
> > 2a2d949a9344..93d081c7dd53 100644
> > --- a/drivers/mmc/core/slot-gpio.c
> > +++ b/drivers/mmc/core/slot-gpio.c
> > =40=40 -33,6 +33,7 =40=40 static irqreturn_t mmc_gpio_cd_irqt(int irq, =
void
> *dev_id)
> >         struct mmc_gpio *ctx =3D host->slot.handler_priv;
> >
> >         host->trigger_card_event =3D true;
> > +       host->init_failed =3D false;
> >         mmc_detect_change(host,
> > msecs_to_jiffies(ctx->cd_debounce_delay_ms));
> >
> >         return IRQ_HANDLED;
> > diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index
> > 2f445c651742..1d75cfdbf981 100644
> > --- a/include/linux/mmc/host.h
> > +++ b/include/linux/mmc/host.h
> > =40=40 -467,6 +467,7 =40=40 struct mmc_host =7B
> >         struct timer_list       retune_timer;   /* for periodic re-tuni=
ng */
> >
> >         bool                    trigger_card_event; /* card_event neces=
sary */
> > +       bool                    init_failed;    /* check if failed to
> initialize */
> >
> >         struct mmc_card         *card;          /* device attached to t=
his host
> */
> >
> > --
> > 2.29.0