Received-SPF: pass (google.com: domain of linux-kernel+bounces-63269-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6c7dc71c-9251-4c84-a134-82104b5f924e@quicinc.com>
Date: Tue, 13 Feb 2024 15:21:09 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] soc: qcom: rpmh-rsc: Enhance check for VRM in-flight
 request
To: Mukesh Ojha <quic_mojha@quicinc.com>,
        Subbaraman Narayanamurthy
	<quic_subbaram@quicinc.com>
CC: <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_collinsd@quicinc.com>, <quic_eberman@quicinc.com>,
        <quic_lsrao@quicinc.com>, <stable@vger.kernel.org>
References: <20240212-rpmh-rsc-fixes-v3-1-1be0d705dbb5@quicinc.com>
 <20240213035203.2492516-1-quic_subbaram@quicinc.com>
 <9ad7967f-0a6a-96ed-1433-832f76752059@quicinc.com>
Content-Language: en-US
From: "Maulik Shah (mkshah)" <quic_mkshah@quicinc.com>
In-Reply-To: <9ad7967f-0a6a-96ed-1433-832f76752059@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 2/13/2024 11:24 AM, Mukesh Ojha wrote:
> 
> 
> On 2/13/2024 9:22 AM, Subbaraman Narayanamurthy wrote:
>> Hi Maulik,
>>
>>> +bool cmd_db_match_resource_addr(u32 addr1, u32 addr2)
>>> +{
>>
>> <snip>
>>
>>> +    if (SLAVE_ID(addr1) == CMD_DB_HW_VRM
>>> +        && VRM_ADDR(addr1) == VRM_ADDR(addr2))
>>> +        return true;
>>> +    else if (addr1 == addr2)
>>> +        return true;
>>> +    else
>>> +        return false;
>>
>> Minor..it would be better if you modify it as following.
>>
>> +    if (addr1 == addr2)
>> +        return true;
>> +    else if (SLAVE_ID(addr1) == CMD_DB_HW_VRM
>> +        && VRM_ADDR(addr1) == VRM_ADDR(addr2))
>> +        return true;
>> +
>> +    return false;
> 
> Even better if it becomes one statement for true rest with
> false..

Thanks for the review.

I will fix in v4, will wait for sometime if there are any other comments 
to take care along with this.

Thanks,
Maulik