Received-SPF: pass (google.com: domain of linux-kernel+bounces-63295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Stefan Binding <sbinding@opensource.cirrus.com>
To: 'Tomasz Kudela' <ramzes005@gmail.com>
CC: <alsa-devel@alsa-project.org>, <andy.chi@canonical.com>,
        <david.rhodes@cirrus.com>, <james.schulman@cirrus.com>,
        <kailang@realtek.com>, <linux-kernel@vger.kernel.org>,
        <linux-sound@vger.kernel.org>, <luke@ljones.dev>,
        <patches@opensource.cirrus.com>, <perex@perex.cz>,
        <rf@opensource.cirrus.com>, <ruinairas1992@gmail.com>,
        <shenghao-ding@ti.com>, <tiwai@suse.com>,
        <vitalyr@opensource.cirrus.com>
References: <20240212193327.59507-1-ramzes005@gmail.com> <20240213082116.15049-1-ramzes005@gmail.com>
In-Reply-To: <20240213082116.15049-1-ramzes005@gmail.com>
Subject: RE: [PATCH v2] Add Lenovo Legion 7i gen7 sound quirk
Date: Tue, 13 Feb 2024 10:00:03 +0000
Message-ID: <000101da5e63$6a2565e0$3e7031a0$@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Language: en-gb
Thread-Index: AQL5cxh77Ymk4rKL11VQD0BqvrFTygGP9Uvorr1f3IA=

Hi,

> -----Original Message-----
> From: Tomasz Kudela <ramzes005@gmail.com>
> Sent: Tuesday, February 13, 2024 8:21 AM
> To: ramzes005@gmail.com
> Cc: alsa-devel@alsa-project.org; andy.chi@canonical.com;
> david.rhodes@cirrus.com; james.schulman@cirrus.com;
> kailang@realtek.com; linux-kernel@vger.kernel.org; linux-
> sound@vger.kernel.org; luke@ljones.dev;
> patches@opensource.cirrus.com; perex@perex.cz;
> rf@opensource.cirrus.com; ruinairas1992@gmail.com;
> sbinding@opensource.cirrus.com; shenghao-ding@ti.com;
> tiwai@suse.com; vitalyr@opensource.cirrus.com
> Subject: [PATCH v2] Add Lenovo Legion 7i gen7 sound quirk
> 
> From: "T. Kudela" <ramzes005@gmail.com>
> 
> Add sound support for the Legion 7i gen7 laptop (16IAX7).
> 
> Signed-off-by: Tomasz Kudela <ramzes005@gmail.com>
> ---
>  sound/pci/hda/cs35l41_hda_property.c | 2 ++
>  sound/pci/hda/patch_realtek.c        | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> index d74cf11eef1e..8a6b484b2184 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -95,6 +95,7 @@ static const struct cs35l41_config
> cs35l41_config_table[] = {
>  	{ "10431F12", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4500, 24 },
>  	{ "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, -1, 0, 0, 0, 0 },
>  	{ "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 0, 0, 0 },
> +	{ "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 0, 0, 0 },

I don't believe this laptop has a Speaker ID, so this configuration
should be:

{ "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0,
-1, -1, 0, 0, 0 },

Thanks,
Stefan

>  	{ "17AA38B4", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 0, 0, 0 },
>  	{ "17AA38B5", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 0, 0, 0 },
>  	{ "17AA38B6", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 0, 0, 0 },
> @@ -431,6 +432,7 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] = {
>  	{ "CSC3551", "10431F12", generic_dsd_config },
>  	{ "CSC3551", "10431F1F", generic_dsd_config },
>  	{ "CSC3551", "10431F62", generic_dsd_config },
> +	{ "CSC3551", "17AA386F", generic_dsd_config },
>  	{ "CSC3551", "17AA38B4", generic_dsd_config },
>  	{ "CSC3551", "17AA38B5", generic_dsd_config },
>  	{ "CSC3551", "17AA38B6", generic_dsd_config },
> diff --git a/sound/pci/hda/patch_realtek.c
> b/sound/pci/hda/patch_realtek.c
> index 6994c4c5073c..0029f61d4693 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10260,6 +10260,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x3853, "Lenovo Yoga 7 15ITL5",
> ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
>  	SND_PCI_QUIRK(0x17aa, 0x3855, "Legion 7 16ITHG6",
> ALC287_FIXUP_LEGION_16ITHG6),
>  	SND_PCI_QUIRK(0x17aa, 0x3869, "Lenovo Yoga7 14IAL7",
> ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> +	SND_PCI_QUIRK(0x17aa, 0x386f, "Legion 7i 16IAX7",
> ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x17aa, 0x3870, "Lenovo Yoga 7 14ARB7",
> ALC287_FIXUP_YOGA7_14ARB7_I2C),
>  	SND_PCI_QUIRK(0x17aa, 0x387d, "Yoga S780-16 pro Quad AAC",
> ALC287_FIXUP_TAS2781_I2C),
>  	SND_PCI_QUIRK(0x17aa, 0x387e, "Yoga S780-16 pro Quad YC",
> ALC287_FIXUP_TAS2781_I2C),
> --
> 2.34.1
>