Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2953322rdb; Tue, 13 Feb 2024 02:17:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGX7bZNlewajcqp2tcYIA/FGMgd//Keyq8zzH4wiH0w5slI4sbJpUAc0yipzTQUaQwGmn8K X-Received: by 2002:a17:902:d4d1:b0:1da:2216:f227 with SMTP id o17-20020a170902d4d100b001da2216f227mr9113166plg.25.1707819427242; Tue, 13 Feb 2024 02:17:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707819427; cv=pass; d=google.com; s=arc-20160816; b=xYL5oJizY8izLyRwIhYGmJ0P/myjhEBOdBBJZC1ghyCN3glsgCyFnxocPC2W4074C/ 7Doba+X8mDK2Z8ZYIq/6wpuyUftyEh+2JWT9oFuw9dXOvMS5GuGcmwb7GvoCD8MVxXlx cUNdguIUeIHQuUiZ/WjyiFUzLHk9BdyQbhd/vUTYgjaURy5s16iBmNAC7XOSkhAr9YZJ Spzv0WYYzp9FMPLCMaxBUODizuYa73edUZiB4GiVYe4NNBKjDyrEo5WsWqRAoTF7l2yz S7+kWbv9hMUee0djY4SDvPFZIzXNQH6LW/mnaDTizIG7iN5rqI7aYqEAE3p852XoRfJq AuXg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=r10Uy9ySRh0hzDZGejebhY55a1QrOEs0Pc+wu7+8ezI=; fh=j9IDbA597v+MMZ1vwfyb3xPa1Nl8uik2b8kOu501npY=; b=w2ldWbijELuFUXCOTQC1kPuvkP94xAMlw0ldX1w21xk52YdeN6gRI9FgYBjrKClB/O SSuoPLA24HRjfRH9FtNc6hrcI5/pdDBEYrxEQzMxabkzzo6Yqpu319oh7+YVGZR1iuXK PjyXLQjDFm1DL4ukNKNTU2cODWYa25vKx9ywpFrLISmuU/osTrPKlI6AAgSqrD3s87TP ywHIejANBr6zL6asKqyUk7rzfhw3gyCEiVwivWiqoaEg7EeI/UEGgmwo3j4b43H6k11J Q2b9vQpOb2rlUdx4lE2gh+anCra2v2p8lMSGQNK1BgWm5T7ff5pdfdHg3xggvxzz3jfR E+hQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=U+Da2rWn; dkim=neutral (no key) header.i=@linutronix.de; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-63310-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63310-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de X-Forwarded-Encrypted: i=2; AJvYcCWs+ECcaCL68xTQTGYBHNYHqrGswyQwBF1Lu1sW0stMcn7gvwRDYD/rE8XdBih/GPSEfn9Y4UUoM9yHlm3yUhac2dZ2Jng8U7aWcPo/lA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e9-20020a170902d38900b001da327706efsi1747732pld.642.2024.02.13.02.17.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 02:17:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63310-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=U+Da2rWn; dkim=neutral (no key) header.i=@linutronix.de; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-63310-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63310-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ABEAC283B31 for ; Tue, 13 Feb 2024 10:09:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 16B8223755; Tue, 13 Feb 2024 10:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="U+Da2rWn"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="p1U5ZyxP" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E606222EFB for ; Tue, 13 Feb 2024 10:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707818964; cv=none; b=ACEu0pio8PLIc9xZBVp0ml+RYLYGhxbIq2taXhrQU8FCoT3k4icW3/3D+2KIKeZLbikzB5+xA7cDDpM3M1ncM9bRcJ+7WiqoLK81Muy4tca40F7A4TMMVNwyeu5G3ilHpHav9NSfTa87NEq+lVxun9oR5HP7xqJmltyM4qJrD9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707818964; c=relaxed/simple; bh=GphGXcfPeV1w271bwB6kiGkWJYOz7jfSvTvrlYgE2jY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=BUmdFAh09k9MR2bsIw9kVxpIrisOy3k19iYPnhmSRdpmH754FaZX8QoL5J00yT+qzIkE+cqHqqGvQKeabPJePL59Z0PEbLP5OMEyzw1vQNLmoCSLd6zOAOF7saet0ORI9ToabhOmb60IgfhRODiBZPN5a0RGpXJL4yabEOP/r7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=U+Da2rWn; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=p1U5ZyxP; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1707818961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r10Uy9ySRh0hzDZGejebhY55a1QrOEs0Pc+wu7+8ezI=; b=U+Da2rWn+XlWbUMFsbOkiy8/EDCRTdu/Zt9TtFMb0NzA6yGSsyGBpYnGbcSMZ1ulPmr5Kj Cfhw9WPLh50qQelEnJ3q9CdVefCjUeEiPvejMgxT1WY/o9gfkwqDgpbi43zY3iAAJyH+vK XnT4scjRWhi1CrGpimj4BnRtz6oW9sCVeKIPRgB8ygABslNW3U4YCQJ+yag9DvhICO63EF MPiVzh8B8cHHd6mmfr/BHFKizBnzHf7/XskkkAHNnwTsyG/71/dYgIVQm5yrN41j10tmL6 8VhhdASX4a5MVWpFTVMRMLuFiqAG7jOdCTndLRgRnqQeczErva572xV/rSkUqw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1707818961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r10Uy9ySRh0hzDZGejebhY55a1QrOEs0Pc+wu7+8ezI=; b=p1U5ZyxPfubsoGlhytTtxb0wNNASHLV0lGVTRoRhPYlDm+FyaSncM9KjgDhk6+5OCeD9k8 1ZtvlM67/z35RIBQ== To: Chen Jun , linux-kernel@vger.kernel.org Cc: xuqiang36@huawei.com, chenjun102@huawei.com Subject: Re: [PATCH] irqchip/mbigen: Fix incorrect null pointer check In-Reply-To: <20240129130003.18181-1-chenjun102@huawei.com> References: <20240129130003.18181-1-chenjun102@huawei.com> Date: Tue, 13 Feb 2024 11:09:21 +0100 Message-ID: <874jecisku.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Jan 29 2024 at 21:00, Chen Jun wrote: That's not about an incorrect NULL pointer check. That's about using a function which is guaranteed to return NULL on your platform, no? > bus_get_dev_root(&platform_bus_type) always returns NULL. Lacks an explanation why this always returns NULL. Thanks tglx