Received-SPF: pass (google.com: domain of linux-kernel+bounces-63341-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
Precedence: bulk
MIME-Version: 1.0
Message-Id: <3c76ba23-e4d7-49b0-b53c-b60772a25891@app.fastmail.com>
In-Reply-To: <20240213102139.gnfh5sq24rwu7wnp@quack3>
References: <20240213101733.461544-1-arnd@kernel.org>
 <20240213102139.gnfh5sq24rwu7wnp@quack3>
Date: Tue, 13 Feb 2024 11:26:57 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jan Kara" <jack@suse.cz>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Jan Kara" <jack@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] quota: avoid printing an uninitialized blk number
Content-Type: text/plain

On Tue, Feb 13, 2024, at 11:21, Jan Kara wrote:
> On Tue 13-02-24 11:17:28, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> The error path of find_tree_dqentry() now prints a variable that is
>> never initialized:
>> 
>> fs/quota/quota_tree.c:674:8: error: variable 'blk' is uninitialized when used here [-Werror,-Wuninitialized]
>>                             blk);
>>                             ^~~
>> include/linux/quotaops.h:34:41: note: expanded from macro 'quota_error'
>>         __quota_error((sb), __func__, fmt , ## args)
>>                                                ^~~~
>> 
>> Move the calculation of the block number slightly up to make it
>> show a sensible number.
>> 
>> Fixes: 223bfb57631b ("quota: Detect loops in quota tree")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Arnd, this should be fixed in my tree as of yesterday and I can see that
> you've even based your patch on a fixed kernel :)

Right, sorry about that. I did a lot of fixes yesterday and
sent them out after making sure they did not cause any new
failures in an overnight test build, but did not check carefully
during rebasing.

     Arnd