Received-SPF: pass (google.com: domain of linux-kernel+bounces-63351-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 13 Feb 2024 11:22:49 +0100
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Srinivas Goud <srinivas.goud@amd.com>
Cc: wg@grandegger.com, davem@davemloft.net, edumazet@google.com, 
	kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, p.zabel@pengutronix.de, git@amd.com, 
	michal.simek@xilinx.com, linux-can@vger.kernel.org, netdev@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v7 0/3] can: xilinx_can: Add ECC feature support
Message-ID: <20240213-evasion-crevice-3faa375c1666-mkl@pengutronix.de>
References: <1705059453-29099-1-git-send-email-srinivas.goud@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gdjgd3yxfo6av4wq"
Content-Disposition: inline
In-Reply-To: <1705059453-29099-1-git-send-email-srinivas.goud@amd.com>


--gdjgd3yxfo6av4wq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 12.01.2024 17:07:30, Srinivas Goud wrote:
> Add ECC feature support to Tx and Rx FIFOs for Xilinx CAN Controller.
> ECC is an IP configuration option where counter registers are added in
> IP for 1bit/2bit ECC errors count and reset.
> Also driver reports 1bit/2bit ECC errors for FIFOs based on ECC error
> interrupts.
>=20
> Add xlnx,has-ecc optional property for Xilinx AXI CAN controller
> to support ECC if the ECC block is enabled in the HW.
>=20
> Add ethtool stats interface for getting all the ECC errors information.
>=20
> There is no public documentation for it available.

Lately I was using ethtool based stats, too and figured out, there's no
need for a spinlock, you can use a struct u64_stats_sync,
u64_stats_update_begin(), u64_stats_update_end(), and
u64_stats_fetch_retry() instead. These are no-ops on 64 bit systems and
sequential locks on 32 bit systems.

I'll send a v8.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--gdjgd3yxfo6av4wq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUEC6huC2BN0pvD5fKDiiPnotvG8FAmXLQvYACgkQKDiiPnot
vG+qHQf/UZHyFLWV/VOz8X/KqbOqWwP/m96D8DaOwwA04EDyPmCvISlHmrj5hF5O
wDxmUFZ61KUxSOXG6MByDeRexI4FhZ3qcPH9PTgvMEBJy2PbgKfPS3g3JyBhHwgD
KNebyOcqEavo5NqiWU9pXQ6K8psAzKARfI4pwxuIrw2CZgmsDAQMdb3G5SkWTrcw
8eOR/dBSj+woJZc0OLe1dAbOt1lwZbC0AqhIGDPjjFnKxtyr0gQzr8JM+dR/0FQj
Xya5oBr1gMfcSfbmXc+bLrIAkry0xFsZjvoUuZT423Usd/N80Qd8RGpgH5E5g8s2
2o49spZNWnZ4AeBf/pkoU6TA8Wldew==
=kgLF
-----END PGP SIGNATURE-----

--gdjgd3yxfo6av4wq--