Received-SPF: pass (google.com: domain of linux-kernel+bounces-63352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <36b813ad-fdcb-495b-9d27-3573b6177831@wolfvision.net>
Date: Tue, 13 Feb 2024 11:36:25 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/7] usb: misc: onboard_hub: rename to onboard_dev
Content-Language: en-US
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
 Matthias Kaehlcke <matthias@kaehlcke.net>
References: <20240206-onboard_xvf3500-v3-0-f85b04116688@wolfvision.net>
 <20240206-onboard_xvf3500-v3-1-f85b04116688@wolfvision.net>
 <ZcJynrwp7zcs-aIT@google.com>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <ZcJynrwp7zcs-aIT@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ejIzdVRTTkhmbVRyd2o0a0YwMzJab1kvTXJsNmRRRDJ0RGNKa3dKa05kQTlu?=
 =?utf-8?B?RG1HelhnR216WG9ydjRrL01kbVpOS05BZWltRFRCU1RLUGRtcmhwMklvWHpm?=
 =?utf-8?B?VDR2OWltamt6d1h1b0FudUNyYVBsdE5mZEJsOUw3NnBTT0pYcW0yVE5YSFdp?=
 =?utf-8?B?UGs3eEFvU1Y0M0h6cEhFQjE5ZnpWNWt2VElwYnRBeXg2ek9zY21xNFN5ZXRU?=
 =?utf-8?B?eStVTGNmN0Y5WmhiVS9qOGRLWWRWdHZwRExPSlFNblEyNmhKSlpNNGVENU52?=
 =?utf-8?B?OTFHZHJBS2krdE5za3g5dkthZ3VZQ1p6Z2thQTVQZTQycHdZNmdaNTh0NU80?=
 =?utf-8?B?NGYxNW03YjhRQTRaZVdRelpUdVBvT25TeGhySzBwNWpYRWR2cUJQUnYrbDUv?=
 =?utf-8?B?cG4xYVZRQndHMGZaSGI4eFFXSGxTbVAxQStRaGMvbWliN3pydjRjTytLQjds?=
 =?utf-8?B?WDhWQUlPOUhVVm1vSzI1TmVUY3owWGlOWVJYVzUvUXhoa2x5OUdqcFZRNXJK?=
 =?utf-8?B?WHB0bzVCTGN1NnljMnpaZy9zTWxiMmZlSC9DdWtEUVpDREZXeU1tVTR2MVFX?=
 =?utf-8?B?MFRkR1lWS3NlME0vNG1OSmJGemh0aUNYMGp4MkJKU2pLanV1ZTNnajFob2ZK?=
 =?utf-8?B?OHhreUxaOTcyaWo3UDdvTDJ0d0lsTWhLeWNvaklXV2w4WCtXVzVCL0czZ29m?=
 =?utf-8?B?VDliMk1OSG5qMEEzeGJQSDNLYnN5UzN2RThLUU9HSjVVbVgvTzUvMUtWZ3Vo?=
 =?utf-8?B?OVZSNTAwc2luNTd1YzlZdktrSEo1YUdXSFU4UDZaeVpYUWswNHBXaHZXdmtZ?=
 =?utf-8?B?T2p4NU5TN01LcjYySHRqNXMvQ3Y2N0swYmovcDRDZEpnSjVaY3piV2dwWjBq?=
 =?utf-8?B?WmxtOVM5Vjc1d1U5UktwYWtZR2xzN3R4UHdJTElSUmlKWkc5Q1YrWDUwNXpE?=
 =?utf-8?B?UTlCdzM3K1dhNUN6SWNSaFRKZXRWQVNiclVTU25PcEhOVVN6Rm4zUXVaNjds?=
 =?utf-8?B?dStRRHk0cFNmOHVMOXIrcVlqVmpMUXJFZjdoTEdvTFV3NXMrakllYVh1Zjhi?=
 =?utf-8?B?MEkwWDAyTk5JRlNSOTJhT0dHeW5GTFkxQ3VxWXM5QkFVWVdGQ2ZSK2F0bWkz?=
 =?utf-8?B?emxwMjl1V2d1Z2lNNnFKQWZWUXgvaGhUTWVucGhnSVR4Sm9MTUl5alBtSU9w?=
 =?utf-8?B?WDNoN0RFb3lUc2M1SndMdGhkUVk1ZTNKY1ovZEYwbXkxZUpqVnpzc2RpK2c1?=
 =?utf-8?B?TmYvL3NHeXREcGx0OXpwTVZvclhOK0JqRk80QjJsVVhPQkowSmhLdStxb043?=
 =?utf-8?B?dVIzVTF2NTJISEFyNjU5aXFObm1sZjhOc2h2d3FpeDhsWjZMNzB5WDRtd215?=
 =?utf-8?B?R1lCTWdMVFROV2MvYnZnNlU0WEpWY09OeVhDZWhoMXRtM2JLK0taQkhYeG92?=
 =?utf-8?B?K1ZtSFdvR2FRU0g0UmtPVVRrVXlEK3JJMG14N2MxR2krQzY3a3VsQmh6YWxT?=
 =?utf-8?B?ZUxpM1o0SVQ1LzVFUUlOL1JLLzZsTlpPTCt5eWJHWHlsdStnWEZsbXRucHU4?=
 =?utf-8?B?RGZ1ajdINFVvKytpMnh6d2FLTHcwdE5LT3JoNnE3RmdWRk9FUWRJSE9OcWFC?=
 =?utf-8?B?RFdGNjlTMWVaNFdxQ0grZW9YMWk4amJNb1NIUURheEpvNUtQTUFUek5jSm55?=
 =?utf-8?B?VmN1a2RIUjBHRE9sNXo5NDZob3hSa2I4a2MrTDRNeUQ2NXBCdDFraVlDaHQ1?=
 =?utf-8?B?Q2ZuQWZWbGc2dWc4VHdWZFNTMUN3ZzFYRzVkZWZtaFhvTG9xVWV2Z25aUzk4?=
 =?utf-8?B?NFZvUGdsQUNaYy9WNDBTcXJYUGFLTUZMSlBZanlzVENMQWhiRHVuYWVQbjM2?=
 =?utf-8?B?emdvMjh6T3lCL3VIRzVBMXFNY2tHUUpGcU9KbENoV2U1a01UbDlEVWx6cTE2?=
 =?utf-8?B?WkRIREU4WmU2Zk1GN0FacHhZc2tJTkdqZzh1OXZ5T1FHOW5CMTkraGUyUDNa?=
 =?utf-8?B?cTFxMm5Ed0tWZGxtQTlvTlhZdzVYRlNRQjA3S3I0MnlPZUFwZHJLVURWaGJI?=
 =?utf-8?B?TVE2MFVsYjVKeHpOWEt0ZGhQRHhDZ3hLWU1VQjF6N080SDAwZTVoQmxUd0lJ?=
 =?utf-8?B?dlpjdW1VWmhSWko0ZURKM1pIdGp2NmdhaEYyWERRemJxZzMvbld3Y0JjSUdT?=
 =?utf-8?Q?6yxN1AEN4oBkxgZtybQzwKg=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 263a7a03-1672-4feb-0c3b-08dc2c7fa1e6
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 10:36:26.9553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: njt+9cwpukEYG9s5Ad6KLwVGi6b7UXKQNp6ylSxAG6VrEZWp2UxoDobvkF4PN2jR2Vc32q8jhjQigwXKArtifoYpiDR3y3BGIfs8yQxJM/8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5890

Hi Matthias,

On 06.02.24 18:55, Matthias Kaehlcke wrote:
> Hi Javier,
>
> a few comments inline
>
> On Tue, Feb 06, 2024 at 02:59:29PM +0100, Javier Carrasco wrote:
>> +static struct onboard_dev *_find_onboard_dev(struct device *dev)
>> +{
>> +	struct platform_device *pdev;
>> +	struct device_node *np;
>> +	struct onboard_dev *onboard_dev;
>> +
>> +	pdev = of_find_device_by_node(dev->of_node);
>> +	if (!pdev) {
>> +		np = of_parse_phandle(dev->of_node, "peer-hub", 0);
>> +		if (!np) {
>> +			dev_err(dev, "failed to find device node for peer hub\n");
>> +			return ERR_PTR(-EINVAL);
>> +		}
>> +
>> +		pdev = of_find_device_by_node(np);
>> +		of_node_put(np);
>> +
>> +		if (!pdev)
>> +			return ERR_PTR(-ENODEV);
>> +	}
>
> The above branch should probably be guarded by 'if (!onboard_dev->pdata->is_hub)',
> this is also a change for ""usb: misc: onboard_dev: add support for non-hub devices"
>
I am not sure how to guard the branch like that because onboard_dev is
retrieved by means of pdev->dev, which is not available if
of_find_device_by_node returns NULL. The non-hub device will not have a
peer-hub property according to its bindings anyway, right?

Thanks again for your feedback and best regards,
Javier Carrasco