Received-SPF: pass (google.com: domain of linux-kernel+bounces-63364-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 13 Feb 2024 05:41:48 -0500
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>,
	Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
	Zhangjin Wu <falcon@tinylab.org>, Willy Tarreau <w@1wt.eu>,
	Yuan Tan <tanyuan@tinylab.org>
Subject: Re: [PATCH RFC] misc/pvpanic: add support for normal shutdowns
Message-ID: <20240213053953-mutt-send-email-mst@kernel.org>
References: <20231104-pvpanic-shutdown-v1-1-5ee7c9b3e301@weissschuh.net>
 <2023110407-unselect-uptight-b96d@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023110407-unselect-uptight-b96d@gregkh>

On Sat, Nov 04, 2023 at 02:05:02PM +0100, Greg Kroah-Hartman wrote:
> > diff --git a/include/uapi/misc/pvpanic.h b/include/uapi/misc/pvpanic.h
> > index 54b7485390d3..82fc618bfbcf 100644
> > --- a/include/uapi/misc/pvpanic.h
> > +++ b/include/uapi/misc/pvpanic.h
> > @@ -5,5 +5,6 @@
> >  
> >  #define PVPANIC_PANICKED	(1 << 0)
> >  #define PVPANIC_CRASH_LOADED	(1 << 1)
> > +#define PVPANIC_SHUTDOWN	(1 << 2)
> 
> Why are these in a uapi file?
> 
> And if they need to be here, why not use the proper BIT() macro for it?
> 
> thanks,
> 
> greg k-h

This is interface with hypervisor not userspace, but for PV historically
we do this since the compatibility implications are about the same,
hypervisors (e.g. QEMU) are mostly userspace and so it is convenient for
them to reuse the same machinery to export the headers.

Let's stick to that, cleaner than duplicating everything I think.

-- 
MST