Received-SPF: pass (google.com: domain of linux-kernel+bounces-63325-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <b361fa3e-d880-4755-96e0-ada89613edef@intel.com>
Date: Tue, 13 Feb 2024 11:14:29 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 1/7] dma: compile-out DMA sync op calls when
 not used
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Marek Szyprowski <m.szyprowski@samsung.com>, "Robin
 Murphy" <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>, Will Deacon
	<will@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael
 J. Wysocki" <rafael@kernel.org>, Magnus Karlsson <magnus.karlsson@intel.com>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>, Alexander Duyck
	<alexanderduyck@fb.com>, <bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
	<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <20240205110426.764393-1-aleksander.lobakin@intel.com>
 <20240205110426.764393-2-aleksander.lobakin@intel.com>
 <20240213055707.GB22451@lst.de>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20240213055707.GB22451@lst.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1o0TXF4L3JlaG5lNFl1S1c0cmNSbzhmVlNoVFlHb2NVRk9XYkcxVHJXUGpR?=
 =?utf-8?B?UHJzVUtpeFpsbUJjeEJQQzIxR05heXhBNndvS1lGeTcyaFZzVmhjYnhOT3c0?=
 =?utf-8?B?enphN0wybVd2bXVGZnk2Qkd2akNCMnBqZ1RjOW1QZHRiQVhNem05QUt6WHBV?=
 =?utf-8?B?YkdEQ1dJQk1YaEg0M2ZWSUtmR1ZDV0RLUkgyNlpxbjY1Q2hGSHFvUzV2ck5x?=
 =?utf-8?B?UWkreTE1bHdzWXRiSmpmYWZpTDVJU2QrdWhselRsd0R0N2VhNSswNC94Q1Vq?=
 =?utf-8?B?U2E0YXFzTjFKUWJaR3ZwdzBHaEhwWkFvT2U2ZEN1aFA2cWNYWUpwa1hpVmxa?=
 =?utf-8?B?VloydTEzcTRUZmY3TXFVS0hvWHJ1OEFzOVp0K1RudWxJWkpRNERTR3o1ZjU2?=
 =?utf-8?B?bDFQcXZxU24wU21JYjJkK0x0eGp4WVNGNHJCK3VYUngvcTU3MDRPMXp2bVJR?=
 =?utf-8?B?djIvSHZwMHk3YUtqQzYyRG5FaFk3a1djY0I1STJobEVTcW9weHg0NHlaYzNz?=
 =?utf-8?B?MTQ0VkM0ZWNDZDQwNk9GL1lQSnRDWVl4K1FsR3BOdWlWSUJUUWdUVFVsRWQ5?=
 =?utf-8?B?OEFid04rWVdSL0N6aDFMS21OVGFkcjNkVWZQdDdVU1RUV3pzTDc5Z2JXYkFu?=
 =?utf-8?B?TTRyMEtmVXc4SGVKT1h1ekZPZ1BuNGg3RlkyajZicWJsdEJGZXhFZkEvSUJW?=
 =?utf-8?B?NTdsSUtSL1EydktYcTRwbnF1VG8zcFBuaHVsVWJoQ3Z4QXBNNWpIczV1Mmhj?=
 =?utf-8?B?cmUvb2dxa2lZdS92SDZvb2xuY0dKK2dJdmVvTWhNSE5oM3hBK3Y4cjlWV2hX?=
 =?utf-8?B?WStHL1VtWGNtZTJSaXBtd015dVlRdXFtNDAvOFA0c280emhWb01FQXMyYXUy?=
 =?utf-8?B?SEV4Mk1GOEY5ZDhoL2FLSkpJaGVESGFrV0FGWEdvQjhTdnYrWlRUSUM1OFdU?=
 =?utf-8?B?YXcvcVVlWjc1eFN6UkxOdWhVK2ltLzdkTVNUVnlJM3V2WUVMVmZKYS9IVmRV?=
 =?utf-8?B?V3dFYzZqS2x5K0lBU01KbVkyMWZ0blZxdGV4ZDFVYm1sb2hJZzVOUmFPMmpl?=
 =?utf-8?B?eWVCemFWbVdJWWFwK2pVZTc5S1VFcWNVMGg1Q1VTTlV0azErOENsN2FOMU94?=
 =?utf-8?B?Z3hIVkJvZ0hWVE5vUitra2FzcFJMLzNVYXZZZGpWWW5nMjdYNEtJRVpISkNi?=
 =?utf-8?B?ektvZURXSDlyT2loUWZWR2NTanVGTnByWGFVclRtZkZ5by9XNkFtdXY5dVBU?=
 =?utf-8?B?S3h5MHdMKzBoU2owRVl5cmRCT0J4RzdXa3ppQVc1cFdqNzYxeStBYXpPdld2?=
 =?utf-8?B?OHkxMmVtK1NmcllwcDlLOGJSMHJFRWhXTHFCajNETmZFZXR6eWtOdDQ3L3lX?=
 =?utf-8?B?UmF3YXdYa0k0cVZTVFR6TFZPdTFjZzBOVkloTVIxY3I1M28vMHlreFptTlVN?=
 =?utf-8?B?ZXlzVXBMNHlMamZEOWhobmVQZnRqM3NMR0NYWHdiVEN5WFVScnhheXo4L2xM?=
 =?utf-8?B?cC9mSy9reXEvd2hOWW5QZFZ0cUF3WE52b2VBZ3BjMExSTGV6RUxvOVVHVEVC?=
 =?utf-8?B?V1VnWkhnNXZhalIzdXd5WGJTMGdzT3lJY0tKbHJ5cnA3cVZLZ056NFhJRldM?=
 =?utf-8?B?cUJlc3Y2TGtDZ2w4MTlUNGJHT2x5U3pUd0NhbUIxYVJzRlNFLzNKWmpCVHFX?=
 =?utf-8?B?aFRWL3hEZ2QzSWdIZjBhSUpMTEFoUDhBQk9hNWYzamdMeXdIQkpidTVBOEd3?=
 =?utf-8?B?SWxuSE1XTnRkaU1MUGRmRUZNd29aSmlwUDdIYUVCanJXeWFxVERHeG01QmlG?=
 =?utf-8?B?dk5TbFZsV3dxZmVaZzFxVXEvQm5udEJJZmhCQXdXNWFpSjFPalJXVDVValJa?=
 =?utf-8?B?SWhBd1VJeWJqTHZiUWxDNzA2bVI3ZGIxMURWY3B2VENXZ0gzYnhzTVZmU0V3?=
 =?utf-8?B?OVh3NDdBbGVQV1hMQ2FieE9tdjNPdG1zbTVOUk1DQVhFUG9jcmUxaHVTZVUz?=
 =?utf-8?B?MGRYMHhUdTd0VVlobHRuc0k0K3praStvcXVBTjhteHU0REhFb2lsOGZuaFZC?=
 =?utf-8?B?MmpsZHEzZmJKMlV5SWJvdXVENDRkWGpoV2lWNCtxakRsdVhSaEtMWDRHd0k4?=
 =?utf-8?B?VFBJb3oyM2tIN0J4ZVdWUzF1U21XNlVqaUtJMUVjamFTWkNNaWdmNDd2c1RQ?=
 =?utf-8?B?Vnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b06418fb-0a02-421e-0b21-08dc2c7cba63
X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8722.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 10:15:40.1478
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YqOp5lfFpMzLYNszsE5O2bDESJAwHQvgpEdVXbRJu2nAjo/+lo3nI6RZmGYYheV4jBRzvajM42mJl4Xsu7uDAiYBddfcjTmgB5qV4RtIcfw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5319
X-OriginatorOrg: intel.com

From: Christoph Hellwig <hch@lst.de>
Date: Tue, 13 Feb 2024 06:57:07 +0100

>> +void __dma_sync_single_for_cpu(struct device *dev, dma_addr_t addr,
>> +			       size_t size, enum dma_data_direction dir);
>> +void __dma_sync_single_for_device(struct device *dev, dma_addr_t addr,
>> +				  size_t size, enum dma_data_direction dir);
>> +void __dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg,
>> +			   int nelems, enum dma_data_direction dir);
>> +void __dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
>> +			      int nelems, enum dma_data_direction dir);
> 
> Please stick to the two-tab indentation for continuing prototypes.
> The version here is not only much harder to read, but also keeps blowing
> up the diffs for current and future changes.

Oh okay, I didn't know this is the preferred way (differs from the
common one used in the kernel, e.g. in the networking code).

> 
> Otherwise this looks good to me.

Thanks,
Olek