Received-SPF: pass (google.com: domain of linux-kernel+bounces-63327-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240212115043.1725918-1-robimarko@gmail.com> <c97d10fa-39c5-4e5e-93ce-1610635cb4d4@lunn.ch>
 <CAOX2RU6OwiymM_O_62VETgkBNUQP1TuOKJmm0D1ZUXBA7ZPJNA@mail.gmail.com> <7c5dd47c-26b9-4a12-af93-6139ae85e864@lunn.ch>
In-Reply-To: <7c5dd47c-26b9-4a12-af93-6139ae85e864@lunn.ch>
From: Robert Marko <robimarko@gmail.com>
Date: Tue, 13 Feb 2024 11:16:47 +0100
Message-ID: <CAOX2RU79o_5KRJZUJKA_++rrFXn66oLU0jOVHZnA1wHf2kA7RA@mail.gmail.com>
Subject: Re: [PATCH net-next] net: phy: qca807x: move interface mode check to .config_init_once
To: Andrew Lunn <andrew@lunn.ch>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, hkallweit1@gmail.com, 
	linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, 
	kuba@kernel.org, pabeni@redhat.com, ansuelsmth@gmail.com, 
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Mon, 12 Feb 2024 at 20:48, Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Feb 12, 2024 at 07:09:04PM +0100, Robert Marko wrote:
> > On Mon, 12 Feb 2024 at 15:51, Andrew Lunn <andrew@lunn.ch> wrote:
> > >
> > > On Mon, Feb 12, 2024 at 12:49:34PM +0100, Robert Marko wrote:
> > > > Currently, we are checking whether the PHY package mode matches the
> > > > individual PHY interface modes at PHY package probe time, but at that time
> > > > we only know the PHY package mode and not the individual PHY interface
> > > > modes as of_get_phy_mode() that populates it will only get called once the
> > > > netdev to which PHY-s are attached to is being probed and thus this check
> > > > will always fail and return -EINVAL.
> > > >
> > > > So, lets move this check to .config_init_once as at that point individual
> > > > PHY interface modes should be populated.
> > >
> > > Just for my own understanding, not directly about this patch...
> > >
> > > priv->package_mode is about PSGMII vs QSGMII for one of the SERDES
> > > interfaces? We expect the individual PHYs sharing that interface to
> > > also indicate PSGMII or QSGMII?
> >
> > Yes, that is the idea, all of the individual PHY-s in the package
> > should be indicating
> > the same PHY interface mode.
> >
> > >
> > > But what about the other SERDES, which can be connected to an SFP
> > > cage. You would normally set that to SGMII, or 1000BaseX. When an SFP
> > > module is inserted, the correct interface mode is then determined from
> > > the contests of the EEPROM and the PCS needs to be reconfigured. So
> > > i'm just wondering how this check works in this situation?
> >
> > I just went to retest SFP support and it works as intended, as soon as the SFP
> > is inserted, PHY will get reconfigured to "combo" mode so that fifth PHY can
> > support both fiber (100Base-FX or 1000Base-X) or regular copper connections.
> >
> > So, the check will not interfere with SFP support.
>
> So for the port with the SFP you also have phy-mode of PSGMII or
> QSGMII? That then gets changed when the SFP is hot plugged?

Yes, that is correct and when SFP is plugged in it will be reconfigured
by the driver into combo mode as that port can actually be used for fiber and
copper at the same time by changing the priority.

Regards,
Robert
>
>         Andrew