Received-SPF: pass (google.com: domain of linux-kernel+bounces-63379-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 13 Feb 2024 11:53:38 +0100
From: Robin van der Gracht <robin@protonic.nl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Miguel Ojeda
 <ojeda@kernel.org>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Paul Burton <paulburton@kernel.org>, Geert Uytterhoeven
 <geert+renesas@glider.be>
Subject: Re: [PATCH v1 10/15] auxdisplay: linedisp: Provide a small buffer
 in the struct linedisp
Message-ID: <20240213115338.2311c4b6@ERD993>
In-Reply-To: <ZcpMLXTfc95fGTae@smile.fi.intel.com>
References: <20240208184919.2224986-1-andriy.shevchenko@linux.intel.com>
	<20240208184919.2224986-11-andriy.shevchenko@linux.intel.com>
	<20240212092500.62f006cc@ERD993>
	<ZcoF9ZxPBkVS_6Da@smile.fi.intel.com>
	<ZcpMLXTfc95fGTae@smile.fi.intel.com>
Organization: Protonic Holland
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Andy,

On Mon, 12 Feb 2024 18:49:49 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Looking again into it, the allocation separately with linedisp structure
> is indeed too much invasive. I prefer (as we save lines of code and deduplicate
> the buffer at least for two drivers, including a new one) to leave this patch
> for now. We may rework it later on. Do you agree?

Agreed. The additional overhead is probably not worth it. If the buffer size
needs to be increased later on we'll take another look.

Robin