Received-SPF: pass (google.com: domain of linux-kernel+bounces-63369-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240118-ep93xx-v7-0-d953846ae771@maquefel.me>
 <20240118-ep93xx-v7-8-d953846ae771@maquefel.me> <Zb_A5H5kkxw1oiQv@surfacebook.localdomain>
 <99042a0e72b3d29bc4b582a42a70d667033e6331.camel@maquefel.me>
In-Reply-To: <99042a0e72b3d29bc4b582a42a70d667033e6331.camel@maquefel.me>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 13 Feb 2024 12:45:00 +0200
Message-ID: <CAHp75Ve3ZO4zAkZ+ph_jA6YnxafxGnC-CrfuPTjV3=cG2n-+-A@mail.gmail.com>
Subject: Re: [PATCH v7 08/39] soc: Add SoC driver for Cirrus ep93xx
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Conor Dooley <conor.dooley@microchip.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	Joel Stanley <joel@jms.id.au>, Linus Walleij <linus.walleij@linaro.org>, Wei Xu <xuwei5@hisilicon.com>, 
	Huisong Li <lihuisong@huawei.com>, Walker Chen <walker.chen@starfivetech.com>, 
	=?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>, 
	Arnd Bergmann <arnd@arndb.de>, Alexander Sverdlin <alexander.sverdlin@gmail.com>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 13, 2024 at 11:33=E2=80=AFAM Nikita Shubin
<nikita.shubin@maquefel.me> wrote:
> On Sun, 2024-02-04 at 18:52 +0200, andy.shevchenko@gmail.com wrote:
> > Thu, Jan 18, 2024 at 11:20:51AM +0300, Nikita Shubin kirjoitti:

..

> > > +static struct auxiliary_device *ep93xx_adev_alloc(struct device
> > > *parent, const char *name,
> > > +                                                 struct
> > > ep93xx_map_info *info)
> > > +{
> > > +       struct ep93xx_regmap_adev *rdev;
> > > +       struct auxiliary_device *adev;
> > > +       int ret;
> > > +
> > > +       rdev =3D kzalloc(sizeof(*rdev), GFP_KERNEL);
> > > +       if (!rdev)
> > > +               return ERR_PTR(-ENOMEM);
> >
> > Use __free() ?
> > (You already included cleanup.h for other cases, why not using it
> > here?)
>
> Why should i want this ?

To eliminate the necessity of not forgetting to clean it up when it's neede=
d.

> I don't want rdev being freed on out of scope
> - rdev is freed in ep93xx_adev_release().

It's irrelevant.

> But thank you, i've noticed a bug - i should free rdev and not adev
> both in ep93xx_adev_alloc() and ep93xx_adev_release().

Exactly to avoid such mistakes, so please switch to __free() along
with no_free_ptr().

> > > +       rdev->map =3D info->map;
> > > +       rdev->base =3D info->base;
> > > +       rdev->lock =3D &info->lock;
> > > +       rdev->write =3D ep93xx_regmap_write;
> > > +       rdev->update_bits =3D ep93xx_regmap_update_bits;
> > > +
> > > +       adev =3D &rdev->adev;
> > > +       adev->name =3D name;
> > > +       adev->dev.parent =3D parent;
> > > +       adev->dev.release =3D ep93xx_adev_release;
> > > +
> > > +       ret =3D auxiliary_device_init(adev);
> > > +       if (ret) {
> > > +               kfree(adev);
> > > +               return ERR_PTR(ret);
> > > +       }
> > > +
> > > +       return adev;
> > > +}

--=20
With Best Regards,
Andy Shevchenko