Received-SPF: pass (google.com: domain of linux-kernel+bounces-63458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6678b65c-15ab-4bbf-b3cc-a3110dca97e1@suse.com>
Date: Tue, 13 Feb 2024 13:49:05 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86: Improve description of
 IA32_EMULATION_DEFAULT_DISABLED
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>, =?UTF-8?Q?Hanno_B=C3=B6ck?=
 <hanno@hboeck.de>
Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
 x86@kernel.org, linux-kernel@vger.kernel.org
References: <20240130104543.28840812.hanno@hboeck.de>
 <20240206145823.GGZcJJD8rDtPRNBkhe@fat_crate.local>
From: Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20240206145823.GGZcJJD8rDtPRNBkhe@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 6.02.24 г. 16:58 ч., Borislav Petkov wrote:
> On Tue, Jan 30, 2024 at 10:45:43AM +0100, Hanno Böck wrote:
>> The description of the option disables a default, but does not mention
>> how to change that default. To make it easier to find out, mention boot
>> parameter ia32_emulation.
>>
>> Signed-off-by: Hanno Böck <hanno@hboeck.de>
>> ---
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 5edec175b..a65ff33e0 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -3006,8 +3006,10 @@ config IA32_EMULATION_DEFAULT_DISABLED
>>   	depends on IA32_EMULATION
>>   	help
>>   	  Make IA32 emulation disabled by default. This prevents loading 32-bit
>> -	  processes and access to 32-bit syscalls. If unsure, leave it to its
>> -	  default value.
>> +	  processes and access to 32-bit syscalls. If set, IA32 emulation can be
>> +	  re-enabled with the boot parameter ia32_emulation=true.
> 
> That sentence should say one can enable it *dynamically* with the cmdline
> param.
> 
> But this text reads weird: if I want to enable it, then I won't set
> IA32_EMULATION_DEFAULT_DISABLED in the first place and I won't have that
> problem.
> 
> So the use case must be something along the lines of, ia32 emu is
> default-disabled at build time but for certain cases where one wants it,
> one can still enable it per-boot with a cmdline param.
> 
> So what's the story here?

The use case is if a distribution wants to disable ia32 emu by default 
but at the same time wants to give users the ability to override it. 
Which is pretty much the use case you presented.

> 
> Thx.
>