Received-SPF: pass (google.com: domain of linux-kernel+bounces-63479-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6e776c69-12fd-470f-b3ce-dd9f91bacde5@prevas.dk>
Date: Tue, 13 Feb 2024 13:05:29 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: lib/vsprintf.c:1528:9: warning: function 'va_format' might be a
 candidate for 'gnu_printf' format attribute
Content-Language: en-US, da
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 kernel test robot <lkp@intel.com>
Cc: Petr Mladek <pmladek@suse.com>, oe-kbuild-all@lists.linux.dev,
 linux-kernel@vger.kernel.org,
 Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
References: <202401111051.dDNWAfKw-lkp@intel.com>
 <Za0iLa7akcaML096@smile.fi.intel.com>
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <Za0iLa7akcaML096@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cjVMaHVpYjN5VHhzTitzOCthcDY5R25NcDN3L1p2L3hyakhhNjVrS1dERVJk?=
 =?utf-8?B?cWlOR2JCbHRFc3o2NnVBWWRyZHhoOWlpVXpFUDZ5ZUkyd3pEeU5xUkVLcHpV?=
 =?utf-8?B?VkpybzUzRUNUVE9SVDFEUFdKVnlxb1E1eG03cFI5ZWlSRFRhVWw0SkdLdlo0?=
 =?utf-8?B?VjFVdElUQWxtTjRwNENxL3kzcXN6NmZhdzdnbzBDRTF6aXJOQmowVmNwVUdF?=
 =?utf-8?B?UnVqKzh2MVIyRks2dkFLMDJKMkM4RUtvWTBWcGRHd0k0OXNSVTBWenR6ZkJ3?=
 =?utf-8?B?dUhjc25ISDkxTW5xUnkxTEZRWWg0RjZSaGlwNHVnYTZObHV5WTlnMWtVaWpD?=
 =?utf-8?B?cVhjZXlaL2JuRlFZSkhkejhaRlcxWmUrVEkyVHl4S0ZLbGZ0dHlOa3k2aWRs?=
 =?utf-8?B?elpNdkFXU3I1Q3FsTzN4a3hpWnkwbHVONytvWWlsL1dnd3JIMkFoaWtwcUE2?=
 =?utf-8?B?bHQ2RU5uS01KUS9zWEplbGdFTVNGczhncmFDNUFpaVhjTWhsTkRnV3B0K0Fl?=
 =?utf-8?B?dERLZW1jY24veVZUTjRuVElueVFuMXdvUXV6ODNqSDV3MGh6VGgrVlYvay84?=
 =?utf-8?B?SFBIbHlNR01lOXhqeFpmK09LYTQrcEljSHNRM3dLWnVDc3p6Vm1LdWF1bGQ1?=
 =?utf-8?B?NWVEOHpGVWRRaWJvOWpIa1RaWWNDT3MvMXdITFA3VnA2NkowK1FNV2owWlUv?=
 =?utf-8?B?b0dnQ1hBSExmMzJvNkxOT0c0R01hbldlblJ4NndyN1NRQmpJMWE1L3lobWVv?=
 =?utf-8?B?YjB6bm1DbEpMU25uTFdFWTNVZm9pOTlmZ1llaUJJbmNZdUl1MU5xN1EvelUx?=
 =?utf-8?B?dVZVaWNhU1NjOE53MjZCbUNjZFlTdVdDdHNkd1c4dXQ4Q1FlcDVwMUpsdGcx?=
 =?utf-8?B?KzYvYnJReXlFYnVWd3RLMncySnhrOXcydzJpODBwWWdpaWFqOE1weEgwT1hI?=
 =?utf-8?B?U0FjMDk2UjB6RVNGZnhvNFloVk1VTlVXZW5URWdDQ3J6a2F5a25MUDRTOWww?=
 =?utf-8?B?WW9XcEQ3cXA1aElpMFo2bkgydWRPdk9sSVNHYytLTm1NdERvZlNEY0tzMkFo?=
 =?utf-8?B?UTRiaXF1S2dwNGt1ODhmWE1yV21saVNOWDNhU1NSdS9rYnllZ3BueVhwQXJJ?=
 =?utf-8?B?d3JneDVtSFVLT09hQytyejRCaFJuYU94OWRienFzeWZxazVjVHlnanBoNHRL?=
 =?utf-8?B?K1VjaldXUHFnMUJ6UnhVN1BWNXBXM2JLOCt4ejhNRzUvaXo0T2owWFZIT1V3?=
 =?utf-8?B?QXErNnJ0NDlKa05vNmh1Z004TkFsd09OTzQ0RTlpcnNuZDVnRFJpQTNMOXk5?=
 =?utf-8?B?RkpzVkptQWJEdStEMEo0bXdzZkRYajdLUjhYSE1PQytNVUVWTldqbHV6TVA0?=
 =?utf-8?B?VFlwSEkxT2tFY1RpNGtCdVJsK3poUFRPVzJ0RHZCMGpjZXZqclFkd2thMDhB?=
 =?utf-8?B?YkVYbzUrNDJ3bDB5Mk9RNVhEdDIrY2hkbWEvbkdUT25mZktqM2k0YWV0Rksw?=
 =?utf-8?B?ckFrVnBPYmJqSkU5cFpud1dPS083VVVyNmQrWGtXbGJOWmhqVmJDbnpCYW81?=
 =?utf-8?B?Y1lJODlQMXFNK1g3Y3NFbURoclVwdWE1ZVlpeHpJTmdCZ3Z4T2tpVnVCRFBn?=
 =?utf-8?B?ZzZWMUJNVzlDV0luc1NTQ1NHN2pFSURBL3FrbjhqenFWMnA3c09ua3JTbXRF?=
 =?utf-8?B?akVIdXZ4YlBXL24vNGVybFJ1TFBqMmU5L29aR2RpVDhCL1dDZW82QURvdDVH?=
 =?utf-8?B?Qlp2QkhKN0lJTlp4enRUUGNacXZSZ0J2NXBiL2E3NHhLNVFKdkZXZmt2eDFh?=
 =?utf-8?B?TFFEWXk1cmoxQ01SMnJoZXdqNjZGT3lRdUc5NjJBclY2ellZMlBPLzR4SjV5?=
 =?utf-8?B?UURNNzVSdjJxM01LQm1UYjQwbFBiYThIMC9QQ3VDdFZ1TVEwaHN2Y3lTTXA2?=
 =?utf-8?B?UGJoeC8xNEpLSTdhNFNvSFVXUGNwbGdrTTNkT0wwWmd5aWJOVUVJMlZIZjF4?=
 =?utf-8?B?RllCR21wV1FaTHZBUTMzUDRSc1lYT09Wem9SNlJNY0ZBTjhoeGkyUnFCSHpj?=
 =?utf-8?B?T1FqSnBNenJEd1ppOExQL0QrVUpjZEJIT2EzUjRTY1o3RWlvdjFpRDdOV3d3?=
 =?utf-8?B?U29jR0RZV1JSZm95WmxDdm0yWmF4eU5iNmZ6eHo5Z3VjSW1vdjdydjQvM1Zs?=
 =?utf-8?B?V3c9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: fba0f973-7e0d-41cd-e234-08dc2c8c13aa
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 12:05:32.3195
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: REJ+TSs9NKX/sROCdZb9zp6O14pqd75w9OvoVJcUpxBo4feL3XW+lZt68nm0a1/L20xrnCLZ9bCO+sVhmwevav+NqV5K279l5SgdkndB+Ug=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB7399

On 21/01/2024 14.54, Andy Shevchenko wrote:
> On Thu, Jan 11, 2024 at 10:33:09AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   acc657692aed438e9931438f8c923b2b107aebf9
>> commit: 45c3e93d751ea50861c796da3cbfc848fa6ddf55 vsprintf: Factor out %pV handler as va_format()
>> date:   4 years, 9 months ago
> 
> Blast from the past?!
> 
> ..
> 
>>    lib/vsprintf.c: In function 'va_format':
>>>> lib/vsprintf.c:1528:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>>     1528 |         buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
>>          |         ^~~
> 
> This might be still valid, but I have no idea how to properly fix it.
> 

It's a bogus warning, and the fix belongs in the compiler. When
vsnprintf() is called, but neither the format arg nor the va_list arg
are direct arguments to the caller (and the va_list is not built from
actual varargs using va_start()), there's absolutely no way a __printf
attribute could be appropriate.

IDK if we can shut up the test robot by locally disabling the
Wsuggest-attribute with some pragma.

Rasmus