Received-SPF: pass (google.com: domain of linux-kernel+bounces-63504-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <jstultz@google.com>, Pranav Prasad <pranavpp@google.com>
Cc: sboyd@kernel.org, linux-kernel@vger.kernel.org, krossmo@google.com
Subject: Re: [PATCH v2 1/2] alarmtimer: Create alarmtimer sysfs to make
 duration of kernel suspend check configurable
In-Reply-To: <CANDhNCovFCekU3wKYNMZWNgcr1=yyDnKNoehXe-x3Ep6-c58eg@mail.gmail.com>
References: <20240208195622.758765-1-pranavpp@google.com>
 <20240208195622.758765-2-pranavpp@google.com>
 <CANDhNCovFCekU3wKYNMZWNgcr1=yyDnKNoehXe-x3Ep6-c58eg@mail.gmail.com>
Date: Tue, 13 Feb 2024 13:29:39 +0100
Message-ID: <87r0hgh7ik.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 09 2024 at 12:01, John Stultz wrote:
> On Thu, Feb 8, 2024 at 11:56=E2=80=AFAM Pranav Prasad <pranavpp@google.co=
m> wrote:
>>
>> Currently, the alarmtimer_suspend does not allow the kernel
>> to suspend if the next alarm is within 2 seconds.
>> Create alarmtimer sysfs to make the value of 2 seconds configurable.
>> This allows flexibility to provide a different value based on the
>> type of device running the Linux kernel. As a data point, about 40% of
>> kernel suspend failures in a subset of Android devices were due to
>> this check. A differently configured value can avoid these suspend
>> failures which performs a lot of additional work affecting the
>> power consumption of these Android devices.
>>
>> Signed-off-by: Pranav Prasad <pranavpp@google.com>
>
> I might suggest flipping the order of these two patches, as I'm more
> wary of UABI changes, so I don't want to hold up the second patch on
> interface bike shedding.

Correct. It's an orthogonal issue and an optimization on top of the
early check.

Thanks,

        tglx