Received-SPF: pass (google.com: domain of linux-kernel+bounces-63536-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <263d486c-655b-4179-841b-de3ad04de38d@vaisala.com>
Date: Tue, 13 Feb 2024 14:46:39 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] usb: core: Kconfig: Improve USB authorization mode help
Content-Language: en-US
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
 vesa.jaaskelainen@vaisala.com, geert@linux-m68k.org
References: <20240209142951.27195-1-niko.mauno@vaisala.com>
 <2024021043-nursing-unbridle-cea4@gregkh>
From: Niko Mauno <niko.mauno@vaisala.com>
In-Reply-To: <2024021043-nursing-unbridle-cea4@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T2RlWlNneXNSckh1YytZRTZLL2JIb05vRFFpSmdOYVMxR3hhWjRvTFFUODlI?=
 =?utf-8?B?MDdLanY4NThNcmZrd3cwZ3lmNmR4ZDQwQm41eVRORDAvZjV2Wnplci95REdj?=
 =?utf-8?B?V3RYOTNlWk9ERnkxUXJyT2RKbS9ITmw0TitVOTkvYndKbGp1NnhnOVYxUC84?=
 =?utf-8?B?QVhkYXBOeFl2VGJWb3lSeGhBOWdZQ0ZrYWlNSjdwWjFkMlprc21BeG00NEY4?=
 =?utf-8?B?dWg3QW1SUE00aW8zQ1gzQnk4V2N3cDZOYzNrTitwMEQ2NXZOblFGcXRsSGV0?=
 =?utf-8?B?dkhrTkFIZHpnY3N6bUJndXQrSWcvVWlxckJKNkEzVUFqaGRDb29tWW1nL2F0?=
 =?utf-8?B?cUpJS29tcnF3MVZhYy9hVHhSSWVoQ3JDajRld25rSDdoSU9XQXJrQjNOS0o1?=
 =?utf-8?B?bGJHaUd3ditSd1hNVHZncXVncUNKeGRmWXQ5Y1VFY002TUxDUDlKZmNYd1lT?=
 =?utf-8?B?L1VJaFNteTQyVmVSNUR1VDEyMXIySXNLT2pFSTJ1NElHY0ZmRElvQ2Q3a3Rs?=
 =?utf-8?B?b25LSEgrblI2K0pvdThidytoeHdRblR1TExzSVF2Rk5PcEpMVWlkUzE3R2Zj?=
 =?utf-8?B?WUtBRlZJcWZmN0lkTHlWVG1zYVlaRTd6OS9oYnJGN0lqdUdvQTJDbEZuODE1?=
 =?utf-8?B?Ym8zb2dCeSs3c01pL2lldGxpT09mRUNjckJoMTVlU2hVNEJ3Y05TMzB0aVM4?=
 =?utf-8?B?VmJmT0s4SXRsNHBrK1JOTk1CakVkNGIyMnpBYVpqekt1clZQdDhyaUNydHd6?=
 =?utf-8?B?Qkp5N0J0cmcyeVZLU0IvWmZqSlB4cjk0MkpCN3ZPMXZkbE51SEtyQ2VTYjdB?=
 =?utf-8?B?OFMrTEwwaWw2ZTJ6RHFlSUlHbU92d1ZUckNnbHMyWHk5b1FreXE0cGduTnpB?=
 =?utf-8?B?MmhOcmRlYXZEKzNxSXRHaWFVSysxUFFQY2tGVmlRbGR4Rnd3aUZvL2VTMGZ0?=
 =?utf-8?B?REtTclF2TmtBVUlNRWhGdmFvdVg2M3o0Tk9GbytkbmE2RmtJNUV3UUFKQ2NZ?=
 =?utf-8?B?QTNFZHB4VDZNUHozdTVTQXNFL2pQMXQ5RjZYb2V1UkFuTnI2MzBlNmZ4RjBr?=
 =?utf-8?B?ZVhsS3R3NUZHUGJ6Vlk4SWh4dFo4cXFBT0hXTXQrdVVSb3p1T2U4UVZraFpY?=
 =?utf-8?B?eXhoZ1hkRmIxTWdTUmd3THdpcFVEV2o1Q0gzRnlyZGpmelZWRnBaN3NPUWRV?=
 =?utf-8?B?b0R6cUtkZVFkTzFOZlF0TitUa2VrdGtsWVVncjNnUmQ0S3ZRWFNFSEl0TEdE?=
 =?utf-8?B?RFEySWZ6V1Iyc24zK3BNSUVlOElGVFNpaUZDbjZmaVBhOTR1cXh4SGx6UTJu?=
 =?utf-8?B?SjlsckpSQ1lyNXh6WlJkRURJTGxtNE9QbEgxamRxL2NhVHc1Y0oxRGNVYXRx?=
 =?utf-8?B?Y0pXRG9QVGNiSjNRSDFnSWcxQ1B2OEh2Tk4xOTlCcXoxSG53b1h3WjVvNzVq?=
 =?utf-8?B?R3ZhUEpkcWpyQnAwRkphTDI3c1UyRHg0L29uN0U5Qk16OFZZdDJwM2hRSnU3?=
 =?utf-8?B?THhZczA1QnZiWCtaYldlcS9xQU91Y3pkRVNGWnpIZ1hkb2oxckNhYkMwUTF5?=
 =?utf-8?B?b0kxYVlmTXdtVlRiTVRuQzlRUHl3d29OWEdNUytvajhTWUlURnFvRE0wZ2d4?=
 =?utf-8?B?M2xEcHZMNjBQV09udXVFcEVMUWlTNUsyTnorOFppaFc4Zld2bjFDbXF6UUp6?=
 =?utf-8?B?dk5sQVpEUFpDR3hzQVBCcU9BWlo0QXFieWZvczllRUxBejNBMGJ0a2hUYm40?=
 =?utf-8?B?ek5kWkpoVXJWYTgxR1VjeUE5WjYxR0VDQ0ZVVzdOSVVFbkdCWTZobHlIMkFV?=
 =?utf-8?B?VW1PNkp5bktwcEhUdmREVzR0REk1eFZuMDl5ODBkNlNRSlNNR0xQVUV6T3ZH?=
 =?utf-8?B?NUE2ZlE5VlQ2bnhrWmhhNGlTNW1zSStkdlh1b2REMnMzSjFSdnhmVGc3VEhF?=
 =?utf-8?B?QXpmVzk1dFFZZlk3NG9HS2pCUVhwdlpMSis0c0hjd0MwZXFXOEdRWWJoOWd2?=
 =?utf-8?B?Znp3d3g4YW9QVEVNeDdhQVBlR2R4WHpzUno1ZHpzN25kRjBZODBsN1ZaU0Ew?=
 =?utf-8?B?VUErTmZFV3F2SWhMVktHRXlHVVZpT21PWHIyKzRXYnFoOFN0MXVUZDFqUEsr?=
 =?utf-8?B?b2kzMW4yYU1uOXQrZVhsQzc3VnZEQ0NoSTNvOFpFTnBtNHE4L2tTRlBMRDFW?=
 =?utf-8?B?QlE9PQ==?=
X-OriginatorOrg: vaisala.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da035a80-6d81-41b7-cb16-08dc2c91d386
X-MS-Exchange-CrossTenant-AuthSource: AS4PR06MB8447.eurprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 12:46:41.1415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6d7393e0-41f5-4c2e-9b12-4c2be5da5c57
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IRJ5Bsbg1SwQxnHhxmzEiBFxZx2vbqzmku6w8ydchnFuMdj7gijaSzJVmbqNw7kAQUja61wVYQzP4Mei2Vbf1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR06MB8330

On 10.2.2024 12.27, Greg KH wrote:
> On Fri, Feb 09, 2024 at 04:29:51PM +0200, niko.mauno@vaisala.com wrote:
>> From: Niko Mauno <niko.mauno@vaisala.com>
>>
>> Update the default USB device authorization mode help text so that the
>> meaning of the option and it's available values are described more
>> accurately.
>>
>> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
>> ---
> 
> Shouldn't there be a "Reported-by:" line here to give proper credit for
> the developer who asked for this?
> 
> 
> 
>>   drivers/usb/core/Kconfig | 19 +++++++++++++++----
>>   1 file changed, 15 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
>> index f337aaea7604..4665df550d36 100644
>> --- a/drivers/usb/core/Kconfig
>> +++ b/drivers/usb/core/Kconfig
>> @@ -126,10 +126,21 @@ config USB_DEFAULT_AUTHORIZATION_MODE
>>   	  Select the default USB device authorization mode. Can be overridden
>>   	  with usbcore.authorized_default command line or module parameter.
>>   
>> -	  The available values have the following meanings:
>> -		0 is unauthorized for all devices
>> -		1 is authorized for all devices (default)
>> -		2 is authorized for internal devices
>> +	  This option allows you to choose whether USB devices that are
>> +	  connected to the system can be used by default, or if they are
>> +	  locked down.
>> +
>> +	  With value 0 all connected USB devices with the exception of root
>> +	  hub require user space authorization before they can be used.
>> +
>> +	  With value 1 (default) no user space authorization is required to
>> +	  use connected USB devices.
>> +
>> +	  With value 2 all connected USB devices with exception of internal
>> +	  USB devices require user space authorization before they can be
>> +	  used. Note that in this mode the differentiation between internal
>> +	  and external USB devices relies on ACPI, and on systems without
>> +	  ACPI selecting value 2 is analogous to selecting value 0.
>>   
>>   	  If the default value is too permissive but you are unsure which mode
>>   	  to use, say 2.
> 
> In looking this over, this last sentance really isn't a good suggestion,
> as it will turn people's machine into one that by default, doesn't
> accept external USB devices, which is probably NOT what they want at
> all, and is NOT how Linux has worked for the past 20+ years.
> 
> So maybe a bit better clarification as what the normal default should be
> here?
> 
> thanks,
> 
> greg k-h

Thank you for the pointers, submitted v2 to address aforementioned issues.
-Niko