Received-SPF: pass (google.com: domain of linux-kernel+bounces-63540-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 13 Feb 2024 14:52:16 +0200 (EET)
To: Mark Pearson <mpearson-lenovo@squebb.ca>
cc: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>, 
    Hans de Goede <hdegoede@redhat.com>, 
    "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: think-lmi: Fix password opcode ordering
 for workstations
In-Reply-To: <c4e6d61d-d836-4a79-a89d-141f92f6b41e@app.fastmail.com>
Message-ID: <7aa1ac00-0db4-934a-94d5-b5daacaeb863@linux.intel.com>
References: <mpearson-lenovo@squebb.ca> <20240209152359.528919-1-mpearson-lenovo@squebb.ca> <dfb993c6-0e10-bc70-e8e9-a88651863a27@linux.intel.com> <c4e6d61d-d836-4a79-a89d-141f92f6b41e@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-986691078-1707828736=:9580"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-986691078-1707828736=:9580
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 9 Feb 2024, Mark Pearson wrote:

> Thanks Ilpo
>=20
> On Fri, Feb 9, 2024, at 10:34 AM, Ilpo J=C3=A4rvinen wrote:
> > On Fri, 9 Feb 2024, Mark Pearson wrote:
> >
> >> The Lenovo workstations require the password opcode to be run before
> >> the attribute value is changed (if Admin password is enabled).
> >>=20
> >> Tested on some Thinkpads to confirm they are OK with this order too.
> >>=20
> >> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> >
> > Would a Fixes tag be appropriate here?
>=20
> Hmmm - good point, though it has been "wrong" since it was originally imp=
lemented (where we tested on Thinkpads).
>=20
> I guess I could use the commit ID from when I originally implemented opco=
des?
> Fixes: 640a5fa ("platform/x86: think-lmi: Opcode support")

Yes, in that case the original commit is the correct one.

> Do you want me to push a new version with this?

I think this is simple enough to go through fixes branch so it depends on=
=20
Hans.

Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-986691078-1707828736=:9580--