Received-SPF: pass (google.com: domain of linux-kernel+bounces-63568-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 13 Feb 2024 13:13:41 +0000
From: Mark Brown <broonie@kernel.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	=?iso-8859-1?Q?G=E1bor?= Stefanik <netrolller.3d@gmail.com>,
	rdbabiera@google.com, amitsd@google.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tpcm: Fix issues with power being removed
 during reset
Message-ID: <3a09ea3b-3a42-4fce-85f8-f8408a4a2206@sirena.org.uk>
References: <20240212-usb-fix-renegade-v1-1-22c43c88d635@kernel.org>
 <CAPTae5LOresaK3Epd4R_ifpx2kw21tubQDENg4OMrhJWsar-oA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wNzrdL2IZ5232/Er"
Content-Disposition: inline
In-Reply-To: <CAPTae5LOresaK3Epd4R_ifpx2kw21tubQDENg4OMrhJWsar-oA@mail.gmail.com>


--wNzrdL2IZ5232/Er
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 13, 2024 at 02:09:16AM -0800, Badhri Jagan Sridharan wrote:
> Hi Mark,

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> While HI-Zing CC pins disrupts power for batteryless devices, not
> Hi-Zing CC pins would prevent clean error recovery for self powered
> devices which is why "usb: typec: tcpm: fix cc role at port reset" was re=
verted.
> Please note that the breakage in error recovery behavior is a
> regression as well.
> Hi-Zing CC pins would make the port partner recognize it as disconnect
> and will result in bringup the connection back cleanly.
>=20
> How about leveraging "self-powered" device tree property and Hi-Zing
> CC pins only when using "self-powered" ?
> This should help devices which don't have batteries while NOT regressing
> the error recovery behavior for the self powered devices.

I don't super care so long as the boards I care about continue to
function, I submitted this patch because the only response to my report
about the rk3399-roc-pc having been broken in mainline was a
confirmation that the failure was expected.  As I noted in the commit
log checking if there is an alternative power source does seem like a
viable option here, I am not particularly familiar with this code.

--wNzrdL2IZ5232/Er
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXLawQACgkQJNaLcl1U
h9DeBgf9HO4xYfg24xt/Jvbh1Le5gyPcZnCGlzA0xrtgv4g1unnklA5uQ/EfFen6
hbGufKQ5/sRQ3gCxUve350Vaq/ynTH5EM6gkTLCmiYNp2KFBejcFq88+Zb8ekOMy
Tnzd4GVwHFVxQczjK8kKnjvXwiqnJBg08Dcq3i8dp3GrvxYir+Q79gRV6nHbzZvb
Toa3WxY51eRZE+1iKGK31Zeb0lmwnqHZ9LY9jmUEpZO+gzoX/FGKdyoo31ZkiIlP
NFkkQmYKc+iMN8trojxI6rguRMu8zvZpZbrm8Gx69+9rPmIEAunXbDVbV0pcj9uf
cR4Zl/H4+6Gud2N5FIi2O3Z2oZwZeQ==
=oW47
-----END PGP SIGNATURE-----

--wNzrdL2IZ5232/Er--