Received-SPF: pass (google.com: domain of linux-kernel+bounces-63591-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240213124146.202391-1-aford173@gmail.com> <20240213125618.GG52537@atomide.com>
 <20240213130208.GI52537@atomide.com>
In-Reply-To: <20240213130208.GI52537@atomide.com>
From: Adam Ford <aford173@gmail.com>
Date: Tue, 13 Feb 2024 07:29:05 -0600
Message-ID: <CAHCN7xLmTEk0439XTuRPG7SSdH=4YiMTmrSXmfTkpC2bo_kNGw@mail.gmail.com>
Subject: Re: [PATCH] arm: dts: omap3: Migrate hsmmc driver to sdhci driver
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, aford@beaconembedded.com, 
	=?UTF-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 13, 2024 at 7:02=E2=80=AFAM Tony Lindgren <tony@atomide.com> wr=
ote:
>
> * Tony Lindgren <tony@atomide.com> [240213 12:56]:
> > * Adam Ford <aford173@gmail.com> [240213 12:41]:
> > > The sdhci driver has been around for several years, and it supports
> > > the OMAP3 family.  Instead of using the older driver, let's finally
> > > migrate to the newer one.
> >
> > I think we also should do these to avoid incomplete conversion:
> >
> > - ti,dual-volt property can be dropped
> >
> > - ti,non-removable should become non-removable

I'll do a more comprehensive search for these flags.  When I did my
testing on the AM3517, I didn't notice these, but I see now that
others might.  I'll do a multi-patch series to first address the
multi-block, then  omap3-ldp.dts, then migrate the omap3.dtsi to the
new driver while dropping the flags, and lastly update the individual
boards accordingly.  I just have one question below.
> >
> > - ti,omap3-pre-es3-hsmmc probably should not be needed with sdhci
>
> Hmm actually we may need to set SDHCI_QUIRK_NO_MULTIBLOCK for
> compatible ti,omap3-pre-es3-hsmmc.

Should I update the driver and binding to add  ti,omap3-pre-es3-sdhci
to set that flag, or should we create a boolean (maybe
'ti,sdhci-no-multiblock') to the device tree options for that driver?

adam
>
> Regards,
>
> Tony