Received-SPF: pass (google.com: domain of linux-kernel+bounces-63617-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 13 Feb 2024 14:52:43 +0100
Message-ID: <87a5o4xyhg.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Takashi Iwai" <tiwai@suse.de>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"Curtis Malainey" <cujomalainey@chromium.org>,
	"Dmitry Antipov" <dmantipov@yandex.ru>,
	linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] ALSA: fix function cast warnings
In-Reply-To: <6a52b971-227b-4433-bdf9-b4a69a41d061@app.fastmail.com>
References: <20240213101020.459183-1-arnd@kernel.org>
	<87il2sy13f.wl-tiwai@suse.de>
	<6a52b971-227b-4433-bdf9-b4a69a41d061@app.fastmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Tue, 13 Feb 2024 14:30:56 +0100,
Arnd Bergmann wrote:
> 
> On Tue, Feb 13, 2024, at 13:56, Takashi Iwai wrote:
> > On Tue, 13 Feb 2024 11:09:56 +0100,
> 
> >>  
> >> -int snd_rawmidi_receive(struct snd_rawmidi_substream *substream,
> >> -			const unsigned char *buffer, int count);
> >> +int snd_rawmidi_receive(void *ptr, const void *buffer, int count);
> >
> > If it were only about the type of the buffer argument being a void
> > pointer, it's fine.  But the substream argument should be explicitly
> > typed, otherwise it's confusing for other normal call patterns.
> >
> > I guess the suitable fix for now would be to provide wrapper functions
> > that are used for callbacks and bridge to the actual function with
> > pointer cast, something like below.  Eventually we can put more const,
> > but it's basically irrelevant with the warning itself.
> 
> Right, makes sense. I gave your patch a spin and it addresses the
> warnings I saw in randconfig builds, so please apply that with
> "Reported-by: Arnd Bergmann <arnd@arndb.de>".

OK, will do.


thanks,

Takashi