Received-SPF: pass (google.com: domain of linux-kernel+bounces-63609-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Zi Yan <ziy@nvidia.com>
To: "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>
Cc: "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
 linux-mm@kvack.org,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com
Subject: Re: [PATCH v3 0/7] Split a folio to any lower order folios
Date: Tue, 13 Feb 2024 08:46:10 -0500
Message-ID: <FF718BD8-8A54-47AC-B75F-928ECA42BB79@nvidia.com>
In-Reply-To: <qzbcjn4gcyxla4gwuj6smlnwknz2wvo5wrjctin6eengjfqjei@lzkxv3iy6bol>
References: <20230403201839.4097845-1-zi.yan@sent.com>
 <qzbcjn4gcyxla4gwuj6smlnwknz2wvo5wrjctin6eengjfqjei@lzkxv3iy6bol>
Content-Type: multipart/signed;
 boundary="=_MailMate_89108B55-2245-48B9-B728-510EAA2F55C2_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?uKIml+J05up7vL3wgQdBErv37dLPcnehCgItS9cBq95HVXAhZmzdPqg7g99n?=
 =?us-ascii?Q?Gq44S53bNiGx1SWPbxsGqda2R6LN/hSctobTkrMAqThaOPnbs85rpo5lEq9B?=
 =?us-ascii?Q?fnqgTBJLJNyF10K7mvYwLgJcXanNS4wJ4H2e+n1pvMy3z61GYz2zUkO1urli?=
 =?us-ascii?Q?6JVX5Hix3Ka2A67ixL8q12SCJC2tTE+3R0WhB+Xm874u/x1QJTVKTKTH6m82?=
 =?us-ascii?Q?e5d/G01xj6wdbxoSnNtm0M26cHoK7HC8fYQ6GWcY+KQgPOGbxWJ3iEh6Wm4O?=
 =?us-ascii?Q?wLjoeL2pYywwa4SWnI/PQfQCKGZ0wy0GldiM996jPBsxRmBwpLB5CKlzrFW6?=
 =?us-ascii?Q?FvDo8QhoiDW6z4GkfbjJQDfjJJvWunK0S5etMxWPL7WzY73IE7PTCO5i47ru?=
 =?us-ascii?Q?CQN0hDD52ibcRlT6zBG0uVwF6Tmqjx6x+Cl8agvmDumQSe2hrrdZUEAkliR9?=
 =?us-ascii?Q?EMaOcxVI9npl/XCVGpfRecpuYtn5HN6fhH2utedAfN07K/roifIZIxfVg9Dx?=
 =?us-ascii?Q?NLFT0E8HB73uxHhyoIWymkxjOwQYmZyTH2BQ4kNgtZCVGdKQC4Ue/t53begu?=
 =?us-ascii?Q?fiYTMIjg/cZP6dLNg1JFCRwukGihXutfnCPqM3/+B71L3hHkYPQIOgvBPwKy?=
 =?us-ascii?Q?OUIsy4nXJj7A3eV/ZuoamgtdEHbYjszSaxlmFONEkRwb7/e0pJRzTwbx2nxm?=
 =?us-ascii?Q?fUEgWIy7y/Gvv/L+BJmcURKDJ/KWhekruyWatHolhHfMExppghad608z8uAu?=
 =?us-ascii?Q?yWyruRVsB/a4GGKcEllEo2LSc72T67rQ4MSXvhepXG2+XMFDBFHRo5AVBJBQ?=
 =?us-ascii?Q?cFKSZseNBL2SYjfhNcjlzLR/z1OcPkOIb42bQGI+iKiVpgfIDw3TpHp8lDXP?=
 =?us-ascii?Q?pqy7AMGCTYSyHpTZjkZRP8rwfkpOir+KwC4Sab+Eq1B7H0x70txihZ4e0xPB?=
 =?us-ascii?Q?q7X1WEEjwq34TiU4C25coCHFqZllz+2HzzYOw9QL3XzSLV9VZ+Wu2YxAXjN5?=
 =?us-ascii?Q?pOT2ivTOfg6/OxDBBznPXM1w81LjiehcsmSOWxYIew7Lj1C1qGfup+AJ/K0/?=
 =?us-ascii?Q?6TmH3qQac9OMm+Yz6WaRdMf5PH/S42ts/x7Q6Ehv4sBZawqWQyLR14SfPsNy?=
 =?us-ascii?Q?JwiHQC4prWw5mrIYg01t3HPT6Mv57Xqxaajn7T8P0DbI/LUIX1eSWbEQp3xM?=
 =?us-ascii?Q?RLSYytV2+MyThbOqJBA+QuI0qXSSRjdFdJRxMWk8WBx8pIuM5ZVkIp6BCVri?=
 =?us-ascii?Q?RF9eiUB3+FwOUoVcQ9HKc0hQdmUOjnAL6MopdV4vQUycku5XoCdLGtmguGXg?=
 =?us-ascii?Q?xnJZvlJiJB+ibt+1L1mtxNpmgUfyoJtG3sTeanD9f85nlQ9jFB8N53M8Mz0+?=
 =?us-ascii?Q?6XeO1FK5QJ1H1072e8cVVvBQyDlkNs8G7Bq8OgddPZ1x5D6k+1a9SM3kuBuN?=
 =?us-ascii?Q?RlmcNDoGHr3EABuOV+q3uIscSSrFYmDVVKejckWoJg4aTiIKGWeHwFzX6TCP?=
 =?us-ascii?Q?m2QnFXTlnFbSuxo3JlgZNGujzSFa3xlMPlyBZE9MJKM9W7/w/HdxGpnfqfTP?=
 =?us-ascii?Q?LHGrc6fAs14KXaUZl1o=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16168466-87e2-42c8-a545-08dc2c9a24b1
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 13:46:13.3449
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Pi2REATHYs9SPLUcoAnSnq+jPLfIdnChbNCDGh0GveJLZM+zNEV9GD7H+HQVaSj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6090

--=_MailMate_89108B55-2245-48B9-B728-510EAA2F55C2_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 13 Feb 2024, at 7:30, Pankaj Raghav (Samsung) wrote:

> Hi Zi yan,
>
>> From: Zi Yan <ziy@nvidia.com>
>>
>> Hi all,
>>
>> File folio supports any order and people would like to support flexibl=
e orders
>> for anonymous folio[1] too. Currently, split_huge_page() only splits a=
 huge
>> page to order-0 pages, but splitting to orders higher than 0 is also u=
seful.
>> This patchset adds support for splitting a huge page to any lower orde=
r pages
>> and uses it during file folio truncate operations.
>>
>
> I recently posted patches to enable block size > page size(Large Block
> Sizes) in XFS[1].
> The main idea of LBS is to have a notion of minimum order in the
> page cache that corresponds to the filesystem block size.
>
> Ability to split a folio based on a given order is something that would=

> definitely optimize the LBS implementation.
>
> The current implementation refuses to split a large folio if it has a
> minimum order set in the page cache [2]. What we would like to have ins=
tead
> is to split it based on the minimum order. The main use is of course be=
ing
> able to free some folios during partial truncate operation.
>
> Your patch was also suggested by willy during our LPC talk[3].
>
> I tried rebasing your patch and there were a lot of non-trivial conflic=
ts.
> Is there any plans on sending a new version?

Sure. I am going to rebase and send a new version out.

>
>
> [1] https://lore.kernel.org/linux-xfs/20240213093713.1753368-1-kernel@p=
ankajraghav.com/
> [2] https://lore.kernel.org/linux-xfs/20240213093713.1753368-9-kernel@p=
ankajraghav.com/
> [3] https://youtu.be/ar72r5Xf7x4?si=3DXDb-g7SSIgS-5TkP&t=3D1457
>
> --
> Pankaj

--
Best Regards,
Yan, Zi

--=_MailMate_89108B55-2245-48B9-B728-510EAA2F55C2_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXLcqIPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUxQkP/iJGDKyojTKfMi3YGIsmS/WroIS+LScZCK4C
ojRZPMY9Bsih90BB/vT+FZIXLPySfUtS7SpOVWuBJLijn8otxn/hUnYoRwXv97mI
OobjgCy2ec//LQtPzKuHCEkUNYnKd5V1d0QMghUZRK/fwLoU9ngGY7JsunqDT2Oh
lN1aSntTpv44IRNV8oXYVb7UiKZQWbZ12/r3YzSaaXwnbcfjXM07izBI/P32pxzD
x2tbrqmobd6XnwPRFWc1PpvswATQ4YcdDUK9oCuRH0XI5cqVnTXKaaef/zYcvfB5
r6+0tl+p/iTkkOnDQbp57B2jGfNiVhkDIeBBTBD9ibbchiO3lPLPBolTJ+BV6qOC
YbOhNY3L/hUQJZBg+nDUxe4bGQSeZGgJluDQJ/QdKAs2f6Uj22XFgl8DL+AtoMqa
SoldCmKUlSB22qr3BDvRxLV1fAQzSJrCsPMHBi5VXnEtZoALG910HFY6yPxSTgSo
uE81HPCu3sQXzy4ysmhSzqxLzduZ4/4VMV9jcY6WB+ShQihffbkJN9moQ1Nu5GMa
ty1YEjXzxKYo8v6XmjApYpBQ7PSM5bWLcbP2BWc3bO2qgAM6/Hn4plkN2CcNlgdt
f4Jhb20mnsRgKm05HOfddgAazPQiK3+pQ6bLGFHYlJd87n0e+uvlwualZK8zB/JC
ARFUM5rG
=PVPS
-----END PGP SIGNATURE-----

--=_MailMate_89108B55-2245-48B9-B728-510EAA2F55C2_=--