Received-SPF: pass (google.com: domain of linux-kernel+bounces-63630-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240212063233.5599-1-raag.jadav@intel.com>
In-Reply-To: <20240212063233.5599-1-raag.jadav@intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 13 Feb 2024 15:02:11 +0100
Message-ID: <CAJZ5v0huF=T_QH_Vzfmq07x2L_BPdCCdZSKzKOMYY19s37kjOw@mail.gmail.com>
Subject: Re: [PATCH v1] PCI / PM: Really allow runtime PM without callback functions
To: Raag Jadav <raag.jadav@intel.com>
Cc: bhelgaas@google.com, jarkko.nikula@linux.intel.com, 
	mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, 
	stanislaw.gruszka@linux.intel.com, lukas@wunner.de, rafael@kernel.org, 
	ilpo.jarvinen@linux.intel.com, linux-pci@vger.kernel.org, 
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	gregkh@linuxfoundation.org, sashal@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 12, 2024 at 7:32=E2=80=AFAM Raag Jadav <raag.jadav@intel.com> w=
rote:
>
> Commit c5eb1190074c ("PCI / PM: Allow runtime PM without callback
> functions") tried to eliminate the need for runtime PM callbacks
> by modifying pci_pm_runtime_suspend() and pci_pm_runtime_resume(),
> but didn't modify pci_pm_runtime_idle() with relevant changes, which
> still returns -ENOSYS if the driver supplies no runtime PM callbacks.
>
> Fix this by modifying pci_pm_runtime_idle() such that it allows PCI
> device power state transitions without runtime PM callbacks.
>
>  0)               |  pm_runtime_work() {
>  0)               |    rpm_idle() {
>  0)               |      rpm_check_suspend_allowed() {
>  0)   1.500 us    |        __dev_pm_qos_resume_latency(); /* =3D 0x7fffff=
ff */
>  0)   4.840 us    |      } /* rpm_check_suspend_allowed =3D 0x0 */
>  0)   1.550 us    |      __rpm_get_callback(); /* =3D 0xffffffffb4bc84f0 =
*/
>  0)   1.800 us    |      pci_pm_runtime_idle(); /* =3D -38 */
>  0) + 17.070 us   |    } /* rpm_idle =3D -38 */
>  0) + 22.450 us   |  } /* pm_runtime_work =3D -38 */
>
> Debugged-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

> ---
>
> This is not marked for linux-stable for the need of extensive testing
> and can be backported after a few releases if no issues are reported.
>
>  drivers/pci/pci-driver.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index 51ec9e7e784f..bb7f6775b350 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -1382,10 +1382,7 @@ static int pci_pm_runtime_idle(struct device *dev)
>         if (!pci_dev->driver)
>                 return 0;
>
> -       if (!pm)
> -               return -ENOSYS;
> -
> -       if (pm->runtime_idle)
> +       if (pm && pm->runtime_idle)
>                 return pm->runtime_idle(dev);
>
>         return 0;
> --
> 2.35.3
>
>